You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "suxiaogang223 (via GitHub)" <gi...@apache.org> on 2025/04/24 08:03:55 UTC
[PR] [improve](hive) Refactor csv reader [doris]
suxiaogang223 opened a new pull request, #50379:
URL: https://github.com/apache/doris/pull/50379
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2851954803
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2851197563
<details>
<summary>TPC-H: <b>Total hot run time: 34063 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aa941a4bdc89d862da03848b2752576437517703, data reload: false
------ Round 1 ----------------------------------
q1 25832 5075 5078 5075
q2 2069 274 178 178
q3 10632 1283 734 734
q4 10252 1050 535 535
q5 7904 2451 2350 2350
q6 188 169 136 136
q7 947 780 619 619
q8 9332 1354 1133 1133
q9 6731 5111 5190 5111
q10 6862 2302 1890 1890
q11 474 296 275 275
q12 358 361 214 214
q13 17789 3688 3110 3110
q14 243 223 210 210
q15 546 486 488 486
q16 429 428 368 368
q17 642 880 367 367
q18 7822 7153 7005 7005
q19 1820 963 565 565
q20 329 336 217 217
q21 4199 3454 2511 2511
q22 1032 989 974 974
Total cold run time: 116432 ms
Total hot run time: 34063 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5292 5502 5085 5085
q2 233 324 225 225
q3 2162 2679 2259 2259
q4 1429 1893 1510 1510
q5 4477 4445 4390 4390
q6 231 179 129 129
q7 2100 1910 1767 1767
q8 2639 2620 2585 2585
q9 7325 7130 7070 7070
q10 3013 3215 2785 2785
q11 585 517 497 497
q12 682 775 618 618
q13 3617 3943 3275 3275
q14 306 293 278 278
q15 546 497 500 497
q16 435 504 458 458
q17 1174 1622 1358 1358
q18 7657 7638 7400 7400
q19 845 839 938 839
q20 2023 1984 1842 1842
q21 5257 4903 4723 4723
q22 1103 1024 1047 1024
Total cold run time: 53131 ms
Total hot run time: 50614 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #50379:
URL: https://github.com/apache/doris/pull/50379#discussion_r2077071064
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -395,14 +328,10 @@ Status CsvReader::init_reader(bool is_load) {
if (_enclose == 0) {
text_line_reader_ctx = std::make_shared<PlainTextLineReaderCtx>(
Review Comment:
How about unify the naming of `PlainTextLineReaderCtx` and `EncloseCsvLineReaderContext`?
eg:
- PlainCsvLineReaderCtx
- EncloseCsvLineReaderCtx
##########
be/src/vec/data_types/serde/data_type_string_serde.h:
##########
@@ -64,6 +64,31 @@ inline void escape_string(const char* src, size_t& len, char escape_char) {
len = dest_ptr - start;
}
+// specially escape quote with double quote
+inline void escape_string_for_csv(const char* src, size_t& len, char escape_char, char quote_char) {
Review Comment:
better use pointer for out parameter
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -395,14 +328,10 @@ Status CsvReader::init_reader(bool is_load) {
if (_enclose == 0) {
text_line_reader_ctx = std::make_shared<PlainTextLineReaderCtx>(
_line_delimiter, _line_delimiter_length, _keep_cr);
- if (_text_serde_type == TTextSerdeType::HIVE_TEXT_SERDE) {
- _fields_splitter = std::make_unique<HiveCsvTextFieldSplitter>(
- _trim_tailing_spaces, false, _value_separator, _value_separator_length, -1,
- _escape);
- } else {
- _fields_splitter = std::make_unique<PlainCsvTextFieldSplitter>(
- _trim_tailing_spaces, false, _value_separator, _value_separator_length, -1);
- }
+ // TODO: make sure what table this splitter is used for
Review Comment:
What is this TODO mean?
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -649,11 +577,10 @@ Status CsvReader::_fill_dest_columns(const Slice& line, Block* block,
for (int i = 0; i < _file_slot_descs.size(); ++i) {
int col_idx = _col_idxs[i];
- // col idx is out of range, fill with null.
- const Slice& value = col_idx < _split_values.size()
- ? _split_values[col_idx]
- : Slice {_options.null_format, _options.null_len};
- Slice slice {value.data, value.size};
+ // col idx is out of range, fill with null format
+ auto value = col_idx < _split_values.size()
+ ? _split_values[col_idx]
+ : Slice(_options.null_format, _options.null_len);
Review Comment:
the `_options.null_len` may be zero?
And as you said, there is no definition for `null` value in csv, so how do we define `null` here?
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/LoadScanProvider.java:
##########
@@ -97,7 +96,8 @@ public FileLoadScanNode.ParamCreateContext createContext(Analyzer analyzer) thro
}
if (fileGroupInfo.getFileGroup().getFileFormat() != null
&& fileGroupInfo.getFileGroup().getFileFormat().equals("hive_text")) {
- params.setTextSerdeType(TTextSerdeType.HIVE_TEXT_SERDE);
+ // TODO: set correct format type for load job
Review Comment:
How to resolve this TODO?
##########
be/src/vec/exec/format/text/text_reader.cpp:
##########
@@ -0,0 +1,466 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "text_reader.h"
+
+#include <gen_cpp/PlanNodes_types.h>
+#include <gen_cpp/Types_types.h>
+#include <glog/logging.h>
+
+#include "common/compiler_util.h" // IWYU pragma: keep
+#include "common/status.h"
+#include "exec/decompressor.h"
+#include "exec/line_reader.h"
+#include "io/file_factory.h"
+#include "io/fs/buffered_reader.h"
+#include "io/fs/file_reader.h"
+#include "io/fs/s3_file_reader.h"
+#include "runtime/descriptors.h"
+#include "runtime/runtime_state.h"
+#include "vec/core/block.h"
+#include "vec/core/column_with_type_and_name.h"
+#include "vec/data_types/data_type_factory.hpp"
+#include "vec/exec/format/file_reader/new_plain_text_line_reader.h"
+#include "vec/exec/scan/scanner.h"
+
+namespace doris::vectorized {
+#include "common/compile_check_begin.h"
+
+void HiveCsvTextFieldSplitter::do_split(const Slice& line, std::vector<Slice>* splitted_values) {
Review Comment:
```suggestion
void HiveTextFieldSplitter::do_split(const Slice& line, std::vector<Slice>* splitted_values) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2875346594
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ce8b7c5f5c3badd342ea0b9eed0829071994960c_ce8b7c5f5c3badd342ea0b9eed0829071994960c_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ce8b7c5f5c3badd342ea0b9eed0829071994960c_ce8b7c5f5c3badd342ea0b9eed0829071994960c_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.20% (1104/1327) |
| Line Coverage | 66.11% (18600/28136) |
| Region Coverage | 65.68% (9259/14098) |
| Branch Coverage | 55.44% (4980/8982) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2877125995
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2940602347
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2921952540
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2900587964
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ca6fb29f8dc2beada465a1b27159efede6177ffc_ca6fb29f8dc2beada465a1b27159efede6177ffc_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ca6fb29f8dc2beada465a1b27159efede6177ffc_ca6fb29f8dc2beada465a1b27159efede6177ffc_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.14% (18668/28223) |
| Region Coverage | 65.75% (9256/14077) |
| Branch Coverage | 55.58% (4982/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2900841206
<details>
<summary>TPC-H: <b>Total hot run time: 34096 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ca6fb29f8dc2beada465a1b27159efede6177ffc, data reload: false
------ Round 1 ----------------------------------
q1 26099 5123 5108 5108
q2 2080 271 192 192
q3 10517 1270 704 704
q4 10233 1010 527 527
q5 7680 2390 2336 2336
q6 186 166 136 136
q7 936 737 622 622
q8 9327 1251 1107 1107
q9 6838 5131 5089 5089
q10 6828 2328 1903 1903
q11 482 293 273 273
q12 360 356 216 216
q13 17785 3730 3162 3162
q14 245 230 215 215
q15 551 498 517 498
q16 429 435 385 385
q17 619 844 377 377
q18 7479 7196 7064 7064
q19 1456 969 552 552
q20 342 331 226 226
q21 3958 3247 2403 2403
q22 1069 1024 1001 1001
Total cold run time: 115499 ms
Total hot run time: 34096 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5153 5116 5144 5116
q2 235 324 225 225
q3 2183 2670 2306 2306
q4 1390 1842 1407 1407
q5 4590 4471 4397 4397
q6 214 166 124 124
q7 1999 1900 1716 1716
q8 2557 2529 2484 2484
q9 7087 7039 7219 7039
q10 3044 3177 2788 2788
q11 573 503 488 488
q12 703 754 615 615
q13 3536 3915 3344 3344
q14 295 311 274 274
q15 546 525 504 504
q16 464 484 437 437
q17 1150 1567 1393 1393
q18 7660 7398 7421 7398
q19 793 834 901 834
q20 1973 2029 1890 1890
q21 5101 4510 4455 4455
q22 1051 1047 1002 1002
Total cold run time: 52297 ms
Total hot run time: 50236 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2900886952
<details>
<summary>ClickBench: <b>Total hot run time: 29.63 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ca6fb29f8dc2beada465a1b27159efede6177ffc, data reload: false
query1 0.03 0.03 0.04
query2 0.13 0.10 0.10
query3 0.27 0.19 0.19
query4 1.59 0.18 0.20
query5 0.45 0.44 0.44
query6 1.48 0.66 0.66
query7 0.02 0.02 0.01
query8 0.04 0.04 0.03
query9 0.59 0.51 0.51
query10 0.57 0.58 0.57
query11 0.15 0.11 0.12
query12 0.15 0.11 0.12
query13 0.62 0.60 0.61
query14 0.79 0.80 0.82
query15 0.89 0.85 0.87
query16 0.38 0.38 0.40
query17 1.04 1.06 1.07
query18 0.23 0.22 0.21
query19 1.93 1.81 1.87
query20 0.02 0.02 0.01
query21 15.41 0.90 0.53
query22 0.78 1.16 0.94
query23 15.07 1.42 0.66
query24 7.30 1.65 0.92
query25 0.46 0.14 0.14
query26 0.60 0.17 0.13
query27 0.04 0.05 0.06
query28 9.47 0.85 0.45
query29 12.52 3.99 3.34
query30 0.27 0.09 0.07
query31 2.81 0.57 0.38
query32 3.23 0.56 0.46
query33 3.04 3.15 3.07
query34 15.74 5.15 4.52
query35 4.55 4.56 4.52
query36 0.67 0.50 0.48
query37 0.08 0.06 0.06
query38 0.06 0.04 0.04
query39 0.03 0.02 0.02
query40 0.16 0.13 0.12
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.04 0.04 0.03
Total cold run time: 103.81 s
Total hot run time: 29.63 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2907924735
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2829775659
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837832543
<details>
<summary>ClickBench: <b>Total hot run time: 29.93 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit de50d882580d5dbe9a4e0d1c2a701e9c9f262b53, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.11
query3 0.25 0.20 0.19
query4 1.60 0.19 0.19
query5 0.59 0.61 0.59
query6 1.19 0.72 0.72
query7 0.03 0.02 0.02
query8 0.04 0.04 0.03
query9 0.58 0.52 0.53
query10 0.57 0.57 0.56
query11 0.16 0.11 0.11
query12 0.14 0.11 0.12
query13 0.60 0.59 0.59
query14 0.79 0.79 0.80
query15 0.87 0.86 0.85
query16 0.38 0.39 0.38
query17 1.03 1.05 1.07
query18 0.20 0.20 0.20
query19 1.87 1.76 1.75
query20 0.01 0.01 0.02
query21 15.42 0.94 0.54
query22 0.75 1.37 0.81
query23 14.72 1.39 0.67
query24 6.91 1.42 1.43
query25 0.52 0.07 0.13
query26 0.65 0.16 0.15
query27 0.06 0.05 0.05
query28 9.84 0.83 0.44
query29 12.58 3.96 3.28
query30 0.25 0.09 0.07
query31 2.82 0.62 0.40
query32 3.23 0.57 0.46
query33 3.11 3.05 3.01
query34 15.79 5.06 4.48
query35 4.52 4.52 4.49
query36 0.65 0.49 0.48
query37 0.09 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.03 0.03
query40 0.18 0.15 0.13
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.04 0.04 0.03
Total cold run time: 103.38 s
Total hot run time: 29.93 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2833506568
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2833826883
TeamCity cloud ut coverage result:
Function Coverage: 83.06% (1098/1322)
Line Coverage: 65.83% (18372/27909)
Region Coverage: 65.31% (9113/13954)
Branch Coverage: 55.19% (4895/8870)
Coverage Report: http://coverage.selectdb-in.cc/coverage/52a7949fc04539b6896be4dc0a35c46db90b026a_52a7949fc04539b6896be4dc0a35c46db90b026a_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2930774012
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/3a662dc35fb3163b0aebab385d2348d8bb2b64d7_3a662dc35fb3163b0aebab385d2348d8bb2b64d7_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/3a662dc35fb3163b0aebab385d2348d8bb2b64d7_3a662dc35fb3163b0aebab385d2348d8bb2b64d7_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1118/1342) |
| Line Coverage | 66.76% (19136/28663) |
| Region Coverage | 66.40% (9469/14261) |
| Branch Coverage | 56.35% (5131/9106) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2940996557
<details>
<summary>TPC-H: <b>Total hot run time: 33921 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fdf333a26acbd27a5a03160a1a472c72d8684d46, data reload: false
------ Round 1 ----------------------------------
q1 26609 5010 5020 5010
q2 1956 283 189 189
q3 10430 1233 713 713
q4 10228 984 533 533
q5 7714 2366 2290 2290
q6 188 163 130 130
q7 904 749 610 610
q8 9324 1291 1155 1155
q9 6792 5099 5088 5088
q10 6856 2304 1906 1906
q11 501 277 275 275
q12 344 350 211 211
q13 17767 3706 3096 3096
q14 243 228 223 223
q15 571 487 494 487
q16 439 428 379 379
q17 619 856 386 386
q18 7542 7204 7214 7204
q19 1994 980 557 557
q20 331 329 219 219
q21 3810 3201 2330 2330
q22 1045 1019 930 930
Total cold run time: 116207 ms
Total hot run time: 33921 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5217 5003 5033 5003
q2 243 321 219 219
q3 2166 2639 2287 2287
q4 1343 1776 1367 1367
q5 4481 4428 4418 4418
q6 217 171 126 126
q7 2052 1951 1773 1773
q8 2666 2536 2501 2501
q9 7179 7137 7063 7063
q10 2993 3206 2780 2780
q11 556 505 503 503
q12 721 793 636 636
q13 3602 3869 3347 3347
q14 288 292 266 266
q15 522 484 469 469
q16 438 499 450 450
q17 1157 1565 1360 1360
q18 7796 7682 7435 7435
q19 800 839 911 839
q20 1936 2002 1823 1823
q21 4857 4539 4390 4390
q22 1072 1038 1016 1016
Total cold run time: 52302 ms
Total hot run time: 50071 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2941054163
<details>
<summary>ClickBench: <b>Total hot run time: 29.58 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fdf333a26acbd27a5a03160a1a472c72d8684d46, data reload: false
query1 0.03 0.04 0.02
query2 0.15 0.10 0.12
query3 0.34 0.20 0.20
query4 1.60 0.09 0.11
query5 0.43 0.42 0.40
query6 1.16 0.67 0.68
query7 0.02 0.02 0.01
query8 0.06 0.05 0.05
query9 0.63 0.53 0.53
query10 0.59 0.58 0.56
query11 0.26 0.13 0.13
query12 0.25 0.13 0.14
query13 0.63 0.62 0.62
query14 0.79 0.84 0.82
query15 0.97 0.87 0.88
query16 0.37 0.38 0.38
query17 1.08 1.06 1.02
query18 0.19 0.18 0.19
query19 1.96 1.84 1.86
query20 0.02 0.01 0.01
query21 15.41 0.98 0.67
query22 0.94 1.03 0.80
query23 14.68 1.57 0.75
query24 5.29 0.60 0.29
query25 0.16 0.09 0.09
query26 0.55 0.24 0.19
query27 0.09 0.09 0.08
query28 11.05 1.19 0.58
query29 12.54 4.03 3.36
query30 0.28 0.08 0.06
query31 2.82 0.62 0.43
query32 3.23 0.59 0.51
query33 3.09 3.13 3.06
query34 16.23 5.14 4.49
query35 4.45 4.47 4.39
query36 0.64 0.51 0.51
query37 0.19 0.18 0.17
query38 0.17 0.16 0.16
query39 0.05 0.04 0.05
query40 0.20 0.18 0.16
query41 0.11 0.06 0.06
query42 0.07 0.05 0.06
query43 0.06 0.05 0.05
Total cold run time: 103.83 s
Total hot run time: 29.58 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2850239708
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2877561343
<details>
<summary>ClickBench: <b>Total hot run time: 29.88 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ce0d08255e5ac9042d3c5272d45360605f1ea8d5, data reload: false
query1 0.04 0.04 0.03
query2 0.14 0.12 0.11
query3 0.34 0.20 0.19
query4 1.60 0.22 0.07
query5 0.55 0.53 0.54
query6 1.17 0.72 0.73
query7 0.02 0.02 0.01
query8 0.05 0.05 0.05
query9 0.62 0.52 0.53
query10 0.56 0.58 0.58
query11 0.25 0.13 0.13
query12 0.26 0.14 0.14
query13 0.63 0.61 0.62
query14 0.80 0.81 0.82
query15 0.97 0.88 0.88
query16 0.37 0.38 0.36
query17 1.06 1.04 1.06
query18 0.19 0.19 0.18
query19 1.99 1.83 1.91
query20 0.01 0.01 0.02
query21 15.41 0.96 0.66
query22 0.93 1.04 0.77
query23 14.70 1.52 0.78
query24 5.53 0.54 0.27
query25 0.17 0.09 0.08
query26 0.57 0.22 0.18
query27 0.08 0.08 0.08
query28 11.00 1.20 0.59
query29 12.62 4.11 3.46
query30 0.28 0.09 0.06
query31 2.80 0.65 0.42
query32 3.23 0.59 0.49
query33 3.05 3.08 3.12
query34 16.64 5.08 4.54
query35 4.40 4.46 4.46
query36 0.64 0.51 0.50
query37 0.19 0.17 0.18
query38 0.17 0.16 0.16
query39 0.04 0.04 0.05
query40 0.19 0.16 0.15
query41 0.11 0.05 0.04
query42 0.06 0.06 0.05
query43 0.06 0.05 0.05
Total cold run time: 104.49 s
Total hot run time: 29.88 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2875592765
<details>
<summary>TPC-H: <b>Total hot run time: 34006 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ce8b7c5f5c3badd342ea0b9eed0829071994960c, data reload: false
------ Round 1 ----------------------------------
q1 26572 5054 5089 5054
q2 2097 292 208 208
q3 10529 1307 689 689
q4 10231 1002 531 531
q5 7799 2396 2321 2321
q6 179 166 138 138
q7 920 740 614 614
q8 9302 1265 1097 1097
q9 6805 5163 5191 5163
q10 6835 2335 1911 1911
q11 487 294 274 274
q12 349 350 223 223
q13 17787 3676 3115 3115
q14 245 223 217 217
q15 528 485 481 481
q16 434 447 381 381
q17 602 871 358 358
q18 7726 7191 7016 7016
q19 2164 984 572 572
q20 329 320 229 229
q21 3930 2635 2439 2439
q22 1038 1027 975 975
Total cold run time: 116888 ms
Total hot run time: 34006 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5200 5083 5105 5083
q2 248 326 231 231
q3 2191 2697 2302 2302
q4 1356 1813 1485 1485
q5 4454 4377 4423 4377
q6 220 169 130 130
q7 2015 1957 1780 1780
q8 2592 2661 2543 2543
q9 7351 7135 7035 7035
q10 3022 3215 2773 2773
q11 584 526 497 497
q12 669 748 627 627
q13 3481 3958 3289 3289
q14 286 307 288 288
q15 535 499 506 499
q16 434 493 436 436
q17 1155 1576 1482 1482
q18 7779 7612 7482 7482
q19 792 760 819 760
q20 2019 2005 1869 1869
q21 5295 4709 4724 4709
q22 1120 1070 1013 1013
Total cold run time: 52798 ms
Total hot run time: 50690 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2877549038
<details>
<summary>TPC-DS: <b>Total hot run time: 193836 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ce0d08255e5ac9042d3c5272d45360605f1ea8d5, data reload: false
query1 1409 1115 1078 1078
query2 6213 1879 1868 1868
query3 11064 4432 4492 4432
query4 57167 24218 23360 23360
query5 5076 502 455 455
query6 404 218 202 202
query7 5119 499 296 296
query8 333 269 243 243
query9 6775 2671 2704 2671
query10 437 332 283 283
query11 15197 15062 14860 14860
query12 159 118 109 109
query13 1184 542 413 413
query14 10165 6423 6341 6341
query15 208 206 179 179
query16 7122 685 490 490
query17 1078 729 595 595
query18 1622 393 294 294
query19 195 203 169 169
query20 143 126 115 115
query21 213 126 113 113
query22 4486 4362 4260 4260
query23 34237 33585 33630 33585
query24 6637 2440 2453 2440
query25 471 471 402 402
query26 695 293 162 162
query27 2179 531 350 350
query28 3123 2218 2188 2188
query29 605 554 440 440
query30 275 222 201 201
query31 881 897 802 802
query32 73 66 69 66
query33 466 395 307 307
query34 784 889 541 541
query35 798 847 766 766
query36 927 1002 907 907
query37 113 105 80 80
query38 4205 4273 4164 4164
query39 1548 1436 1459 1436
query40 218 135 117 117
query41 60 57 57 57
query42 128 117 112 112
query43 525 519 502 502
query44 1374 872 881 872
query45 183 177 172 172
query46 886 1045 668 668
query47 1817 1836 1810 1810
query48 409 443 333 333
query49 747 527 442 442
query50 680 724 410 410
query51 4233 4288 4331 4288
query52 118 110 103 103
query53 234 261 197 197
query54 600 585 530 530
query55 86 86 88 86
query56 312 307 299 299
query57 1156 1150 1140 1140
query58 280 259 261 259
query59 2849 2899 2685 2685
query60 352 342 326 326
query61 130 123 121 121
query62 739 796 683 683
query63 236 205 204 204
query64 1661 1054 743 743
query65 4294 4224 4214 4214
query66 713 396 311 311
query67 15861 15680 15313 15313
query68 7559 910 538 538
query69 534 323 268 268
query70 1222 1088 1105 1088
query71 504 318 308 308
query72 5990 4813 4919 4813
query73 1281 639 361 361
query74 9110 9073 8998 8998
query75 3837 3270 2728 2728
query76 4291 1194 767 767
query77 712 435 301 301
query78 10035 10213 9316 9316
query79 2301 825 590 590
query80 636 499 463 463
query81 481 249 224 224
query82 420 133 98 98
query83 382 253 227 227
query84 297 100 84 84
query85 817 360 325 325
query86 390 290 276 276
query87 4400 4531 4352 4352
query88 3243 2296 2327 2296
query89 400 316 286 286
query90 1940 206 208 206
query91 141 141 111 111
query92 73 62 52 52
query93 1148 962 587 587
query94 693 405 303 303
query95 366 296 276 276
query96 508 575 282 282
query97 3225 3221 3114 3114
query98 226 217 210 210
query99 1413 1415 1328 1328
Total cold run time: 303242 ms
Total hot run time: 193836 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2890210311
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945419247
<details>
<summary>TPC-DS: <b>Total hot run time: 186043 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5d3d0109fc32ee4e564be68bd5c289a755438b30, data reload: false
query1 1008 474 483 474
query2 6551 1879 1803 1803
query3 6753 226 221 221
query4 26356 23772 22844 22844
query5 4326 670 470 470
query6 306 213 219 213
query7 4623 512 296 296
query8 264 240 221 221
query9 8604 2644 2648 2644
query10 485 352 278 278
query11 15278 15052 14866 14866
query12 178 112 110 110
query13 1633 553 405 405
query14 8719 6001 6088 6001
query15 196 193 167 167
query16 7155 673 492 492
query17 933 756 558 558
query18 1955 405 289 289
query19 192 184 162 162
query20 123 120 121 120
query21 211 132 108 108
query22 4218 4267 4217 4217
query23 34156 33122 33110 33110
query24 8630 2396 2404 2396
query25 552 459 420 420
query26 1233 285 157 157
query27 2748 521 340 340
query28 4303 2148 2115 2115
query29 760 595 430 430
query30 284 223 190 190
query31 943 864 758 758
query32 76 67 63 63
query33 545 367 308 308
query34 791 921 525 525
query35 792 837 741 741
query36 1009 1023 884 884
query37 122 107 82 82
query38 4111 4240 4019 4019
query39 1472 1438 1453 1438
query40 217 126 116 116
query41 70 65 67 65
query42 140 121 110 110
query43 507 527 469 469
query44 1370 827 828 827
query45 186 183 179 179
query46 898 1103 626 626
query47 1814 1811 1733 1733
query48 395 467 317 317
query49 777 533 422 422
query50 677 744 418 418
query51 4140 4120 4111 4111
query52 114 112 103 103
query53 229 267 200 200
query54 600 593 518 518
query55 98 86 86 86
query56 329 308 319 308
query57 1191 1157 1085 1085
query58 266 263 258 258
query59 2589 2676 2492 2492
query60 320 330 314 314
query61 125 123 122 122
query62 851 768 675 675
query63 227 186 184 184
query64 4402 998 681 681
query65 4339 4138 4176 4138
query66 1138 446 312 312
query67 15842 15829 15513 15513
query68 8559 908 549 549
query69 486 314 270 270
query70 1241 1152 1096 1096
query71 455 333 302 302
query72 5359 4731 4666 4666
query73 701 586 355 355
query74 8891 9153 9246 9153
query75 3951 3318 2710 2710
query76 3627 1316 800 800
query77 799 388 301 301
query78 10253 10094 9336 9336
query79 2798 862 604 604
query80 748 539 448 448
query81 484 271 216 216
query82 540 139 95 95
query83 291 259 233 233
query84 297 109 91 91
query85 807 360 340 340
query86 391 302 285 285
query87 4427 4502 4339 4339
query88 3719 2277 2278 2277
query89 431 321 283 283
query90 1837 209 207 207
query91 151 140 113 113
query92 78 71 60 60
query93 1966 959 591 591
query94 655 446 309 309
query95 373 294 287 287
query96 514 618 288 288
query97 2728 2809 2631 2631
query98 251 208 199 199
query99 1462 1498 1292 1292
Total cold run time: 275715 ms
Total hot run time: 186043 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2901842625
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2903749307
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2253603deb065239177f2befdc0eac6184adfc0a_2253603deb065239177f2befdc0eac6184adfc0a_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2253603deb065239177f2befdc0eac6184adfc0a_2253603deb065239177f2befdc0eac6184adfc0a_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.13% (18665/28223) |
| Region Coverage | 65.75% (9256/14077) |
| Branch Coverage | 55.57% (4981/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2826724455
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2909128620
<details>
<summary>ClickBench: <b>Total hot run time: 30 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 67fcd97f506f6be6cafcc187cf92c8e99aadadb2, data reload: false
query1 0.03 0.03 0.03
query2 0.15 0.11 0.11
query3 0.36 0.20 0.20
query4 1.59 0.21 0.20
query5 0.48 0.47 0.46
query6 1.15 0.64 0.67
query7 0.02 0.02 0.01
query8 0.06 0.05 0.05
query9 0.63 0.52 0.53
query10 0.58 0.58 0.58
query11 0.26 0.13 0.13
query12 0.25 0.13 0.13
query13 0.64 0.62 0.63
query14 0.80 0.83 0.82
query15 0.99 0.89 0.89
query16 0.36 0.38 0.38
query17 1.10 1.06 1.03
query18 0.19 0.19 0.19
query19 2.01 1.85 1.91
query20 0.01 0.02 0.01
query21 15.41 1.00 0.69
query22 0.93 1.07 0.76
query23 14.67 1.51 0.77
query24 5.43 0.53 0.28
query25 0.16 0.09 0.09
query26 0.56 0.21 0.19
query27 0.09 0.08 0.08
query28 11.03 1.21 0.58
query29 12.56 4.14 3.47
query30 0.28 0.09 0.07
query31 2.82 0.63 0.42
query32 3.23 0.59 0.50
query33 3.06 3.13 3.18
query34 16.36 5.05 4.45
query35 4.46 4.50 4.50
query36 0.64 0.50 0.50
query37 0.19 0.17 0.18
query38 0.17 0.16 0.16
query39 0.04 0.04 0.04
query40 0.20 0.15 0.15
query41 0.10 0.05 0.05
query42 0.06 0.05 0.06
query43 0.06 0.05 0.05
Total cold run time: 104.17 s
Total hot run time: 30 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2910203456
<details>
<summary>TPC-DS: <b>Total hot run time: 185591 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cfefcb593357db219db76f3389ca8974c0b938a0, data reload: false
query1 1026 488 504 488
query2 6595 1876 1849 1849
query3 6763 230 224 224
query4 26242 23757 23096 23096
query5 4331 620 455 455
query6 310 207 200 200
query7 4630 509 298 298
query8 297 252 258 252
query9 8622 2596 2600 2596
query10 500 327 272 272
query11 15928 15021 14757 14757
query12 179 115 107 107
query13 1659 528 411 411
query14 9617 6117 6188 6117
query15 198 202 172 172
query16 7311 642 488 488
query17 1208 777 578 578
query18 1965 390 290 290
query19 198 210 162 162
query20 120 124 151 124
query21 212 120 103 103
query22 4094 4042 3933 3933
query23 34278 33024 33098 33024
query24 8490 2400 2381 2381
query25 562 469 392 392
query26 1242 271 154 154
query27 2742 507 340 340
query28 4322 2112 2089 2089
query29 759 552 421 421
query30 318 214 193 193
query31 957 865 762 762
query32 73 66 90 66
query33 597 370 325 325
query34 811 838 525 525
query35 766 796 711 711
query36 959 978 904 904
query37 118 102 79 79
query38 4156 4151 4034 4034
query39 1470 1416 1442 1416
query40 212 118 108 108
query41 58 56 57 56
query42 129 110 116 110
query43 514 511 501 501
query44 1347 831 826 826
query45 175 174 165 165
query46 865 1040 644 644
query47 1767 1797 1711 1711
query48 392 440 319 319
query49 776 539 426 426
query50 650 695 404 404
query51 4146 4147 4190 4147
query52 112 109 102 102
query53 231 263 183 183
query54 581 571 508 508
query55 86 82 86 82
query56 314 331 294 294
query57 1155 1135 1077 1077
query58 270 261 290 261
query59 2664 2749 2703 2703
query60 344 344 298 298
query61 126 126 129 126
query62 785 770 677 677
query63 232 185 187 185
query64 4324 997 677 677
query65 4332 4253 4286 4253
query66 1126 428 307 307
query67 16057 15572 15319 15319
query68 8495 897 520 520
query69 465 314 271 271
query70 1205 1092 1140 1092
query71 472 320 301 301
query72 5499 4771 4904 4771
query73 751 783 359 359
query74 8886 8867 8993 8867
query75 3964 3231 2700 2700
query76 3726 1191 761 761
query77 790 383 310 310
query78 10173 10205 9297 9297
query79 2220 825 564 564
query80 611 505 440 440
query81 471 261 220 220
query82 430 130 101 101
query83 288 248 231 231
query84 297 114 82 82
query85 808 355 311 311
query86 339 292 291 291
query87 4487 4364 4345 4345
query88 3127 2279 2332 2279
query89 386 317 294 294
query90 1952 226 211 211
query91 145 150 115 115
query92 78 69 56 56
query93 1641 983 582 582
query94 663 401 303 303
query95 382 301 281 281
query96 492 583 287 287
query97 2748 2819 2628 2628
query98 240 209 205 205
query99 1426 1399 1259 1259
Total cold run time: 276052 ms
Total hot run time: 185591 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2899824508
<details>
<summary>ClickBench: <b>Total hot run time: 29.79 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 52fa5c5962bbc72ffa38580cf8a1050eb0367689, data reload: false
query1 0.04 0.03 0.03
query2 0.15 0.11 0.11
query3 0.34 0.20 0.20
query4 1.59 0.21 0.20
query5 0.48 0.45 0.45
query6 1.17 0.66 0.66
query7 0.02 0.01 0.02
query8 0.05 0.04 0.04
query9 0.63 0.53 0.52
query10 0.57 0.58 0.56
query11 0.26 0.12 0.13
query12 0.25 0.13 0.13
query13 0.64 0.61 0.63
query14 0.80 0.81 0.83
query15 0.95 0.87 0.86
query16 0.38 0.36 0.37
query17 1.05 1.07 1.06
query18 0.18 0.18 0.18
query19 2.00 1.82 1.82
query20 0.01 0.02 0.01
query21 15.40 0.99 0.67
query22 0.93 1.08 0.81
query23 14.68 1.53 0.77
query24 5.53 0.57 0.28
query25 0.17 0.09 0.08
query26 0.56 0.21 0.18
query27 0.09 0.08 0.08
query28 11.03 1.17 0.59
query29 12.54 4.01 3.42
query30 0.28 0.09 0.06
query31 2.80 0.63 0.44
query32 3.24 0.60 0.51
query33 3.14 3.11 3.14
query34 16.64 5.11 4.44
query35 4.48 4.45 4.50
query36 0.64 0.51 0.49
query37 0.20 0.17 0.17
query38 0.16 0.15 0.15
query39 0.05 0.05 0.05
query40 0.20 0.17 0.16
query41 0.11 0.05 0.05
query42 0.06 0.06 0.05
query43 0.05 0.04 0.04
Total cold run time: 104.54 s
Total hot run time: 29.79 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on code in PR #50379:
URL: https://github.com/apache/doris/pull/50379#discussion_r2122533569
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/LoadScanProvider.java:
##########
@@ -95,10 +94,7 @@ public FileLoadScanNode.ParamCreateContext createContext(Analyzer analyzer) thro
if (fileGroupInfo.getSequenceMapCol() != null) {
params.setSequenceMapCol(fileGroupInfo.getSequenceMapCol());
}
- if (fileFormatProperties.getFormatName().equals("hive_text")) {
- params.setTextSerdeType(TTextSerdeType.HIVE_TEXT_SERDE);
- }
- params.setProperties(fileGroupInfo.getBrokerDesc().getBackendConfigProperties());
+ params.setProperties(fileGroupInfo.getBrokerDesc().getProperties());
Review Comment:
looks like createContext should not be called in latest master, could you please show an example that how this function is called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945440217
<details>
<summary>ClickBench: <b>Total hot run time: 28.58 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5d3d0109fc32ee4e564be68bd5c289a755438b30, data reload: false
query1 0.03 0.04 0.03
query2 0.12 0.11 0.10
query3 0.26 0.19 0.20
query4 1.60 0.19 0.11
query5 0.42 0.41 0.42
query6 1.19 0.66 0.66
query7 0.03 0.02 0.02
query8 0.05 0.03 0.04
query9 0.57 0.52 0.51
query10 0.56 0.56 0.57
query11 0.16 0.10 0.12
query12 0.14 0.12 0.12
query13 0.61 0.60 0.59
query14 0.79 0.80 0.82
query15 0.89 0.87 0.86
query16 0.38 0.39 0.37
query17 1.02 1.06 1.04
query18 0.23 0.22 0.21
query19 1.92 1.78 1.90
query20 0.01 0.02 0.01
query21 15.40 0.90 0.55
query22 0.77 1.16 0.62
query23 15.06 1.39 0.65
query24 6.54 1.25 0.29
query25 0.34 0.29 0.06
query26 0.48 0.17 0.13
query27 0.06 0.06 0.05
query28 9.86 0.98 0.46
query29 12.55 3.96 3.37
query30 0.25 0.10 0.07
query31 2.81 0.60 0.39
query32 3.24 0.57 0.46
query33 3.05 3.05 3.09
query34 15.92 5.15 4.56
query35 4.56 4.58 4.57
query36 0.66 0.49 0.48
query37 0.09 0.07 0.06
query38 0.05 0.05 0.04
query39 0.03 0.02 0.02
query40 0.17 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.03
query43 0.04 0.03 0.03
Total cold run time: 103.02 s
Total hot run time: 28.58 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #50379:
URL: https://github.com/apache/doris/pull/50379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2841426263
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2833925338
<details>
<summary>TPC-DS: <b>Total hot run time: 185210 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 52a7949fc04539b6896be4dc0a35c46db90b026a, data reload: false
query1 1016 473 520 473
query2 6569 1803 1749 1749
query3 6751 230 216 216
query4 26090 23295 23422 23295
query5 4329 606 452 452
query6 292 215 200 200
query7 4622 495 280 280
query8 300 257 244 244
query9 8658 2575 2582 2575
query10 472 308 263 263
query11 15567 15175 14781 14781
query12 161 121 112 112
query13 1671 525 405 405
query14 8749 5960 6468 5960
query15 204 186 170 170
query16 7181 632 473 473
query17 1190 688 560 560
query18 1974 387 293 293
query19 188 200 152 152
query20 119 118 115 115
query21 206 128 112 112
query22 3976 4181 4065 4065
query23 33824 32748 32949 32748
query24 8466 2356 2350 2350
query25 534 466 394 394
query26 1236 278 168 168
query27 2732 504 327 327
query28 4346 2115 2097 2097
query29 762 551 421 421
query30 281 213 196 196
query31 931 854 727 727
query32 73 68 65 65
query33 551 357 318 318
query34 782 863 513 513
query35 787 816 732 732
query36 958 994 886 886
query37 111 102 74 74
query38 4172 4208 4065 4065
query39 1439 1382 1409 1382
query40 217 121 105 105
query41 61 54 52 52
query42 122 104 114 104
query43 508 501 458 458
query44 1281 812 804 804
query45 173 174 169 169
query46 817 1023 616 616
query47 1773 1809 1740 1740
query48 367 410 305 305
query49 781 484 414 414
query50 634 666 408 408
query51 4161 4142 4070 4070
query52 116 111 97 97
query53 228 254 180 180
query54 581 569 500 500
query55 80 78 78 78
query56 296 289 291 289
query57 1137 1136 1088 1088
query58 267 265 261 261
query59 2579 2688 2570 2570
query60 335 347 330 330
query61 152 150 152 150
query62 809 728 655 655
query63 227 195 186 186
query64 4502 1074 673 673
query65 4310 4178 4161 4161
query66 1198 432 305 305
query67 15901 15505 15258 15258
query68 7902 880 534 534
query69 475 297 263 263
query70 1171 1116 1059 1059
query71 479 315 282 282
query72 5703 4770 4820 4770
query73 687 631 357 357
query74 8790 9236 8902 8902
query75 3714 3183 2788 2788
query76 3616 1190 758 758
query77 804 378 289 289
query78 9922 9954 9305 9305
query79 2416 801 568 568
query80 695 557 438 438
query81 501 251 210 210
query82 471 130 103 103
query83 287 259 225 225
query84 287 104 89 89
query85 787 362 316 316
query86 387 294 301 294
query87 4308 4359 4281 4281
query88 3747 2186 2198 2186
query89 385 319 283 283
query90 1832 209 222 209
query91 147 145 111 111
query92 77 62 60 60
query93 2129 955 584 584
query94 683 415 315 315
query95 371 295 287 287
query96 484 562 271 271
query97 3142 3270 3157 3157
query98 248 202 210 202
query99 1457 1378 1280 1280
Total cold run time: 273987 ms
Total hot run time: 185210 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2828306397
<details>
<summary>TPC-DS: <b>Total hot run time: 184641 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5650a1d1a11b09aa9f804cf810d60aec61718c1f, data reload: false
query1 1032 454 499 454
query2 6662 1852 1870 1852
query3 6764 222 213 213
query4 26305 23659 22917 22917
query5 4333 607 471 471
query6 321 209 217 209
query7 4625 486 289 289
query8 297 243 236 236
query9 8652 2523 2546 2523
query10 485 289 251 251
query11 16010 14960 14776 14776
query12 165 108 109 108
query13 1675 522 389 389
query14 9412 6179 6159 6159
query15 201 185 172 172
query16 7252 635 444 444
query17 1203 719 576 576
query18 1985 405 302 302
query19 190 183 160 160
query20 119 120 120 120
query21 214 133 109 109
query22 4068 4165 3962 3962
query23 33966 32945 33119 32945
query24 8405 2361 2370 2361
query25 539 486 374 374
query26 1236 263 149 149
query27 2756 508 325 325
query28 4340 2092 2068 2068
query29 764 581 425 425
query30 281 211 182 182
query31 931 864 754 754
query32 72 69 69 69
query33 559 377 303 303
query34 795 847 507 507
query35 769 787 742 742
query36 929 992 910 910
query37 113 98 77 77
query38 4198 4121 4077 4077
query39 1473 1387 1390 1387
query40 211 123 107 107
query41 55 53 55 53
query42 117 103 106 103
query43 516 490 462 462
query44 1311 789 798 789
query45 177 175 164 164
query46 817 1015 620 620
query47 1724 1792 1708 1708
query48 370 398 308 308
query49 771 483 407 407
query50 636 671 399 399
query51 4125 4055 4074 4055
query52 107 111 96 96
query53 217 252 179 179
query54 578 597 494 494
query55 82 78 82 78
query56 291 294 293 293
query57 1141 1146 1050 1050
query58 261 259 246 246
query59 2614 2591 2546 2546
query60 322 305 291 291
query61 129 131 127 127
query62 809 705 679 679
query63 229 185 182 182
query64 4297 1013 719 719
query65 4355 4245 4231 4231
query66 1133 449 306 306
query67 15695 15406 15155 15155
query68 8675 880 522 522
query69 467 300 261 261
query70 1195 1140 1096 1096
query71 487 324 291 291
query72 5511 4672 4688 4672
query73 732 607 338 338
query74 8866 8850 8967 8850
query75 4031 3202 2703 2703
query76 3709 1182 743 743
query77 789 377 287 287
query78 9933 10231 9231 9231
query79 1907 798 563 563
query80 591 523 449 449
query81 476 250 217 217
query82 435 123 94 94
query83 260 248 233 233
query84 243 111 85 85
query85 782 357 315 315
query86 346 268 283 268
query87 4344 4476 4344 4344
query88 3182 2170 2154 2154
query89 383 317 288 288
query90 1937 207 206 206
query91 139 141 111 111
query92 76 62 61 61
query93 1065 933 581 581
query94 670 399 313 313
query95 373 294 288 288
query96 476 563 268 268
query97 3149 3210 3125 3125
query98 223 201 198 198
query99 1436 1414 1292 1292
Total cold run time: 274074 ms
Total hot run time: 184641 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2834495333
<details>
<summary>TPC-H: <b>Total hot run time: 33981 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a772c870025b13d35a08d10543510c94f52d3bf, data reload: false
------ Round 1 ----------------------------------
q1 26310 5012 4971 4971
q2 2093 280 179 179
q3 10579 1276 697 697
q4 10235 1022 536 536
q5 7845 2390 2386 2386
q6 185 161 132 132
q7 915 749 623 623
q8 9318 1333 1119 1119
q9 6788 5042 5112 5042
q10 6826 2297 1875 1875
q11 490 280 273 273
q12 346 359 215 215
q13 17768 3676 3108 3108
q14 232 229 221 221
q15 530 474 513 474
q16 429 440 384 384
q17 599 876 365 365
q18 7662 7130 7223 7130
q19 2391 980 559 559
q20 318 320 216 216
q21 3947 3431 2512 2512
q22 1051 1029 964 964
Total cold run time: 116857 ms
Total hot run time: 33981 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5212 5039 5053 5039
q2 241 329 230 230
q3 2178 2695 2356 2356
q4 1407 1805 1497 1497
q5 4478 4419 4412 4412
q6 222 167 130 130
q7 2011 1921 1768 1768
q8 2627 2574 2569 2569
q9 7200 7080 7200 7080
q10 2986 3168 2778 2778
q11 563 524 504 504
q12 668 769 643 643
q13 3534 3949 3352 3352
q14 283 309 263 263
q15 532 489 488 488
q16 448 477 440 440
q17 1164 1595 1356 1356
q18 7712 7535 7529 7529
q19 829 868 1051 868
q20 1970 1963 1864 1864
q21 5311 4728 4743 4728
q22 1116 1062 1035 1035
Total cold run time: 52692 ms
Total hot run time: 50929 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2850311900
TeamCity cloud ut coverage result:
Function Coverage: 83.08% (1100/1324)
Line Coverage: 65.94% (18425/27940)
Region Coverage: 65.37% (9130/13967)
Branch Coverage: 55.30% (4908/8876)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3adb0997913759cd611830bfec895bd632526de5_3adb0997913759cd611830bfec895bd632526de5_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2852279283
<details>
<summary>TPC-H: <b>Total hot run time: 33679 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07236b6a14c6d794c68952ce96264e4193e00838, data reload: false
------ Round 1 ----------------------------------
q1 26090 5008 4971 4971
q2 2088 281 179 179
q3 10662 1262 724 724
q4 10263 1016 522 522
q5 7984 2369 2339 2339
q6 183 162 131 131
q7 942 787 615 615
q8 9320 1278 1032 1032
q9 6747 5124 5046 5046
q10 6816 2300 1898 1898
q11 456 268 277 268
q12 348 348 213 213
q13 17758 3634 3056 3056
q14 239 234 214 214
q15 528 484 496 484
q16 417 432 387 387
q17 588 859 361 361
q18 7685 7118 7142 7118
q19 1730 951 553 553
q20 342 336 220 220
q21 3909 2599 2382 2382
q22 1038 1021 966 966
Total cold run time: 116133 ms
Total hot run time: 33679 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5121 5054 5061 5054
q2 236 338 223 223
q3 2142 2639 2272 2272
q4 1353 1798 1345 1345
q5 4436 4350 4399 4350
q6 219 168 129 129
q7 1998 1913 1724 1724
q8 2575 2633 2547 2547
q9 7300 7159 6886 6886
q10 3029 3208 2757 2757
q11 572 494 494 494
q12 671 740 611 611
q13 3452 3900 3316 3316
q14 299 288 283 283
q15 526 500 491 491
q16 458 511 420 420
q17 1129 1446 1496 1446
q18 7812 7724 7417 7417
q19 801 829 1003 829
q20 1983 2022 1871 1871
q21 5081 4832 4675 4675
q22 1090 1054 1062 1054
Total cold run time: 52283 ms
Total hot run time: 50194 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2875232000
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2930643102
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2903780000
<details>
<summary>ClickBench: <b>Total hot run time: 29.62 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2253603deb065239177f2befdc0eac6184adfc0a, data reload: false
query1 0.04 0.04 0.03
query2 0.15 0.11 0.11
query3 0.35 0.20 0.20
query4 1.59 0.21 0.08
query5 0.42 0.41 0.41
query6 1.15 0.65 0.66
query7 0.02 0.02 0.01
query8 0.06 0.05 0.05
query9 0.64 0.51 0.54
query10 0.57 0.58 0.58
query11 0.26 0.12 0.13
query12 0.25 0.13 0.13
query13 0.64 0.61 0.62
query14 0.80 0.82 0.82
query15 0.97 0.88 0.89
query16 0.37 0.38 0.38
query17 1.08 1.07 1.04
query18 0.24 0.23 0.23
query19 1.94 1.87 1.80
query20 0.01 0.01 0.02
query21 15.39 0.96 0.66
query22 0.92 1.05 0.79
query23 14.72 1.53 0.75
query24 5.32 0.59 0.30
query25 0.16 0.09 0.09
query26 0.56 0.23 0.19
query27 0.08 0.08 0.08
query28 10.99 1.18 0.58
query29 12.53 4.09 3.49
query30 0.28 0.08 0.06
query31 2.81 0.62 0.43
query32 3.22 0.60 0.51
query33 3.18 3.07 3.08
query34 16.27 5.07 4.40
query35 4.46 4.45 4.42
query36 0.64 0.50 0.50
query37 0.21 0.17 0.17
query38 0.16 0.17 0.15
query39 0.05 0.04 0.04
query40 0.19 0.18 0.15
query41 0.11 0.05 0.05
query42 0.06 0.05 0.05
query43 0.05 0.05 0.04
Total cold run time: 103.91 s
Total hot run time: 29.62 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2903765328
<details>
<summary>TPC-DS: <b>Total hot run time: 193905 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2253603deb065239177f2befdc0eac6184adfc0a, data reload: false
query1 1432 1093 1080 1080
query2 6137 1863 1829 1829
query3 11040 4591 4612 4591
query4 54036 24543 23392 23392
query5 5138 538 457 457
query6 351 215 206 206
query7 4907 519 302 302
query8 335 264 243 243
query9 6146 2633 2634 2633
query10 407 327 295 295
query11 15073 15155 14769 14769
query12 163 111 107 107
query13 1077 536 416 416
query14 10120 6332 6453 6332
query15 209 201 181 181
query16 7131 652 509 509
query17 1093 745 583 583
query18 1703 434 311 311
query19 209 190 185 185
query20 138 132 166 132
query21 207 122 110 110
query22 4393 4504 4485 4485
query23 34659 33795 33776 33776
query24 6809 2462 2406 2406
query25 476 495 401 401
query26 707 282 155 155
query27 2456 536 339 339
query28 3295 2163 2152 2152
query29 611 570 469 469
query30 287 218 197 197
query31 885 858 774 774
query32 78 68 70 68
query33 487 357 319 319
query34 783 866 550 550
query35 825 852 740 740
query36 969 995 903 903
query37 113 106 78 78
query38 4219 4324 4270 4270
query39 1524 1459 1448 1448
query40 209 120 112 112
query41 90 53 63 53
query42 125 116 114 114
query43 513 518 486 486
query44 1353 851 843 843
query45 179 170 167 167
query46 867 1061 704 704
query47 1839 1892 1825 1825
query48 401 443 310 310
query49 745 535 451 451
query50 670 697 409 409
query51 4200 4238 4280 4238
query52 108 112 100 100
query53 228 262 200 200
query54 597 585 534 534
query55 83 84 79 79
query56 316 292 309 292
query57 1227 1138 1081 1081
query58 260 255 256 255
query59 2590 2676 2668 2668
query60 329 317 326 317
query61 127 124 123 123
query62 728 732 663 663
query63 228 184 187 184
query64 2245 1013 691 691
query65 4325 4226 4249 4226
query66 757 409 320 320
query67 16090 15677 15593 15593
query68 6648 898 533 533
query69 553 320 266 266
query70 1265 1105 1104 1104
query71 508 308 295 295
query72 6069 4852 4844 4844
query73 1408 637 354 354
query74 8938 9164 8931 8931
query75 3899 3200 2697 2697
query76 4234 1194 774 774
query77 614 373 289 289
query78 10115 10238 9454 9454
query79 2619 797 575 575
query80 603 513 450 450
query81 531 258 220 220
query82 429 131 96 96
query83 333 247 230 230
query84 289 104 94 94
query85 789 357 310 310
query86 380 283 291 283
query87 4423 4562 4305 4305
query88 3463 2288 2302 2288
query89 400 316 288 288
query90 1809 215 223 215
query91 145 144 112 112
query92 77 60 64 60
query93 1988 948 586 586
query94 656 410 294 294
query95 373 295 287 287
query96 492 578 283 283
query97 2766 2775 2697 2697
query98 227 203 200 200
query99 1413 1400 1260 1260
Total cold run time: 300513 ms
Total hot run time: 193905 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2895461058
<details>
<summary>TPC-DS: <b>Total hot run time: 193265 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 998c86669cd6ff7910477c48607d3e52d5e13408, data reload: false
query1 1395 1098 1080 1080
query2 6342 1865 1832 1832
query3 11138 4643 4660 4643
query4 25589 23951 23320 23320
query5 4369 649 471 471
query6 312 218 219 218
query7 3998 506 293 293
query8 311 248 251 248
query9 8501 2688 2674 2674
query10 450 326 283 283
query11 15298 15173 14786 14786
query12 162 115 105 105
query13 1564 559 412 412
query14 8807 6217 6255 6217
query15 217 206 176 176
query16 7276 646 490 490
query17 1192 724 638 638
query18 2045 439 324 324
query19 213 213 175 175
query20 129 127 118 118
query21 216 132 121 121
query22 4588 4535 4300 4300
query23 34646 33950 33691 33691
query24 8468 2440 2458 2440
query25 526 473 404 404
query26 1278 281 151 151
query27 3186 514 344 344
query28 4638 2177 2181 2177
query29 743 575 451 451
query30 282 222 190 190
query31 930 881 795 795
query32 79 69 64 64
query33 545 410 324 324
query34 820 867 533 533
query35 801 848 734 734
query36 983 1014 915 915
query37 115 104 79 79
query38 4298 4255 4237 4237
query39 1524 1473 1464 1464
query40 215 132 119 119
query41 65 57 54 54
query42 123 113 113 113
query43 520 529 485 485
query44 1344 832 835 832
query45 191 179 171 171
query46 899 1030 665 665
query47 1853 1868 1832 1832
query48 432 453 320 320
query49 761 556 438 438
query50 709 717 421 421
query51 4272 4324 4150 4150
query52 117 110 106 106
query53 238 268 194 194
query54 628 601 514 514
query55 87 90 91 90
query56 325 323 293 293
query57 1202 1256 1139 1139
query58 279 267 271 267
query59 2713 2805 2660 2660
query60 341 341 310 310
query61 131 133 125 125
query62 776 757 699 699
query63 231 198 226 198
query64 4729 1058 711 711
query65 4443 4353 4325 4325
query66 983 399 305 305
query67 15922 15650 15324 15324
query68 8650 893 531 531
query69 499 308 269 269
query70 1231 1229 1121 1121
query71 477 337 306 306
query72 5339 4670 4643 4643
query73 681 579 360 360
query74 9314 9018 9047 9018
query75 3813 3211 2659 2659
query76 3756 1191 767 767
query77 789 408 297 297
query78 10065 10266 9336 9336
query79 2144 823 577 577
query80 603 508 487 487
query81 492 255 230 230
query82 460 125 98 98
query83 256 272 240 240
query84 246 99 93 93
query85 840 353 308 308
query86 380 297 279 279
query87 4470 4429 4322 4322
query88 3620 2274 2296 2274
query89 406 326 280 280
query90 1787 216 204 204
query91 151 146 112 112
query92 76 63 61 61
query93 1695 961 583 583
query94 665 400 306 306
query95 378 294 294 294
query96 499 571 281 281
query97 2702 2745 2670 2670
query98 229 213 216 213
query99 1619 1391 1269 1269
Total cold run time: 280835 ms
Total hot run time: 193265 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2895474094
<details>
<summary>ClickBench: <b>Total hot run time: 29.98 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 998c86669cd6ff7910477c48607d3e52d5e13408, data reload: false
query1 0.03 0.03 0.03
query2 0.15 0.10 0.11
query3 0.34 0.20 0.20
query4 1.59 0.19 0.20
query5 0.47 0.46 0.47
query6 1.16 0.66 0.66
query7 0.02 0.02 0.02
query8 0.06 0.05 0.05
query9 0.62 0.52 0.52
query10 0.58 0.58 0.57
query11 0.26 0.13 0.12
query12 0.26 0.14 0.13
query13 0.63 0.62 0.63
query14 0.80 0.83 0.82
query15 0.96 0.88 0.89
query16 0.37 0.36 0.38
query17 1.09 1.07 1.09
query18 0.19 0.19 0.21
query19 2.05 1.84 1.86
query20 0.02 0.00 0.01
query21 15.40 0.98 0.68
query22 0.93 1.00 0.81
query23 14.70 1.55 0.77
query24 4.88 0.62 0.30
query25 0.16 0.10 0.09
query26 0.55 0.22 0.18
query27 0.08 0.08 0.08
query28 11.07 1.24 0.58
query29 12.54 4.12 3.43
query30 0.28 0.09 0.07
query31 2.85 0.66 0.43
query32 3.23 0.60 0.52
query33 3.14 3.12 3.07
query34 17.00 5.21 4.46
query35 4.51 4.53 4.55
query36 0.65 0.51 0.49
query37 0.20 0.18 0.18
query38 0.17 0.17 0.15
query39 0.05 0.05 0.04
query40 0.22 0.15 0.15
query41 0.10 0.06 0.06
query42 0.06 0.04 0.05
query43 0.05 0.05 0.04
Total cold run time: 104.47 s
Total hot run time: 29.98 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2895430698
<details>
<summary>TPC-H: <b>Total hot run time: 34143 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 998c86669cd6ff7910477c48607d3e52d5e13408, data reload: false
------ Round 1 ----------------------------------
q1 26149 5085 5155 5085
q2 2063 287 192 192
q3 10518 1354 704 704
q4 10229 1031 554 554
q5 7723 2323 2381 2323
q6 188 169 132 132
q7 937 744 635 635
q8 9331 1308 1157 1157
q9 6786 5152 5114 5114
q10 6868 2330 1891 1891
q11 500 290 276 276
q12 349 346 219 219
q13 17776 3754 3167 3167
q14 235 237 208 208
q15 526 488 493 488
q16 421 425 378 378
q17 583 850 376 376
q18 7756 7219 7161 7161
q19 1877 974 572 572
q20 322 332 216 216
q21 3799 2598 2331 2331
q22 1050 1033 964 964
Total cold run time: 115986 ms
Total hot run time: 34143 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5253 5100 5117 5100
q2 246 332 233 233
q3 2137 2666 2284 2284
q4 1392 1848 1485 1485
q5 4437 4461 4350 4350
q6 225 169 126 126
q7 1995 1905 1774 1774
q8 2616 2583 2529 2529
q9 7291 7045 7169 7045
q10 3040 3204 2786 2786
q11 588 508 500 500
q12 668 766 647 647
q13 3567 3913 3361 3361
q14 283 313 279 279
q15 511 507 484 484
q16 464 484 460 460
q17 1187 1602 1365 1365
q18 7765 7549 7374 7374
q19 822 790 860 790
q20 1999 1961 1838 1838
q21 4982 4552 4454 4454
q22 1123 1057 1056 1056
Total cold run time: 52591 ms
Total hot run time: 50320 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2942647860
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945133275
<details>
<summary>TPC-DS: <b>Total hot run time: 188534 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19, data reload: false
query1 1419 1095 1054 1054
query2 6275 1840 1822 1822
query3 8749 210 208 208
query4 54140 24244 22992 22992
query5 5008 502 456 456
query6 336 208 190 190
query7 5019 511 280 280
query8 276 221 199 199
query9 5428 2654 2674 2654
query10 468 347 260 260
query11 14907 15097 14898 14898
query12 172 111 111 111
query13 1057 519 431 431
query14 10234 6160 6418 6160
query15 235 218 183 183
query16 7220 658 508 508
query17 1087 727 581 581
query18 1723 432 325 325
query19 201 185 180 180
query20 133 128 123 123
query21 225 152 107 107
query22 5138 5333 4442 4442
query23 34268 33822 33671 33671
query24 6492 2446 2423 2423
query25 480 463 426 426
query26 711 279 152 152
query27 2246 508 357 357
query28 3130 2190 2181 2181
query29 575 563 437 437
query30 216 223 195 195
query31 874 851 762 762
query32 74 68 62 62
query33 477 371 338 338
query34 770 884 511 511
query35 788 828 760 760
query36 952 1018 919 919
query37 116 100 75 75
query38 4355 4358 4336 4336
query39 1528 1486 1462 1462
query40 169 118 107 107
query41 59 55 58 55
query42 131 105 106 105
query43 485 525 478 478
query44 1323 851 841 841
query45 186 181 174 174
query46 840 1041 637 637
query47 1860 1881 1858 1858
query48 405 429 320 320
query49 653 495 413 413
query50 680 699 411 411
query51 4281 4254 4277 4254
query52 104 106 109 106
query53 230 257 182 182
query54 590 589 511 511
query55 86 83 81 81
query56 332 300 296 296
query57 1150 1191 1129 1129
query58 276 279 253 253
query59 2660 2723 2658 2658
query60 323 332 313 313
query61 132 120 124 120
query62 783 753 677 677
query63 229 192 185 185
query64 1678 1088 694 694
query65 4283 4268 4316 4268
query66 739 402 312 312
query67 16345 15753 15514 15514
query68 7224 833 517 517
query69 556 294 271 271
query70 1257 1158 1103 1103
query71 493 324 307 307
query72 5365 4793 4948 4793
query73 1510 658 350 350
query74 8923 9244 8688 8688
query75 3792 3209 2673 2673
query76 4180 1203 761 761
query77 566 363 276 276
query78 9956 10168 9439 9439
query79 1545 803 580 580
query80 602 519 444 444
query81 464 261 223 223
query82 173 125 97 97
query83 347 254 233 233
query84 299 111 97 97
query85 744 354 319 319
query86 337 308 289 289
query87 4430 4566 4328 4328
query88 2919 2265 2246 2246
query89 375 321 283 283
query90 2046 204 201 201
query91 146 142 111 111
query92 76 59 57 57
query93 1114 925 580 580
query94 702 393 307 307
query95 367 291 284 284
query96 509 553 339 339
query97 2724 2796 2629 2629
query98 216 207 208 207
query99 1415 1390 1319 1319
Total cold run time: 293886 ms
Total hot run time: 188534 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837567075
# BE UT Coverage Report
Increment line coverage `3.92% (13/332)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/1fe74eb55e604067de350b2c01a57f79127b711e_1fe74eb55e604067de350b2c01a57f79127b711e/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/1fe74eb55e604067de350b2c01a57f79127b711e_1fe74eb55e604067de350b2c01a57f79127b711e/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.72% (14763/26977) |
| Line Coverage | 43.80% (129390/295386) |
| Region Coverage | 42.52% (66052/155349) |
| Branch Coverage | 37.11% (33314/89768) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2852304505
<details>
<summary>TPC-DS: <b>Total hot run time: 192064 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 07236b6a14c6d794c68952ce96264e4193e00838, data reload: false
query1 1407 1065 1037 1037
query2 6375 1808 1802 1802
query3 11002 4599 4544 4544
query4 25706 23792 23364 23364
query5 4243 631 462 462
query6 296 211 209 209
query7 3991 490 277 277
query8 301 270 249 249
query9 8481 2586 2578 2578
query10 489 321 273 273
query11 15469 15095 14831 14831
query12 162 114 104 104
query13 1581 500 392 392
query14 8783 6121 6021 6021
query15 203 194 165 165
query16 7282 614 483 483
query17 1176 704 583 583
query18 2002 411 322 322
query19 199 192 170 170
query20 133 132 129 129
query21 210 124 117 117
query22 4461 4574 4450 4450
query23 34834 33703 33464 33464
query24 8662 2394 2395 2394
query25 526 487 418 418
query26 809 272 157 157
query27 2898 507 337 337
query28 4641 2125 2098 2098
query29 644 585 478 478
query30 279 224 201 201
query31 891 884 792 792
query32 80 70 71 70
query33 552 377 324 324
query34 786 873 507 507
query35 807 834 762 762
query36 970 995 866 866
query37 110 101 80 80
query38 4302 4348 4231 4231
query39 1470 1429 1436 1429
query40 219 124 114 114
query41 55 54 52 52
query42 122 105 121 105
query43 497 507 479 479
query44 1300 810 813 810
query45 205 179 164 164
query46 846 1016 659 659
query47 1891 1851 1790 1790
query48 407 429 320 320
query49 721 527 439 439
query50 646 714 409 409
query51 4262 4323 4178 4178
query52 104 100 97 97
query53 221 256 181 181
query54 577 598 519 519
query55 83 83 81 81
query56 317 315 280 280
query57 1153 1229 1147 1147
query58 282 257 269 257
query59 2726 2807 2612 2612
query60 330 322 317 317
query61 131 135 131 131
query62 782 744 736 736
query63 225 187 186 186
query64 3289 1039 757 757
query65 4401 4346 4353 4346
query66 948 417 320 320
query67 16040 15518 15112 15112
query68 8442 881 505 505
query69 485 305 267 267
query70 1195 1072 1126 1072
query71 466 334 295 295
query72 5858 4689 4716 4689
query73 703 608 349 349
query74 9070 9293 8719 8719
query75 3919 3259 2656 2656
query76 3650 1192 738 738
query77 787 366 281 281
query78 9930 10070 9266 9266
query79 2320 858 578 578
query80 745 497 440 440
query81 487 257 214 214
query82 416 127 95 95
query83 291 248 234 234
query84 285 100 89 89
query85 766 357 312 312
query86 337 299 284 284
query87 4356 4488 4304 4304
query88 3195 2295 2202 2202
query89 391 320 290 290
query90 1820 211 216 211
query91 143 143 112 112
query92 77 61 55 55
query93 1728 1013 577 577
query94 650 418 298 298
query95 368 300 282 282
query96 483 567 274 274
query97 3156 3203 3104 3104
query98 230 208 214 208
query99 1425 1401 1296 1296
Total cold run time: 278167 ms
Total hot run time: 192064 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2852425715
# BE UT Coverage Report
Increment line coverage `3.23% (13/402)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/07236b6a14c6d794c68952ce96264e4193e00838_07236b6a14c6d794c68952ce96264e4193e00838/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/07236b6a14c6d794c68952ce96264e4193e00838_07236b6a14c6d794c68952ce96264e4193e00838/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.08% (14920/27087) |
| Line Coverage | 44.18% (131143/296815) |
| Region Coverage | 42.83% (66834/156059) |
| Branch Coverage | 37.41% (33701/90088) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2908006743
<details>
<summary>TPC-DS: <b>Total hot run time: 192421 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9dfcc92756376ccf764ec9b3ce62f40a5c6f3540, data reload: false
query1 1437 1091 1066 1066
query2 6266 1881 1924 1881
query3 10966 4575 4290 4290
query4 53779 25888 23111 23111
query5 5231 545 489 489
query6 368 227 201 201
query7 4993 524 287 287
query8 329 263 240 240
query9 6189 2649 2618 2618
query10 407 330 271 271
query11 15101 15563 14800 14800
query12 162 114 105 105
query13 1102 517 415 415
query14 10138 6205 6216 6205
query15 204 193 172 172
query16 7079 618 483 483
query17 1083 726 578 578
query18 1540 404 304 304
query19 201 195 168 168
query20 132 136 120 120
query21 203 135 111 111
query22 4297 4509 4394 4394
query23 34403 33524 33505 33505
query24 6510 2427 2429 2427
query25 458 492 402 402
query26 702 287 153 153
query27 2189 497 349 349
query28 3074 2184 2153 2153
query29 586 570 429 429
query30 272 225 205 205
query31 858 877 773 773
query32 74 57 64 57
query33 446 366 325 325
query34 782 876 537 537
query35 842 841 770 770
query36 1007 1029 920 920
query37 119 105 78 78
query38 4216 4209 4141 4141
query39 1719 1490 1449 1449
query40 222 123 114 114
query41 65 53 53 53
query42 126 113 117 113
query43 502 535 477 477
query44 1355 851 852 851
query45 176 173 168 168
query46 849 1044 644 644
query47 1837 1872 1778 1778
query48 398 425 318 318
query49 704 533 472 472
query50 691 726 415 415
query51 4222 4310 4211 4211
query52 114 118 108 108
query53 241 267 192 192
query54 609 600 542 542
query55 98 86 82 82
query56 334 327 330 327
query57 1217 1156 1148 1148
query58 263 263 255 255
query59 2871 2810 2659 2659
query60 346 332 326 326
query61 129 131 130 130
query62 749 755 648 648
query63 226 192 192 192
query64 1497 1057 677 677
query65 4348 4203 4248 4203
query66 742 402 303 303
query67 15702 15569 15640 15569
query68 6958 870 519 519
query69 549 308 277 277
query70 1224 1131 1094 1094
query71 470 308 311 308
query72 6007 4903 5040 4903
query73 1181 704 362 362
query74 8869 9156 8735 8735
query75 3666 3202 2725 2725
query76 4017 1206 757 757
query77 600 386 314 314
query78 10078 10120 9380 9380
query79 2237 812 580 580
query80 612 590 450 450
query81 487 254 214 214
query82 448 129 95 95
query83 321 245 244 244
query84 296 111 86 86
query85 792 357 313 313
query86 379 296 277 277
query87 4288 4435 4251 4251
query88 3388 2299 2283 2283
query89 427 339 285 285
query90 1761 211 215 211
query91 140 141 113 113
query92 72 64 61 61
query93 1901 976 590 590
query94 702 435 308 308
query95 367 308 291 291
query96 493 574 276 276
query97 2744 2755 2667 2667
query98 233 201 209 201
query99 1425 1406 1294 1294
Total cold run time: 297229 ms
Total hot run time: 192421 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2908000748
<details>
<summary>TPC-H: <b>Total hot run time: 33756 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9dfcc92756376ccf764ec9b3ce62f40a5c6f3540, data reload: false
------ Round 1 ----------------------------------
q1 26348 5050 5019 5019
q2 2094 280 197 197
q3 10505 1240 699 699
q4 10230 983 526 526
q5 7681 2399 2330 2330
q6 180 161 135 135
q7 955 747 613 613
q8 9312 1334 1107 1107
q9 6791 5074 5129 5074
q10 6852 2314 1897 1897
q11 506 325 276 276
q12 352 352 208 208
q13 17778 3663 3097 3097
q14 234 240 220 220
q15 517 488 494 488
q16 425 434 376 376
q17 601 854 368 368
q18 7575 7106 7092 7092
q19 2096 1007 568 568
q20 329 325 220 220
q21 3908 2507 2306 2306
q22 1047 1026 940 940
Total cold run time: 116316 ms
Total hot run time: 33756 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5237 5088 5276 5088
q2 242 322 233 233
q3 2137 2695 2282 2282
q4 1364 1781 1360 1360
q5 4484 4424 4410 4410
q6 208 171 126 126
q7 1988 1957 1791 1791
q8 2575 2612 2627 2612
q9 7265 7225 6954 6954
q10 3038 3229 2757 2757
q11 586 515 516 515
q12 700 767 650 650
q13 3525 3885 3285 3285
q14 294 301 260 260
q15 504 473 477 473
q16 429 474 450 450
q17 1164 1582 1377 1377
q18 7779 7696 7434 7434
q19 779 783 810 783
q20 1974 1990 1823 1823
q21 4846 4570 4530 4530
q22 1133 1035 1030 1030
Total cold run time: 52251 ms
Total hot run time: 50223 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2910212774
<details>
<summary>ClickBench: <b>Total hot run time: 28.96 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cfefcb593357db219db76f3389ca8974c0b938a0, data reload: false
query1 0.04 0.03 0.04
query2 0.11 0.11 0.11
query3 0.24 0.20 0.19
query4 1.61 0.20 0.20
query5 0.42 0.41 0.40
query6 1.17 0.65 0.67
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.58 0.51 0.54
query10 0.56 0.58 0.57
query11 0.15 0.11 0.11
query12 0.15 0.12 0.12
query13 0.61 0.61 0.59
query14 0.79 0.80 0.80
query15 0.88 0.88 0.85
query16 0.37 0.39 0.38
query17 1.06 1.01 1.06
query18 0.23 0.21 0.21
query19 1.91 1.83 1.81
query20 0.01 0.01 0.02
query21 15.41 0.93 0.55
query22 0.76 1.16 0.64
query23 14.99 1.40 0.65
query24 6.90 1.74 0.71
query25 0.47 0.12 0.12
query26 0.58 0.17 0.15
query27 0.05 0.04 0.05
query28 9.68 0.94 0.44
query29 12.56 4.06 3.32
query30 0.27 0.10 0.07
query31 2.84 0.60 0.38
query32 3.23 0.55 0.47
query33 3.05 3.03 3.13
query34 15.65 5.06 4.50
query35 4.49 4.54 4.50
query36 0.66 0.51 0.47
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.14 0.13
query41 0.07 0.04 0.03
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.01 s
Total hot run time: 28.96 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2834197990
TeamCity cloud ut coverage result:
Function Coverage: 83.06% (1098/1322)
Line Coverage: 65.89% (18388/27909)
Region Coverage: 65.29% (9110/13954)
Branch Coverage: 55.24% (4900/8870)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7a772c870025b13d35a08d10543510c94f52d3bf_7a772c870025b13d35a08d10543510c94f52d3bf_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2834022450
# BE UT Coverage Report
Increment line coverage `4.58% (13/284)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/52a7949fc04539b6896be4dc0a35c46db90b026a_52a7949fc04539b6896be4dc0a35c46db90b026a/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/52a7949fc04539b6896be4dc0a35c46db90b026a_52a7949fc04539b6896be4dc0a35c46db90b026a/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.44% (14766/27122) |
| Line Coverage | 43.52% (129207/296900) |
| Region Coverage | 42.22% (65988/156296) |
| Branch Coverage | 36.75% (33245/90470) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2839863117
# BE UT Coverage Report
Increment line coverage `4.06% (13/320)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5f3e3aced5506200223e0aefe96dcb784aafd819_5f3e3aced5506200223e0aefe96dcb784aafd819/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5f3e3aced5506200223e0aefe96dcb784aafd819_5f3e3aced5506200223e0aefe96dcb784aafd819/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.87% (14798/26968) |
| Line Coverage | 43.97% (129830/295303) |
| Region Coverage | 42.67% (66274/155332) |
| Branch Coverage | 37.27% (33457/89760) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2850869894
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2857056263
# BE Regression && UT Coverage Report
Increment line coverage `85.82% (345/402)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_07236b6a14c6d794c68952ce96264e4193e00838_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_07236b6a14c6d794c68952ce96264e4193e00838_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 81.02% (21273/26257) |
| Line Coverage | 74.94% (220091/293696) |
| Region Coverage | 73.24% (132435/180819) |
| Branch Coverage | 66.59% (67628/101564) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2943468308
<details>
<summary>TPC-H: <b>Total hot run time: 34120 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fc3e4adc9036c348a83a0cad346689ccb7096b46, data reload: false
------ Round 1 ----------------------------------
q1 26914 5014 5009 5009
q2 1981 304 189 189
q3 10350 1276 726 726
q4 10242 1026 540 540
q5 7632 2361 2358 2358
q6 187 167 135 135
q7 904 766 624 624
q8 9312 1296 1130 1130
q9 6826 5211 5104 5104
q10 6888 2336 1910 1910
q11 478 306 311 306
q12 349 355 231 231
q13 17786 3696 3088 3088
q14 239 239 219 219
q15 570 474 487 474
q16 442 436 380 380
q17 629 861 382 382
q18 8057 7177 7201 7177
q19 1821 980 563 563
q20 343 342 224 224
q21 3843 3171 2372 2372
q22 1030 1009 979 979
Total cold run time: 116823 ms
Total hot run time: 34120 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5163 5096 5083 5083
q2 236 330 220 220
q3 2160 2661 2352 2352
q4 1309 1804 1440 1440
q5 4564 4449 4401 4401
q6 211 161 135 135
q7 2052 1904 1740 1740
q8 2743 2672 2568 2568
q9 7257 7259 7162 7162
q10 3015 3219 2782 2782
q11 586 508 489 489
q12 683 793 606 606
q13 3519 3922 3449 3449
q14 300 301 288 288
q15 544 507 491 491
q16 467 501 438 438
q17 1181 1572 1390 1390
q18 7795 7412 7420 7412
q19 855 840 924 840
q20 1996 2014 1901 1901
q21 4839 4490 4374 4374
q22 1089 1073 1038 1038
Total cold run time: 52564 ms
Total hot run time: 50599 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2943086604
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/fc3e4adc9036c348a83a0cad346689ccb7096b46_fc3e4adc9036c348a83a0cad346689ccb7096b46_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/fc3e4adc9036c348a83a0cad346689ccb7096b46_fc3e4adc9036c348a83a0cad346689ccb7096b46_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.32% (1119/1343) |
| Line Coverage | 66.77% (19184/28732) |
| Region Coverage | 66.47% (9506/14302) |
| Branch Coverage | 56.37% (5150/9136) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2910119893
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2910181375
<details>
<summary>TPC-H: <b>Total hot run time: 33768 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cfefcb593357db219db76f3389ca8974c0b938a0, data reload: false
------ Round 1 ----------------------------------
q1 26051 5013 4966 4966
q2 2072 276 184 184
q3 10392 1249 720 720
q4 10238 1018 525 525
q5 7554 2360 2336 2336
q6 180 162 136 136
q7 899 756 613 613
q8 9311 1242 1096 1096
q9 7062 5115 5047 5047
q10 6830 2329 1907 1907
q11 485 281 270 270
q12 333 354 222 222
q13 17773 3679 3088 3088
q14 228 225 216 216
q15 535 486 484 484
q16 435 431 374 374
q17 578 860 361 361
q18 7620 7350 7143 7143
q19 1212 938 558 558
q20 336 340 229 229
q21 3870 2587 2325 2325
q22 1066 1011 968 968
Total cold run time: 115060 ms
Total hot run time: 33768 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5104 5031 5042 5031
q2 237 333 227 227
q3 2184 2675 2281 2281
q4 1336 1771 1345 1345
q5 4438 4475 4425 4425
q6 231 172 132 132
q7 1982 1935 1755 1755
q8 2560 2534 2479 2479
q9 7152 7176 7156 7156
q10 3038 3143 2774 2774
q11 565 499 494 494
q12 679 778 657 657
q13 3601 3921 3233 3233
q14 289 312 294 294
q15 511 485 467 467
q16 437 490 429 429
q17 1130 1491 1398 1398
q18 7613 7434 7285 7285
q19 823 814 863 814
q20 1988 1985 1895 1895
q21 4881 4401 4300 4300
q22 1093 1019 989 989
Total cold run time: 51872 ms
Total hot run time: 49860 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945013222
# FE UT Coverage Report
Increment line coverage ` 47.06% (24/51)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945100490
<details>
<summary>TPC-H: <b>Total hot run time: 33678 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19, data reload: false
------ Round 1 ----------------------------------
q1 26115 5084 5031 5031
q2 1958 271 175 175
q3 10420 1231 708 708
q4 10236 977 515 515
q5 7672 2401 2308 2308
q6 186 167 131 131
q7 917 729 601 601
q8 9319 1287 1077 1077
q9 6709 5083 5068 5068
q10 6865 2313 1888 1888
q11 472 290 279 279
q12 351 348 209 209
q13 17768 3713 3096 3096
q14 237 239 223 223
q15 559 484 483 483
q16 432 436 377 377
q17 612 852 371 371
q18 7697 7213 7035 7035
q19 1853 981 572 572
q20 340 329 223 223
q21 3662 2596 2328 2328
q22 1064 1027 980 980
Total cold run time: 115444 ms
Total hot run time: 33678 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5199 5115 5108 5108
q2 244 316 222 222
q3 2188 2670 2326 2326
q4 1338 1754 1347 1347
q5 4424 4381 4386 4381
q6 226 168 128 128
q7 1984 1916 1798 1798
q8 2579 2644 2511 2511
q9 6955 6808 6746 6746
q10 2928 3105 2662 2662
q11 569 497 486 486
q12 641 746 571 571
q13 3352 3692 3134 3134
q14 265 287 269 269
q15 519 463 474 463
q16 434 467 433 433
q17 1127 1534 1319 1319
q18 7332 7403 7593 7403
q19 791 833 929 833
q20 1958 2092 1968 1968
q21 4917 4549 4434 4434
q22 1147 1051 1019 1019
Total cold run time: 51117 ms
Total hot run time: 49561 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945295598
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2875267488
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/f75ee7ab79d79a9234b6f57fbb1812e137a1d560_f75ee7ab79d79a9234b6f57fbb1812e137a1d560_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/f75ee7ab79d79a9234b6f57fbb1812e137a1d560_f75ee7ab79d79a9234b6f57fbb1812e137a1d560_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.20% (1104/1327) |
| Line Coverage | 66.12% (18603/28136) |
| Region Coverage | 65.68% (9260/14098) |
| Branch Coverage | 55.40% (4976/8982) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2864078504
<details>
<summary>TPC-DS: <b>Total hot run time: 184987 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e3ab06d3022d325590a75717a047bb43aad698c9, data reload: false
query1 1050 472 491 472
query2 6559 1788 1810 1788
query3 6748 222 217 217
query4 26151 23769 22954 22954
query5 4348 611 506 506
query6 291 198 191 191
query7 4622 484 273 273
query8 286 234 224 224
query9 8608 2520 2542 2520
query10 468 319 267 267
query11 15382 15014 14783 14783
query12 161 109 105 105
query13 1659 543 384 384
query14 8737 6301 6157 6157
query15 204 195 165 165
query16 7147 624 460 460
query17 1164 742 578 578
query18 1967 411 300 300
query19 194 189 161 161
query20 121 121 116 116
query21 216 136 105 105
query22 3993 4338 4061 4061
query23 33885 33040 32891 32891
query24 8463 2472 2395 2395
query25 551 441 375 375
query26 1235 272 159 159
query27 2741 490 327 327
query28 4324 2073 2049 2049
query29 794 542 468 468
query30 283 211 183 183
query31 924 882 741 741
query32 73 65 68 65
query33 550 365 295 295
query34 823 837 525 525
query35 766 822 742 742
query36 954 962 894 894
query37 108 101 77 77
query38 4214 4178 4124 4124
query39 1448 1398 1388 1388
query40 212 121 107 107
query41 57 58 52 52
query42 118 112 106 106
query43 501 504 467 467
query44 1252 782 776 776
query45 177 176 170 170
query46 825 1007 619 619
query47 1778 1789 1724 1724
query48 374 410 317 317
query49 785 485 422 422
query50 658 690 406 406
query51 3995 4119 4087 4087
query52 113 107 98 98
query53 225 258 179 179
query54 594 566 495 495
query55 83 79 83 79
query56 297 327 303 303
query57 1141 1147 1078 1078
query58 261 256 249 249
query59 2612 2670 2466 2466
query60 327 313 301 301
query61 131 122 123 122
query62 796 727 676 676
query63 229 181 184 181
query64 4372 995 696 696
query65 4316 4239 4227 4227
query66 1168 438 314 314
query67 15566 15471 15366 15366
query68 8626 920 517 517
query69 465 300 267 267
query70 1204 1113 1085 1085
query71 456 316 280 280
query72 5767 4836 4712 4712
query73 756 683 350 350
query74 9173 9060 8745 8745
query75 3884 3166 2651 2651
query76 3695 1198 759 759
query77 780 408 284 284
query78 10060 9876 9307 9307
query79 4767 822 541 541
query80 712 527 449 449
query81 478 255 220 220
query82 636 132 96 96
query83 280 255 237 237
query84 301 110 91 91
query85 801 353 313 313
query86 395 307 290 290
query87 4526 4468 4282 4282
query88 3505 2192 2275 2192
query89 446 318 285 285
query90 1846 217 219 217
query91 154 143 113 113
query92 69 62 60 60
query93 3395 934 576 576
query94 670 407 312 312
query95 381 297 302 297
query96 488 593 282 282
query97 3183 3206 3111 3111
query98 257 206 214 206
query99 1441 1410 1292 1292
Total cold run time: 278772 ms
Total hot run time: 184987 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2898179164
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2899667854
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/52fa5c5962bbc72ffa38580cf8a1050eb0367689_52fa5c5962bbc72ffa38580cf8a1050eb0367689_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/52fa5c5962bbc72ffa38580cf8a1050eb0367689_52fa5c5962bbc72ffa38580cf8a1050eb0367689_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.17% (18675/28223) |
| Region Coverage | 65.79% (9261/14077) |
| Branch Coverage | 55.63% (4987/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2901819070
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2833805757
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2834545297
<details>
<summary>ClickBench: <b>Total hot run time: 29.92 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7a772c870025b13d35a08d10543510c94f52d3bf, data reload: false
query1 0.04 0.03 0.03
query2 0.15 0.10 0.10
query3 0.34 0.20 0.20
query4 1.60 0.21 0.19
query5 0.63 0.60 0.61
query6 1.19 0.72 0.73
query7 0.02 0.01 0.01
query8 0.05 0.05 0.05
query9 0.62 0.52 0.53
query10 0.59 0.59 0.58
query11 0.26 0.12 0.12
query12 0.25 0.13 0.14
query13 0.64 0.63 0.62
query14 0.80 0.83 0.82
query15 0.95 0.88 0.87
query16 0.38 0.37 0.38
query17 1.05 1.00 1.04
query18 0.20 0.18 0.18
query19 1.92 1.81 1.83
query20 0.02 0.01 0.02
query21 15.40 0.96 0.68
query22 0.93 1.01 0.82
query23 14.68 1.58 0.76
query24 5.53 0.54 0.29
query25 0.16 0.09 0.08
query26 0.56 0.21 0.18
query27 0.08 0.08 0.09
query28 11.04 1.15 0.57
query29 12.53 4.05 3.41
query30 0.28 0.08 0.07
query31 2.82 0.63 0.42
query32 3.23 0.58 0.50
query33 3.08 3.07 3.09
query34 16.45 5.10 4.44
query35 4.46 4.50 4.47
query36 0.65 0.50 0.49
query37 0.19 0.16 0.16
query38 0.17 0.17 0.17
query39 0.05 0.04 0.05
query40 0.19 0.17 0.15
query41 0.11 0.05 0.05
query42 0.05 0.05 0.05
query43 0.05 0.05 0.04
Total cold run time: 104.39 s
Total hot run time: 29.92 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2833930912
<details>
<summary>ClickBench: <b>Total hot run time: 29.1 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 52a7949fc04539b6896be4dc0a35c46db90b026a, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.10
query3 0.26 0.20 0.19
query4 1.59 0.20 0.11
query5 0.56 0.56 0.54
query6 1.21 0.71 0.73
query7 0.02 0.02 0.01
query8 0.04 0.04 0.04
query9 0.58 0.52 0.52
query10 0.57 0.58 0.57
query11 0.15 0.11 0.11
query12 0.15 0.12 0.11
query13 0.61 0.59 0.59
query14 1.21 1.22 1.21
query15 0.88 0.85 0.84
query16 0.37 0.38 0.39
query17 1.00 1.02 1.04
query18 0.22 0.20 0.19
query19 1.92 1.79 1.84
query20 0.01 0.01 0.01
query21 15.39 0.94 0.55
query22 0.75 1.18 0.62
query23 14.98 1.38 0.60
query24 7.10 1.37 0.49
query25 0.49 0.35 0.06
query26 0.53 0.17 0.15
query27 0.05 0.06 0.05
query28 9.59 0.87 0.43
query29 12.54 4.03 3.34
query30 0.25 0.10 0.07
query31 2.82 0.59 0.38
query32 3.23 0.55 0.47
query33 3.12 3.01 3.02
query34 15.72 5.13 4.51
query35 4.54 4.50 4.52
query36 0.66 0.50 0.48
query37 0.09 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.14 0.13
query41 0.08 0.02 0.02
query42 0.04 0.02 0.03
query43 0.04 0.03 0.03
Total cold run time: 103.77 s
Total hot run time: 29.1 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2828278927
<details>
<summary>TPC-H: <b>Total hot run time: 34089 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5650a1d1a11b09aa9f804cf810d60aec61718c1f, data reload: false
------ Round 1 ----------------------------------
q1 25956 5101 5010 5010
q2 2066 274 188 188
q3 10409 1225 708 708
q4 10233 1004 529 529
q5 7550 3006 2391 2391
q6 185 161 130 130
q7 907 740 604 604
q8 9327 1369 1177 1177
q9 6843 5119 5181 5119
q10 6805 2285 1900 1900
q11 477 280 277 277
q12 347 360 227 227
q13 17760 3636 3065 3065
q14 220 228 210 210
q15 534 488 470 470
q16 443 450 396 396
q17 599 872 364 364
q18 8034 7113 7196 7113
q19 1215 941 538 538
q20 333 330 222 222
q21 4296 2579 2476 2476
q22 1066 1037 975 975
Total cold run time: 115605 ms
Total hot run time: 34089 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5118 5124 5117 5117
q2 239 331 227 227
q3 2175 2651 2287 2287
q4 1395 1794 1353 1353
q5 4548 4435 4412 4412
q6 213 164 124 124
q7 1960 1863 1738 1738
q8 2576 2467 2512 2467
q9 7164 7088 7148 7088
q10 3020 3166 2747 2747
q11 594 499 479 479
q12 717 781 588 588
q13 3494 3951 3345 3345
q14 294 293 265 265
q15 525 479 474 474
q16 467 483 445 445
q17 1188 1551 1397 1397
q18 7734 7428 7269 7269
q19 814 816 801 801
q20 1965 2007 1937 1937
q21 5202 4733 4594 4594
q22 1054 1049 1010 1010
Total cold run time: 52456 ms
Total hot run time: 50164 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2828562540
# BE UT Coverage Report
Increment line coverage `4.55% (13/286)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5650a1d1a11b09aa9f804cf810d60aec61718c1f_5650a1d1a11b09aa9f804cf810d60aec61718c1f/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5650a1d1a11b09aa9f804cf810d60aec61718c1f_5650a1d1a11b09aa9f804cf810d60aec61718c1f/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.82% (14621/27166) |
| Line Coverage | 42.61% (126881/297768) |
| Region Coverage | 41.41% (64870/156641) |
| Branch Coverage | 35.96% (32613/90692) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2840226051
# BE Regression P0 && UT Coverage Report
Increment line coverage `20.00% (64/320)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_5f3e3aced5506200223e0aefe96dcb784aafd819_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_5f3e3aced5506200223e0aefe96dcb784aafd819_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.13% (20681/26471) |
| Line Coverage | 71.75% (211521/294817) |
| Region Coverage | 69.82% (126920/181791) |
| Branch Coverage | 63.15% (64626/102344) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2851435897
# BE UT Coverage Report
Increment line coverage `3.23% (13/402)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/aa941a4bdc89d862da03848b2752576437517703_aa941a4bdc89d862da03848b2752576437517703/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/aa941a4bdc89d862da03848b2752576437517703_aa941a4bdc89d862da03848b2752576437517703/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.07% (14918/27087) |
| Line Coverage | 44.18% (131109/296769) |
| Region Coverage | 42.85% (66810/155921) |
| Branch Coverage | 37.41% (33693/90076) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2853376149
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2854243243
<details>
<summary>TPC-H: <b>Total hot run time: 34255 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07236b6a14c6d794c68952ce96264e4193e00838, data reload: false
------ Round 1 ----------------------------------
q1 26199 5182 5001 5001
q2 2081 278 177 177
q3 10457 1267 759 759
q4 10240 1065 524 524
q5 7541 2417 2422 2417
q6 179 160 134 134
q7 939 786 616 616
q8 9325 1298 1128 1128
q9 6830 5059 5079 5059
q10 6822 2281 1901 1901
q11 496 283 266 266
q12 354 354 214 214
q13 17756 3711 3151 3151
q14 234 234 205 205
q15 526 491 483 483
q16 424 443 378 378
q17 631 870 375 375
q18 7810 7108 7148 7108
q19 1835 963 584 584
q20 348 344 217 217
q21 4592 3867 2602 2602
q22 1036 1034 956 956
Total cold run time: 116655 ms
Total hot run time: 34255 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5202 5085 5082 5082
q2 241 341 227 227
q3 2182 2642 2340 2340
q4 1403 1907 1568 1568
q5 4571 4460 4387 4387
q6 219 166 129 129
q7 2019 1893 1762 1762
q8 2638 2657 2619 2619
q9 7272 7123 7191 7123
q10 3021 3189 2753 2753
q11 569 515 499 499
q12 669 764 608 608
q13 3562 3904 3257 3257
q14 280 304 268 268
q15 522 478 485 478
q16 452 502 446 446
q17 1170 1620 1351 1351
q18 7726 7698 7496 7496
q19 841 907 1044 907
q20 2011 1966 1815 1815
q21 5159 4621 4557 4557
q22 1034 1007 975 975
Total cold run time: 52763 ms
Total hot run time: 50647 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2909075751
<details>
<summary>TPC-H: <b>Total hot run time: 33901 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 67fcd97f506f6be6cafcc187cf92c8e99aadadb2, data reload: false
------ Round 1 ----------------------------------
q1 26261 4999 4974 4974
q2 2086 276 190 190
q3 10503 1244 709 709
q4 10231 985 516 516
q5 7660 2374 2355 2355
q6 188 174 135 135
q7 928 736 598 598
q8 9308 1288 1082 1082
q9 6782 5092 5026 5026
q10 6819 2345 1904 1904
q11 478 285 268 268
q12 338 356 214 214
q13 17770 3697 3109 3109
q14 231 233 221 221
q15 533 481 490 481
q16 435 432 381 381
q17 585 873 374 374
q18 7540 7251 7133 7133
q19 1901 986 559 559
q20 345 323 227 227
q21 3797 2561 2470 2470
q22 1066 1018 975 975
Total cold run time: 115785 ms
Total hot run time: 33901 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5170 5070 5088 5070
q2 241 323 232 232
q3 2179 2675 2265 2265
q4 1325 1814 1328 1328
q5 4501 4414 4403 4403
q6 228 179 130 130
q7 2018 1932 1776 1776
q8 2578 2909 2547 2547
q9 7222 7175 6871 6871
q10 3040 3222 2774 2774
q11 579 505 496 496
q12 684 760 629 629
q13 3512 3873 3296 3296
q14 286 288 273 273
q15 546 499 508 499
q16 449 499 460 460
q17 1169 1510 1387 1387
q18 7793 7608 7413 7413
q19 793 795 869 795
q20 1967 2059 1859 1859
q21 4735 4484 4441 4441
q22 1065 1055 1025 1025
Total cold run time: 52080 ms
Total hot run time: 49969 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2903673860
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2908009162
<details>
<summary>ClickBench: <b>Total hot run time: 29.92 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9dfcc92756376ccf764ec9b3ce62f40a5c6f3540, data reload: false
query1 0.03 0.03 0.03
query2 0.15 0.10 0.10
query3 0.35 0.20 0.20
query4 1.58 0.19 0.19
query5 0.47 0.45 0.46
query6 1.17 0.67 0.65
query7 0.03 0.02 0.01
query8 0.06 0.05 0.05
query9 0.62 0.51 0.51
query10 0.58 0.58 0.56
query11 0.26 0.12 0.13
query12 0.25 0.13 0.14
query13 0.65 0.64 0.63
query14 0.80 0.82 0.83
query15 0.97 0.89 0.88
query16 0.36 0.36 0.37
query17 1.06 1.06 1.05
query18 0.19 0.22 0.18
query19 1.99 1.87 1.89
query20 0.02 0.01 0.01
query21 15.40 0.97 0.68
query22 0.96 1.06 0.90
query23 15.11 1.54 0.76
query24 5.48 0.55 0.28
query25 0.16 0.10 0.08
query26 0.55 0.22 0.18
query27 0.09 0.09 0.08
query28 11.03 1.21 0.59
query29 12.58 4.03 3.45
query30 0.28 0.09 0.06
query31 2.80 0.63 0.43
query32 3.24 0.60 0.51
query33 3.04 3.10 3.19
query34 16.75 5.17 4.42
query35 4.47 4.45 4.44
query36 0.63 0.51 0.49
query37 0.19 0.17 0.17
query38 0.18 0.15 0.16
query39 0.06 0.05 0.05
query40 0.19 0.16 0.16
query41 0.12 0.05 0.05
query42 0.06 0.04 0.05
query43 0.06 0.05 0.05
Total cold run time: 105.02 s
Total hot run time: 29.92 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2901807462
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945710347
# BE UT Coverage Report
Increment line coverage `14.44% (39/270)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5d3d0109fc32ee4e564be68bd5c289a755438b30_5d3d0109fc32ee4e564be68bd5c289a755438b30/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5d3d0109fc32ee4e564be68bd5c289a755438b30_5d3d0109fc32ee4e564be68bd5c289a755438b30/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 56.30% (15094/26810) |
| Line Coverage | 45.10% (134678/298640) |
| Region Coverage | 44.20% (67733/153239) |
| Branch Coverage | 38.76% (34715/89562) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2940664271
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/fdf333a26acbd27a5a03160a1a472c72d8684d46_fdf333a26acbd27a5a03160a1a472c72d8684d46_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/fdf333a26acbd27a5a03160a1a472c72d8684d46_fdf333a26acbd27a5a03160a1a472c72d8684d46_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.32% (1119/1343) |
| Line Coverage | 66.80% (19192/28732) |
| Region Coverage | 66.44% (9502/14302) |
| Branch Coverage | 56.43% (5155/9136) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2943038091
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2944564880
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19_2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19_2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.32% (1119/1343) |
| Line Coverage | 66.81% (19195/28732) |
| Region Coverage | 66.47% (9507/14302) |
| Branch Coverage | 56.41% (5154/9136) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2921982873
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/3a662dc35fb3163b0aebab385d2348d8bb2b64d7_3a662dc35fb3163b0aebab385d2348d8bb2b64d7_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/3a662dc35fb3163b0aebab385d2348d8bb2b64d7_3a662dc35fb3163b0aebab385d2348d8bb2b64d7_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1118/1342) |
| Line Coverage | 66.79% (19145/28663) |
| Region Coverage | 66.38% (9467/14261) |
| Branch Coverage | 56.37% (5133/9106) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837268489
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2827273567
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2828168874
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2834148381
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837302695
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2854543812
# BE UT Coverage Report
Increment line coverage `3.23% (13/402)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/07236b6a14c6d794c68952ce96264e4193e00838_07236b6a14c6d794c68952ce96264e4193e00838/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/07236b6a14c6d794c68952ce96264e4193e00838_07236b6a14c6d794c68952ce96264e4193e00838/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.56% (14869/26761) |
| Line Coverage | 44.56% (131094/294215) |
| Region Coverage | 43.29% (66794/154285) |
| Branch Coverage | 37.90% (33713/88948) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2850960544
TeamCity cloud ut coverage result:
Function Coverage: 83.08% (1100/1324)
Line Coverage: 65.93% (18421/27940)
Region Coverage: 65.39% (9133/13967)
Branch Coverage: 55.24% (4903/8876)
Coverage Report: http://coverage.selectdb-in.cc/coverage/aa941a4bdc89d862da03848b2752576437517703_aa941a4bdc89d862da03848b2752576437517703_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on code in PR #50379:
URL: https://github.com/apache/doris/pull/50379#discussion_r2080873385
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -649,11 +577,10 @@ Status CsvReader::_fill_dest_columns(const Slice& line, Block* block,
for (int i = 0; i < _file_slot_descs.size(); ++i) {
int col_idx = _col_idxs[i];
- // col idx is out of range, fill with null.
- const Slice& value = col_idx < _split_values.size()
- ? _split_values[col_idx]
- : Slice {_options.null_format, _options.null_len};
- Slice slice {value.data, value.size};
+ // col idx is out of range, fill with null format
+ auto value = col_idx < _split_values.size()
+ ? _split_values[col_idx]
+ : Slice(_options.null_format, _options.null_len);
Review Comment:
In the process of doris load csv, "\\N" is hard-coded as a null value, but there is no null value in the opencsv format of hive, and empty strings are used to fill non-existent columns. When reading the hive csv table here, null_format will be an empty string, and null_len will be 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on code in PR #50379:
URL: https://github.com/apache/doris/pull/50379#discussion_r2080873651
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -395,14 +328,10 @@ Status CsvReader::init_reader(bool is_load) {
if (_enclose == 0) {
text_line_reader_ctx = std::make_shared<PlainTextLineReaderCtx>(
_line_delimiter, _line_delimiter_length, _keep_cr);
- if (_text_serde_type == TTextSerdeType::HIVE_TEXT_SERDE) {
- _fields_splitter = std::make_unique<HiveCsvTextFieldSplitter>(
- _trim_tailing_spaces, false, _value_separator, _value_separator_length, -1,
- _escape);
- } else {
- _fields_splitter = std::make_unique<PlainCsvTextFieldSplitter>(
- _trim_tailing_spaces, false, _value_separator, _value_separator_length, -1);
- }
+ // TODO: make sure what table this splitter is used for
Review Comment:
Just forget to rm this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2839398893
TeamCity cloud ut coverage result:
Function Coverage: 83.08% (1100/1324)
Line Coverage: 65.90% (18404/27928)
Region Coverage: 65.38% (9129/13964)
Branch Coverage: 55.23% (4901/8874)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5f3e3aced5506200223e0aefe96dcb784aafd819_5f3e3aced5506200223e0aefe96dcb784aafd819_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2890893316
# BE UT Coverage Report
Increment line coverage `11.74% (52/443)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/40558b979dafd05eeaca2d7be50b035491eb3d18_40558b979dafd05eeaca2d7be50b035491eb3d18/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/40558b979dafd05eeaca2d7be50b035491eb3d18_40558b979dafd05eeaca2d7be50b035491eb3d18/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.94% (14931/26691) |
| Line Coverage | 44.76% (132492/296038) |
| Region Coverage | 43.85% (66675/152052) |
| Branch Coverage | 38.45% (34174/88872) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2903026846
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2899642989
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2908798979
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2907935265
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/9dfcc92756376ccf764ec9b3ce62f40a5c6f3540_9dfcc92756376ccf764ec9b3ce62f40a5c6f3540_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/9dfcc92756376ccf764ec9b3ce62f40a5c6f3540_9dfcc92756376ccf764ec9b3ce62f40a5c6f3540_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.19% (18681/28224) |
| Region Coverage | 65.89% (9276/14079) |
| Branch Coverage | 55.63% (4988/8966) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2908848110
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/67fcd97f506f6be6cafcc187cf92c8e99aadadb2_67fcd97f506f6be6cafcc187cf92c8e99aadadb2_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/67fcd97f506f6be6cafcc187cf92c8e99aadadb2_67fcd97f506f6be6cafcc187cf92c8e99aadadb2_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.16% (18673/28224) |
| Region Coverage | 65.84% (9269/14079) |
| Branch Coverage | 55.58% (4983/8966) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2942856644
<details>
<summary>TPC-H: <b>Total hot run time: 34060 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0587de7ce408c6cdb9b6a233bb918066405641ad, data reload: false
------ Round 1 ----------------------------------
q1 26438 5143 4986 4986
q2 1974 294 206 206
q3 10374 1259 716 716
q4 10246 1008 546 546
q5 7791 2345 2343 2343
q6 178 166 133 133
q7 914 748 598 598
q8 9310 1300 1103 1103
q9 6811 5184 5098 5098
q10 6867 2321 1920 1920
q11 498 293 270 270
q12 346 352 229 229
q13 17815 3693 3077 3077
q14 226 226 224 224
q15 554 491 491 491
q16 436 438 368 368
q17 607 866 366 366
q18 7766 7253 7149 7149
q19 1660 972 557 557
q20 343 342 228 228
q21 4059 3155 2450 2450
q22 1086 1030 1002 1002
Total cold run time: 116299 ms
Total hot run time: 34060 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5208 5122 5093 5093
q2 243 321 219 219
q3 2128 2622 2313 2313
q4 1341 1825 1444 1444
q5 4582 4439 4374 4374
q6 214 167 128 128
q7 1989 1970 1798 1798
q8 2548 2624 2562 2562
q9 7074 7219 7211 7211
q10 3004 3224 2784 2784
q11 581 525 494 494
q12 694 749 627 627
q13 3468 3925 3264 3264
q14 285 288 276 276
q15 515 464 475 464
q16 445 475 443 443
q17 1147 1556 1379 1379
q18 7768 7489 7579 7489
q19 827 926 988 926
q20 1974 2018 1884 1884
q21 4862 4255 4294 4255
q22 1073 1029 974 974
Total cold run time: 51970 ms
Total hot run time: 50401 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2895087710
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945147582
<details>
<summary>ClickBench: <b>Total hot run time: 29.74 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2c9c389c6bb477c3d66dea7cc5f7a19bb7fc9c19, data reload: false
query1 0.04 0.04 0.03
query2 0.15 0.11 0.10
query3 0.35 0.20 0.20
query4 1.61 0.20 0.08
query5 0.43 0.41 0.43
query6 1.15 0.65 0.67
query7 0.03 0.02 0.02
query8 0.06 0.05 0.04
query9 0.63 0.52 0.51
query10 0.59 0.60 0.59
query11 0.26 0.12 0.13
query12 0.26 0.13 0.14
query13 0.63 0.61 0.62
query14 0.81 0.82 0.82
query15 0.97 0.88 0.89
query16 0.36 0.38 0.37
query17 1.07 1.03 1.06
query18 0.19 0.18 0.17
query19 2.01 1.82 1.92
query20 0.02 0.01 0.02
query21 15.41 0.98 0.67
query22 0.92 1.06 0.82
query23 14.69 1.59 0.76
query24 5.24 0.61 0.30
query25 0.17 0.09 0.08
query26 0.56 0.22 0.18
query27 0.08 0.08 0.09
query28 11.07 1.17 0.59
query29 12.60 4.17 3.46
query30 0.29 0.09 0.06
query31 2.81 0.63 0.43
query32 3.24 0.60 0.52
query33 3.03 3.08 3.16
query34 16.95 5.10 4.45
query35 4.59 4.52 4.51
query36 0.64 0.50 0.49
query37 0.20 0.18 0.16
query38 0.17 0.15 0.16
query39 0.05 0.04 0.04
query40 0.19 0.16 0.16
query41 0.12 0.05 0.05
query42 0.06 0.06 0.06
query43 0.06 0.05 0.05
Total cold run time: 104.76 s
Total hot run time: 29.74 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2946007035
# BE Regression && UT Coverage Report
Increment line coverage `88.10% (237/269)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_5d3d0109fc32ee4e564be68bd5c289a755438b30_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_5d3d0109fc32ee4e564be68bd5c289a755438b30_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.57% (20999/26390) |
| Line Coverage | 72.64% (216853/298536) |
| Region Coverage | 70.87% (127721/180212) |
| Branch Coverage | 64.61% (66150/102388) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2864285786
# BE UT Coverage Report
Increment line coverage `5.53% (23/416)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e3ab06d3022d325590a75717a047bb43aad698c9_e3ab06d3022d325590a75717a047bb43aad698c9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e3ab06d3022d325590a75717a047bb43aad698c9_e3ab06d3022d325590a75717a047bb43aad698c9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.73% (14919/26770) |
| Line Coverage | 44.50% (131539/295584) |
| Region Coverage | 43.41% (66285/152707) |
| Branch Coverage | 38.09% (33854/88882) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2864052912
<details>
<summary>TPC-H: <b>Total hot run time: 34277 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e3ab06d3022d325590a75717a047bb43aad698c9, data reload: false
------ Round 1 ----------------------------------
q1 26234 5071 5206 5071
q2 2091 280 201 201
q3 10614 1263 718 718
q4 10243 1022 550 550
q5 7896 2440 2377 2377
q6 184 167 135 135
q7 937 778 632 632
q8 9335 1415 1163 1163
q9 6831 5090 5118 5090
q10 6804 2324 1929 1929
q11 485 286 268 268
q12 358 362 223 223
q13 17760 3723 3103 3103
q14 252 234 212 212
q15 525 482 482 482
q16 441 445 373 373
q17 615 872 377 377
q18 7739 7322 7024 7024
q19 1795 974 584 584
q20 338 347 215 215
q21 4357 3607 2569 2569
q22 1067 1032 981 981
Total cold run time: 116901 ms
Total hot run time: 34277 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5229 5133 5129 5129
q2 237 323 237 237
q3 2195 2690 2283 2283
q4 1355 1995 1525 1525
q5 4569 4454 4391 4391
q6 213 170 131 131
q7 1957 1971 1758 1758
q8 2634 2648 2506 2506
q9 7054 7131 7110 7110
q10 3075 3199 2722 2722
q11 571 509 511 509
q12 684 771 631 631
q13 3627 3877 3319 3319
q14 298 296 278 278
q15 515 475 486 475
q16 444 481 450 450
q17 1188 1726 1419 1419
q18 7760 7492 7431 7431
q19 873 811 935 811
q20 2017 2038 1878 1878
q21 5152 4796 4584 4584
q22 1081 1037 977 977
Total cold run time: 52728 ms
Total hot run time: 50554 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2863815922
TeamCity cloud ut coverage result:
Function Coverage: 83.18% (1103/1326)
Line Coverage: 66.08% (18557/28084)
Region Coverage: 65.66% (9240/14073)
Branch Coverage: 55.42% (4966/8960)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e3ab06d3022d325590a75717a047bb43aad698c9_e3ab06d3022d325590a75717a047bb43aad698c9_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2864089341
<details>
<summary>ClickBench: <b>Total hot run time: 29.5 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e3ab06d3022d325590a75717a047bb43aad698c9, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.11 0.11
query3 0.26 0.19 0.19
query4 1.60 0.19 0.19
query5 0.61 0.58 0.59
query6 1.19 0.72 0.72
query7 0.03 0.01 0.02
query8 0.05 0.03 0.04
query9 0.58 0.52 0.52
query10 0.56 0.58 0.58
query11 0.16 0.11 0.11
query12 0.15 0.11 0.12
query13 0.61 0.61 0.60
query14 0.78 0.80 0.81
query15 0.88 0.84 0.86
query16 0.37 0.38 0.40
query17 1.02 1.03 1.04
query18 0.22 0.20 0.20
query19 1.92 1.77 1.84
query20 0.01 0.02 0.01
query21 15.39 0.92 0.56
query22 0.75 1.29 0.98
query23 14.72 1.40 0.66
query24 7.22 1.59 0.89
query25 0.51 0.12 0.06
query26 0.63 0.17 0.13
query27 0.05 0.05 0.05
query28 9.64 0.83 0.42
query29 12.55 3.95 3.26
query30 0.25 0.09 0.06
query31 2.82 0.58 0.38
query32 3.23 0.54 0.47
query33 2.97 2.99 3.05
query34 15.81 5.13 4.47
query35 4.50 4.55 4.51
query36 0.65 0.49 0.48
query37 0.09 0.06 0.07
query38 0.05 0.04 0.04
query39 0.03 0.02 0.03
query40 0.16 0.13 0.13
query41 0.09 0.02 0.02
query42 0.03 0.02 0.03
query43 0.03 0.03 0.03
Total cold run time: 103.33 s
Total hot run time: 29.5 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2856907291
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #50379:
URL: https://github.com/apache/doris/pull/50379#discussion_r2077063514
##########
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.cpp:
##########
@@ -149,11 +149,22 @@ void EncloseCsvLineReaderContext::_on_pre_match_enclose(const uint8_t* start, si
_should_escape = !_should_escape;
} else if (_should_escape) [[unlikely]] {
_should_escape = false;
- } else if (start[_idx] == _enclose) [[unlikely]] {
- _state.forward_to(ReaderState::MATCH_ENCLOSE);
- ++_idx;
- return;
+ } else if (_quote_escape) {
Review Comment:
Consider adding a comment clarifying the intended control flow when _quote_escape is true, especially regarding whether _idx should be incremented after forwarding the state.
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -615,18 +544,17 @@ Status CsvReader::_create_decompressor() {
return Status::OK();
}
-template <bool from_json>
Status CsvReader::deserialize_nullable_string(IColumn& column, Slice& slice) {
auto& null_column = assert_cast<ColumnNullable&>(column);
Review Comment:
Please add a comment to explain the change in condition for null handling, clarifying why the null_len check is now used instead of the previous from_json parameter.
```suggestion
auto& null_column = assert_cast<ColumnNullable&>(column);
// Check if the slice matches the null format. The `_options.null_len` is used to determine
// whether a null format is defined, replacing the previous `from_json` parameter. This approach
// ensures compatibility with the current implementation, where null handling depends on the
// length of the null format and whether the slice has been converted from a string.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2877176943
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ce0d08255e5ac9042d3c5272d45360605f1ea8d5_ce0d08255e5ac9042d3c5272d45360605f1ea8d5_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ce0d08255e5ac9042d3c5272d45360605f1ea8d5_ce0d08255e5ac9042d3c5272d45360605f1ea8d5_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.15% (1105/1329) |
| Line Coverage | 66.05% (18610/28175) |
| Region Coverage | 65.59% (9259/14117) |
| Branch Coverage | 55.40% (4987/9002) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2875284252
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2833913974
<details>
<summary>TPC-H: <b>Total hot run time: 34204 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 52a7949fc04539b6896be4dc0a35c46db90b026a, data reload: false
------ Round 1 ----------------------------------
q1 26328 5065 5027 5027
q2 2088 277 198 198
q3 10572 1258 719 719
q4 10245 1001 539 539
q5 7880 2400 2367 2367
q6 192 164 132 132
q7 933 749 606 606
q8 9336 1287 1140 1140
q9 6995 5127 5220 5127
q10 6840 2327 1896 1896
q11 475 293 275 275
q12 352 358 221 221
q13 17787 3685 3113 3113
q14 226 225 208 208
q15 536 494 507 494
q16 459 449 404 404
q17 607 887 359 359
q18 7904 7164 7180 7164
q19 1591 971 585 585
q20 334 342 223 223
q21 3941 3357 2446 2446
q22 1044 1025 961 961
Total cold run time: 116665 ms
Total hot run time: 34204 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5159 5090 5096 5090
q2 236 324 222 222
q3 2167 2656 2318 2318
q4 1360 1816 1451 1451
q5 4586 4404 4283 4283
q6 212 167 123 123
q7 1994 1914 1746 1746
q8 2630 2605 2482 2482
q9 7273 7277 7178 7178
q10 3004 3227 2733 2733
q11 567 494 495 494
q12 675 787 608 608
q13 3427 3902 3260 3260
q14 288 292 261 261
q15 532 484 472 472
q16 458 504 468 468
q17 1172 1552 1447 1447
q18 7626 7520 7554 7520
q19 827 832 981 832
q20 1971 2029 1879 1879
q21 5032 4692 4489 4489
q22 1082 1023 987 987
Total cold run time: 52278 ms
Total hot run time: 50343 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837740089
TeamCity cloud ut coverage result:
Function Coverage: 83.08% (1100/1324)
Line Coverage: 65.86% (18393/27928)
Region Coverage: 65.30% (9119/13964)
Branch Coverage: 55.23% (4901/8874)
Coverage Report: http://coverage.selectdb-in.cc/coverage/de50d882580d5dbe9a4e0d1c2a701e9c9f262b53_de50d882580d5dbe9a4e0d1c2a701e9c9f262b53_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2851232839
<details>
<summary>TPC-DS: <b>Total hot run time: 192835 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aa941a4bdc89d862da03848b2752576437517703, data reload: false
query1 1432 1086 1072 1072
query2 6138 1815 1841 1815
query3 11140 4802 4830 4802
query4 24787 23444 23036 23036
query5 3895 651 471 471
query6 319 214 210 210
query7 3996 488 290 290
query8 314 260 241 241
query9 8448 2582 2601 2582
query10 469 327 262 262
query11 15252 15079 14935 14935
query12 173 113 107 107
query13 1568 530 399 399
query14 9583 6305 6248 6248
query15 208 209 167 167
query16 7662 634 444 444
query17 1308 724 639 639
query18 2034 420 329 329
query19 202 197 170 170
query20 131 122 123 122
query21 212 131 116 116
query22 4474 4399 4335 4335
query23 34652 33376 33732 33376
query24 8358 2485 2483 2483
query25 519 476 409 409
query26 1230 280 150 150
query27 2833 501 341 341
query28 4699 2106 2105 2105
query29 683 584 452 452
query30 280 221 190 190
query31 919 872 813 813
query32 75 64 64 64
query33 555 381 343 343
query34 804 881 545 545
query35 827 825 757 757
query36 978 985 890 890
query37 114 105 74 74
query38 4205 4342 4215 4215
query39 1504 1448 1418 1418
query40 217 119 101 101
query41 55 50 50 50
query42 120 105 118 105
query43 517 503 471 471
query44 1361 819 813 813
query45 176 173 167 167
query46 869 1041 657 657
query47 1782 1858 1809 1809
query48 397 415 317 317
query49 739 508 447 447
query50 686 728 413 413
query51 4218 4286 4236 4236
query52 118 108 99 99
query53 228 269 192 192
query54 592 597 519 519
query55 86 87 89 87
query56 300 310 294 294
query57 1197 1195 1100 1100
query58 275 261 262 261
query59 2761 2877 2733 2733
query60 348 327 341 327
query61 131 125 125 125
query62 760 752 702 702
query63 241 186 187 186
query64 4110 1030 698 698
query65 4466 4388 4362 4362
query66 1075 421 317 317
query67 16124 15560 15424 15424
query68 8285 902 518 518
query69 476 316 267 267
query70 1185 1078 1042 1042
query71 470 317 294 294
query72 5709 4807 4842 4807
query73 720 649 351 351
query74 9232 9049 8629 8629
query75 3847 3173 2676 2676
query76 3693 1209 759 759
query77 778 376 288 288
query78 10030 10107 9372 9372
query79 2493 814 582 582
query80 697 610 445 445
query81 492 251 215 215
query82 458 129 95 95
query83 250 258 239 239
query84 243 123 87 87
query85 799 351 311 311
query86 383 295 290 290
query87 4535 4399 4252 4252
query88 3836 2213 2177 2177
query89 410 326 285 285
query90 1940 209 212 209
query91 137 137 110 110
query92 78 59 57 57
query93 2076 988 577 577
query94 659 414 309 309
query95 376 300 284 284
query96 491 563 275 275
query97 3162 3216 3126 3126
query98 227 218 204 204
query99 1413 1373 1274 1274
Total cold run time: 280509 ms
Total hot run time: 192835 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2851248771
<details>
<summary>ClickBench: <b>Total hot run time: 30.1 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aa941a4bdc89d862da03848b2752576437517703, data reload: false
query1 0.04 0.04 0.03
query2 0.15 0.10 0.12
query3 0.34 0.20 0.20
query4 1.58 0.20 0.22
query5 0.62 0.60 0.62
query6 1.18 0.71 0.72
query7 0.03 0.02 0.02
query8 0.05 0.05 0.05
query9 0.62 0.53 0.53
query10 0.59 0.58 0.60
query11 0.26 0.13 0.13
query12 0.25 0.13 0.14
query13 0.63 0.63 0.62
query14 0.79 0.80 0.83
query15 0.98 0.88 0.89
query16 0.37 0.37 0.37
query17 1.05 1.06 1.04
query18 0.18 0.17 0.18
query19 1.97 1.84 1.87
query20 0.01 0.02 0.01
query21 15.41 0.98 0.67
query22 0.92 1.03 0.82
query23 14.70 1.62 0.76
query24 5.50 0.60 0.28
query25 0.17 0.09 0.09
query26 0.56 0.21 0.18
query27 0.09 0.09 0.08
query28 11.01 1.20 0.58
query29 12.53 4.02 3.41
query30 0.29 0.10 0.07
query31 2.84 0.65 0.44
query32 3.23 0.59 0.51
query33 3.14 3.11 3.09
query34 16.68 5.11 4.44
query35 4.53 4.50 4.50
query36 0.64 0.51 0.50
query37 0.21 0.18 0.18
query38 0.18 0.15 0.16
query39 0.05 0.04 0.05
query40 0.21 0.16 0.16
query41 0.11 0.06 0.05
query42 0.06 0.05 0.05
query43 0.05 0.06 0.04
Total cold run time: 104.8 s
Total hot run time: 30.1 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945657870
# FE UT Coverage Report
Increment line coverage ` 47.06% (24/51)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_5d3d0109fc32ee4e564be68bd5c289a755438b30/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_5d3d0109fc32ee4e564be68bd5c289a755438b30/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2943526434
<details>
<summary>ClickBench: <b>Total hot run time: 29.76 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fc3e4adc9036c348a83a0cad346689ccb7096b46, data reload: false
query1 0.04 0.03 0.03
query2 0.16 0.11 0.10
query3 0.35 0.20 0.19
query4 1.61 0.22 0.09
query5 0.43 0.41 0.41
query6 1.16 0.66 0.68
query7 0.02 0.02 0.02
query8 0.06 0.05 0.05
query9 0.63 0.52 0.53
query10 0.59 0.58 0.58
query11 0.28 0.13 0.14
query12 0.26 0.13 0.14
query13 0.64 0.62 0.62
query14 0.83 0.82 0.82
query15 0.98 0.90 0.88
query16 0.37 0.38 0.38
query17 1.10 1.05 1.05
query18 0.20 0.18 0.17
query19 2.00 1.83 1.93
query20 0.02 0.02 0.02
query21 15.40 0.97 0.67
query22 0.93 1.06 0.86
query23 14.66 1.53 0.77
query24 5.43 0.58 0.29
query25 0.16 0.09 0.09
query26 0.56 0.24 0.18
query27 0.08 0.08 0.08
query28 11.04 1.22 0.61
query29 12.53 4.09 3.44
query30 0.29 0.08 0.06
query31 2.84 0.62 0.43
query32 3.25 0.61 0.50
query33 3.16 3.15 3.09
query34 16.60 5.12 4.41
query35 4.50 4.48 4.44
query36 0.63 0.52 0.50
query37 0.20 0.17 0.18
query38 0.17 0.16 0.15
query39 0.05 0.04 0.04
query40 0.21 0.16 0.15
query41 0.11 0.05 0.05
query42 0.06 0.05 0.05
query43 0.06 0.05 0.05
Total cold run time: 104.65 s
Total hot run time: 29.76 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2942810969
# FE UT Coverage Report
Increment line coverage ` 47.06% (24/51)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_0587de7ce408c6cdb9b6a233bb918066405641ad/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_0587de7ce408c6cdb9b6a233bb918066405641ad/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2947797212
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2942668074
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0587de7ce408c6cdb9b6a233bb918066405641ad_0587de7ce408c6cdb9b6a233bb918066405641ad_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0587de7ce408c6cdb9b6a233bb918066405641ad_0587de7ce408c6cdb9b6a233bb918066405641ad_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.32% (1119/1343) |
| Line Coverage | 66.76% (19182/28732) |
| Region Coverage | 66.46% (9505/14302) |
| Branch Coverage | 56.38% (5151/9136) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945338901
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5d3d0109fc32ee4e564be68bd5c289a755438b30_5d3d0109fc32ee4e564be68bd5c289a755438b30_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5d3d0109fc32ee4e564be68bd5c289a755438b30_5d3d0109fc32ee4e564be68bd5c289a755438b30_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.32% (1119/1343) |
| Line Coverage | 66.80% (19194/28732) |
| Region Coverage | 66.44% (9502/14302) |
| Branch Coverage | 56.43% (5155/9136) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2852024034
TeamCity cloud ut coverage result:
Function Coverage: 83.08% (1100/1324)
Line Coverage: 65.88% (18406/27940)
Region Coverage: 65.30% (9120/13967)
Branch Coverage: 55.25% (4904/8876)
Coverage Report: http://coverage.selectdb-in.cc/coverage/07236b6a14c6d794c68952ce96264e4193e00838_07236b6a14c6d794c68952ce96264e4193e00838_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2853972703
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2909112915
<details>
<summary>TPC-DS: <b>Total hot run time: 192352 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 67fcd97f506f6be6cafcc187cf92c8e99aadadb2, data reload: false
query1 1419 1146 1032 1032
query2 6360 1872 1864 1864
query3 11048 4428 4758 4428
query4 25735 24012 22994 22994
query5 4373 610 437 437
query6 299 207 197 197
query7 4002 498 286 286
query8 316 237 229 229
query9 8502 2593 2606 2593
query10 475 330 253 253
query11 15349 15160 14847 14847
query12 167 110 114 110
query13 1565 568 405 405
query14 8350 6221 6257 6221
query15 210 186 172 172
query16 7177 650 496 496
query17 1220 734 554 554
query18 1960 414 301 301
query19 194 189 168 168
query20 124 126 126 126
query21 215 127 113 113
query22 4433 4503 4279 4279
query23 34943 34050 33556 33556
query24 8631 2419 2445 2419
query25 530 465 393 393
query26 1246 305 154 154
query27 2818 503 337 337
query28 4810 2186 2146 2146
query29 721 573 436 436
query30 268 219 190 190
query31 911 900 790 790
query32 102 65 66 65
query33 554 373 315 315
query34 819 894 522 522
query35 842 835 761 761
query36 997 1006 890 890
query37 112 98 77 77
query38 4296 4298 4272 4272
query39 1511 1447 1439 1439
query40 218 123 108 108
query41 56 52 54 52
query42 116 106 106 106
query43 522 527 484 484
query44 1322 834 834 834
query45 183 180 174 174
query46 848 1027 647 647
query47 1900 1866 1757 1757
query48 399 422 334 334
query49 745 533 439 439
query50 680 717 426 426
query51 4219 4249 4225 4225
query52 112 113 101 101
query53 235 265 194 194
query54 612 595 520 520
query55 82 84 82 82
query56 306 300 311 300
query57 1196 1225 1132 1132
query58 283 278 280 278
query59 2730 2913 2671 2671
query60 370 358 338 338
query61 156 149 147 147
query62 774 752 684 684
query63 231 196 200 196
query64 4254 1070 696 696
query65 4420 4292 4462 4292
query66 1030 399 305 305
query67 15874 15583 15589 15583
query68 8467 897 519 519
query69 479 304 266 266
query70 1209 1113 1113 1113
query71 474 306 302 302
query72 5768 4792 5181 4792
query73 757 672 358 358
query74 8890 9202 8686 8686
query75 3826 3181 2667 2667
query76 3698 1181 767 767
query77 797 378 276 276
query78 10146 10257 9407 9407
query79 2158 818 583 583
query80 589 497 456 456
query81 483 269 218 218
query82 475 136 96 96
query83 254 249 233 233
query84 248 117 168 117
query85 809 364 316 316
query86 381 299 304 299
query87 4434 4510 4329 4329
query88 3710 2311 2317 2311
query89 416 319 287 287
query90 1807 221 225 221
query91 144 144 111 111
query92 74 58 58 58
query93 1690 970 581 581
query94 678 415 301 301
query95 374 292 289 289
query96 488 567 282 282
query97 2695 2785 2679 2679
query98 231 206 200 200
query99 1421 1407 1260 1260
Total cold run time: 279547 ms
Total hot run time: 192352 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2852316698
<details>
<summary>ClickBench: <b>Total hot run time: 29.62 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 07236b6a14c6d794c68952ce96264e4193e00838, data reload: false
query1 0.04 0.04 0.03
query2 0.15 0.11 0.10
query3 0.35 0.20 0.20
query4 1.60 0.20 0.08
query5 0.55 0.55 0.55
query6 1.19 0.73 0.72
query7 0.02 0.02 0.02
query8 0.06 0.05 0.06
query9 0.62 0.53 0.52
query10 0.59 0.57 0.56
query11 0.25 0.12 0.12
query12 0.25 0.13 0.13
query13 0.63 0.63 0.63
query14 0.80 0.82 0.81
query15 0.96 0.89 0.87
query16 0.38 0.37 0.38
query17 1.04 1.04 1.04
query18 0.18 0.19 0.18
query19 1.94 1.79 1.80
query20 0.02 0.02 0.01
query21 15.42 0.95 0.66
query22 0.93 1.01 0.78
query23 14.72 1.48 0.75
query24 5.30 0.57 0.31
query25 0.17 0.08 0.08
query26 0.56 0.22 0.19
query27 0.08 0.09 0.08
query28 11.05 1.19 0.57
query29 12.54 4.02 3.35
query30 0.27 0.08 0.07
query31 2.81 0.63 0.42
query32 3.27 0.59 0.50
query33 3.08 3.02 3.16
query34 16.94 5.10 4.41
query35 4.51 4.49 4.48
query36 0.64 0.50 0.50
query37 0.18 0.17 0.17
query38 0.18 0.17 0.16
query39 0.06 0.04 0.04
query40 0.20 0.16 0.15
query41 0.10 0.05 0.05
query42 0.06 0.06 0.06
query43 0.06 0.05 0.04
Total cold run time: 104.75 s
Total hot run time: 29.62 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2834738773
# BE UT Coverage Report
Increment line coverage `4.58% (13/284)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7a772c870025b13d35a08d10543510c94f52d3bf_7a772c870025b13d35a08d10543510c94f52d3bf/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7a772c870025b13d35a08d10543510c94f52d3bf_7a772c870025b13d35a08d10543510c94f52d3bf/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.73% (14763/26976) |
| Line Coverage | 43.79% (129282/295248) |
| Region Coverage | 42.52% (66008/155249) |
| Branch Coverage | 37.09% (33263/89686) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2835177850
# BE Regression P0 && UT Coverage Report
Increment line coverage `18.31% (52/284)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_7a772c870025b13d35a08d10543510c94f52d3bf_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_7a772c870025b13d35a08d10543510c94f52d3bf_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.02% (20660/26480) |
| Line Coverage | 71.57% (210965/294764) |
| Region Coverage | 69.76% (126774/181718) |
| Branch Coverage | 63.01% (64440/102268) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837712658
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2854035383
TeamCity cloud ut coverage result:
Function Coverage: 83.08% (1100/1324)
Line Coverage: 65.88% (18408/27940)
Region Coverage: 65.42% (9137/13967)
Branch Coverage: 55.36% (4914/8876)
Coverage Report: http://coverage.selectdb-in.cc/coverage/07236b6a14c6d794c68952ce96264e4193e00838_07236b6a14c6d794c68952ce96264e4193e00838_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2941038064
<details>
<summary>TPC-DS: <b>Total hot run time: 193077 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fdf333a26acbd27a5a03160a1a472c72d8684d46, data reload: false
query1 1432 1089 1062 1062
query2 6154 1844 1815 1815
query3 11021 4547 4517 4517
query4 54067 24316 23439 23439
query5 5106 549 470 470
query6 348 211 216 211
query7 4903 510 289 289
query8 291 239 219 219
query9 5408 2652 2639 2639
query10 442 368 308 308
query11 15124 15079 14979 14979
query12 165 112 105 105
query13 1045 540 411 411
query14 10195 6368 6414 6368
query15 203 200 181 181
query16 7141 625 506 506
query17 1103 745 633 633
query18 1586 409 324 324
query19 203 209 189 189
query20 134 133 124 124
query21 207 128 113 113
query22 4373 4349 4293 4293
query23 34500 33480 33641 33480
query24 6639 2418 2424 2418
query25 463 490 431 431
query26 696 281 154 154
query27 2341 504 350 350
query28 3009 2205 2180 2180
query29 583 569 428 428
query30 289 229 189 189
query31 898 848 764 764
query32 73 67 66 66
query33 482 367 306 306
query34 786 876 529 529
query35 807 847 757 757
query36 957 1019 920 920
query37 115 103 76 76
query38 4331 4360 4262 4262
query39 1528 1608 1461 1461
query40 222 129 117 117
query41 64 58 59 58
query42 136 124 121 121
query43 519 515 480 480
query44 1349 858 871 858
query45 186 182 167 167
query46 851 1116 642 642
query47 1839 1924 1790 1790
query48 419 436 321 321
query49 664 526 396 396
query50 667 697 404 404
query51 4245 4317 4232 4232
query52 114 115 110 110
query53 228 266 185 185
query54 602 585 527 527
query55 89 83 87 83
query56 306 304 296 296
query57 1157 1202 1117 1117
query58 274 271 258 258
query59 2704 2801 2628 2628
query60 335 316 308 308
query61 156 124 148 124
query62 715 702 648 648
query63 221 184 188 184
query64 1856 1032 680 680
query65 4231 4153 4137 4137
query66 755 398 302 302
query67 15842 15639 15534 15534
query68 6948 897 532 532
query69 533 320 263 263
query70 1187 1137 1052 1052
query71 520 322 290 290
query72 6020 4968 5058 4968
query73 1435 705 349 349
query74 9036 9301 8828 8828
query75 3851 3239 2670 2670
query76 4175 1208 737 737
query77 643 355 281 281
query78 10189 10365 9295 9295
query79 2197 808 586 586
query80 590 521 448 448
query81 508 275 220 220
query82 253 124 92 92
query83 251 248 241 241
query84 295 111 90 90
query85 794 369 328 328
query86 366 331 267 267
query87 4516 4392 4298 4298
query88 4002 2311 2362 2311
query89 396 316 285 285
query90 1807 201 205 201
query91 160 162 116 116
query92 73 64 58 58
query93 1812 937 578 578
query94 650 413 301 301
query95 370 294 276 276
query96 509 571 283 283
query97 2741 2752 2659 2659
query98 237 205 210 205
query99 1322 1437 1296 1296
Total cold run time: 298280 ms
Total hot run time: 193077 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2945376615
<details>
<summary>TPC-H: <b>Total hot run time: 33865 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5d3d0109fc32ee4e564be68bd5c289a755438b30, data reload: false
------ Round 1 ----------------------------------
q1 26134 5106 5090 5090
q2 1960 285 177 177
q3 10281 1262 712 712
q4 10213 1010 524 524
q5 7557 2357 2361 2357
q6 200 164 133 133
q7 900 756 611 611
q8 9303 1260 1039 1039
q9 6932 5096 5166 5096
q10 6834 2338 1912 1912
q11 489 294 278 278
q12 358 357 223 223
q13 17758 3757 3063 3063
q14 221 227 212 212
q15 546 490 511 490
q16 442 429 371 371
q17 603 874 372 372
q18 7521 7249 7009 7009
q19 1089 962 585 585
q20 353 353 230 230
q21 3810 3185 2394 2394
q22 1054 1031 987 987
Total cold run time: 114558 ms
Total hot run time: 33865 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5175 5085 5189 5085
q2 240 316 220 220
q3 2183 2638 2324 2324
q4 1350 1784 1341 1341
q5 4540 4379 4415 4379
q6 219 173 128 128
q7 1979 1869 1755 1755
q8 2593 2793 2642 2642
q9 7186 7103 7135 7103
q10 2981 3189 2814 2814
q11 582 505 488 488
q12 707 765 624 624
q13 3498 3928 3287 3287
q14 275 294 273 273
q15 534 474 468 468
q16 430 486 459 459
q17 1168 1461 1374 1374
q18 7784 7516 7459 7459
q19 869 886 901 886
q20 2000 2009 1873 1873
q21 4980 4460 4349 4349
q22 1075 1025 997 997
Total cold run time: 52348 ms
Total hot run time: 50328 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2835868411
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837302435
TeamCity cloud ut coverage result:
Function Coverage: 83.08% (1100/1324)
Line Coverage: 65.88% (18400/27928)
Region Coverage: 65.37% (9128/13964)
Branch Coverage: 55.25% (4903/8874)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1fe74eb55e604067de350b2c01a57f79127b711e_1fe74eb55e604067de350b2c01a57f79127b711e_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2900515636
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2899818660
<details>
<summary>TPC-DS: <b>Total hot run time: 193360 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 52fa5c5962bbc72ffa38580cf8a1050eb0367689, data reload: false
query1 1423 1100 1098 1098
query2 6154 1819 1820 1819
query3 11006 4425 4477 4425
query4 53596 24450 23106 23106
query5 5280 500 460 460
query6 349 200 206 200
query7 4949 511 301 301
query8 323 258 242 242
query9 6166 2711 2710 2710
query10 431 328 306 306
query11 15848 15006 14850 14850
query12 167 112 104 104
query13 1080 546 455 455
query14 10216 6551 6438 6438
query15 208 198 190 190
query16 7143 636 496 496
query17 1125 773 607 607
query18 1605 423 327 327
query19 207 208 181 181
query20 135 123 133 123
query21 207 137 123 123
query22 4431 4443 4347 4347
query23 34183 33540 33585 33540
query24 6806 2447 2500 2447
query25 469 454 425 425
query26 692 278 156 156
query27 2365 507 342 342
query28 2929 2198 2189 2189
query29 583 566 446 446
query30 280 224 191 191
query31 849 833 817 817
query32 80 65 64 64
query33 452 362 309 309
query34 776 848 551 551
query35 789 849 765 765
query36 956 1010 896 896
query37 116 108 86 86
query38 4351 4306 4316 4306
query39 1536 1466 1446 1446
query40 207 124 110 110
query41 57 54 55 54
query42 129 119 106 106
query43 520 531 503 503
query44 1383 852 871 852
query45 186 177 172 172
query46 874 1030 678 678
query47 1826 1855 1841 1841
query48 435 432 331 331
query49 712 526 445 445
query50 658 712 429 429
query51 4265 4342 4237 4237
query52 113 112 109 109
query53 241 267 188 188
query54 593 584 524 524
query55 87 84 84 84
query56 319 304 321 304
query57 1193 1234 1095 1095
query58 276 270 270 270
query59 2838 2796 2793 2793
query60 342 353 333 333
query61 123 120 145 120
query62 747 739 719 719
query63 228 191 198 191
query64 1479 1012 684 684
query65 4331 4236 4192 4192
query66 722 393 310 310
query67 15724 15564 15314 15314
query68 7091 876 533 533
query69 548 311 279 279
query70 1162 1135 1136 1135
query71 497 301 292 292
query72 5803 4837 4965 4837
query73 1346 658 373 373
query74 9290 9170 8757 8757
query75 3771 3174 2686 2686
query76 4241 1276 800 800
query77 623 379 283 283
query78 10069 10029 9285 9285
query79 5737 830 567 567
query80 653 519 435 435
query81 498 264 217 217
query82 652 130 102 102
query83 347 246 236 236
query84 292 118 87 87
query85 795 386 301 301
query86 409 302 281 281
query87 4425 4458 4413 4413
query88 3904 2343 2322 2322
query89 450 328 279 279
query90 1790 211 213 211
query91 145 145 112 112
query92 73 61 55 55
query93 3438 942 577 577
query94 660 422 305 305
query95 375 299 294 294
query96 508 588 287 287
query97 2709 2708 2656 2656
query98 235 226 212 212
query99 1439 1409 1279 1279
Total cold run time: 304844 ms
Total hot run time: 193360 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2900873726
<details>
<summary>TPC-DS: <b>Total hot run time: 186371 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ca6fb29f8dc2beada465a1b27159efede6177ffc, data reload: false
query1 980 483 504 483
query2 6560 1893 1850 1850
query3 6740 220 218 218
query4 26783 23850 22984 22984
query5 4333 634 463 463
query6 292 204 188 188
query7 4619 515 287 287
query8 276 257 223 223
query9 8564 2644 2630 2630
query10 505 346 259 259
query11 15195 15060 14896 14896
query12 165 112 106 106
query13 1659 533 422 422
query14 8722 6377 6353 6353
query15 213 186 174 174
query16 7138 669 479 479
query17 947 733 592 592
query18 1985 404 307 307
query19 196 198 175 175
query20 119 123 120 120
query21 211 124 109 109
query22 4103 4200 4041 4041
query23 34189 33197 32995 32995
query24 8288 2415 2413 2413
query25 570 478 423 423
query26 1230 281 159 159
query27 2717 508 344 344
query28 4331 2172 2147 2147
query29 853 568 438 438
query30 285 210 183 183
query31 921 870 757 757
query32 76 63 62 62
query33 558 373 319 319
query34 802 862 522 522
query35 782 829 739 739
query36 944 1055 874 874
query37 112 103 74 74
query38 4002 4135 4098 4098
query39 1467 1410 1429 1410
query40 215 129 109 109
query41 57 59 54 54
query42 124 106 115 106
query43 503 522 485 485
query44 1353 840 833 833
query45 174 179 180 179
query46 846 1046 646 646
query47 1753 1768 1710 1710
query48 381 430 304 304
query49 771 517 452 452
query50 664 678 408 408
query51 4155 4163 4104 4104
query52 111 106 97 97
query53 231 267 180 180
query54 602 582 509 509
query55 88 82 86 82
query56 313 315 303 303
query57 1125 1143 1106 1106
query58 261 256 248 248
query59 2614 2660 2573 2573
query60 327 321 301 301
query61 129 123 128 123
query62 783 730 670 670
query63 220 190 181 181
query64 4395 1040 721 721
query65 4350 4212 4276 4212
query66 1158 413 319 319
query67 15877 15683 15439 15439
query68 8593 913 528 528
query69 485 324 272 272
query70 1189 1150 1085 1085
query71 467 320 299 299
query72 5578 4766 4847 4766
query73 753 661 360 360
query74 9130 8895 9158 8895
query75 3987 3264 2773 2773
query76 3644 1195 790 790
query77 820 397 289 289
query78 10082 10185 9234 9234
query79 2669 833 581 581
query80 643 534 458 458
query81 504 254 217 217
query82 523 128 97 97
query83 290 271 239 239
query84 296 105 90 90
query85 819 398 307 307
query86 403 323 282 282
query87 4351 4402 4359 4359
query88 3354 2330 2331 2330
query89 411 310 293 293
query90 1828 225 222 222
query91 141 145 110 110
query92 89 64 58 58
query93 1835 944 584 584
query94 685 420 303 303
query95 383 294 295 294
query96 504 582 283 283
query97 2724 2739 2698 2698
query98 248 208 208 208
query99 1446 1386 1297 1297
Total cold run time: 274886 ms
Total hot run time: 186371 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2900239323
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2895177109
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/998c86669cd6ff7910477c48607d3e52d5e13408_998c86669cd6ff7910477c48607d3e52d5e13408_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/998c86669cd6ff7910477c48607d3e52d5e13408_998c86669cd6ff7910477c48607d3e52d5e13408_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1113/1336) |
| Line Coverage | 66.23% (18667/28187) |
| Region Coverage | 65.77% (9258/14076) |
| Branch Coverage | 55.61% (4985/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2890258713
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/40558b979dafd05eeaca2d7be50b035491eb3d18_40558b979dafd05eeaca2d7be50b035491eb3d18_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/40558b979dafd05eeaca2d7be50b035491eb3d18_40558b979dafd05eeaca2d7be50b035491eb3d18_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.31% (1113/1336) |
| Line Coverage | 66.26% (18676/28187) |
| Region Coverage | 65.86% (9270/14076) |
| Branch Coverage | 55.67% (4990/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2903991856
# BE UT Coverage Report
Increment line coverage `23.38% (72/308)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2253603deb065239177f2befdc0eac6184adfc0a_2253603deb065239177f2befdc0eac6184adfc0a/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2253603deb065239177f2befdc0eac6184adfc0a_2253603deb065239177f2befdc0eac6184adfc0a/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 56.06% (14943/26653) |
| Line Coverage | 44.87% (132917/296227) |
| Region Coverage | 43.96% (66835/152043) |
| Branch Coverage | 38.60% (34300/88862) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2828318271
<details>
<summary>ClickBench: <b>Total hot run time: 29.18 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5650a1d1a11b09aa9f804cf810d60aec61718c1f, data reload: false
query1 0.04 0.04 0.03
query2 0.14 0.11 0.11
query3 0.26 0.19 0.19
query4 1.60 0.18 0.20
query5 0.58 0.59 0.61
query6 1.19 0.71 0.71
query7 0.02 0.02 0.02
query8 0.05 0.03 0.04
query9 0.58 0.52 0.51
query10 0.56 0.56 0.56
query11 0.16 0.10 0.12
query12 0.15 0.11 0.12
query13 0.61 0.59 0.59
query14 1.19 1.16 1.19
query15 0.88 0.84 0.84
query16 0.40 0.38 0.38
query17 1.05 1.03 1.00
query18 0.21 0.21 0.20
query19 1.92 1.81 1.79
query20 0.01 0.02 0.01
query21 15.40 0.89 0.56
query22 0.76 1.19 0.77
query23 14.82 1.38 0.62
query24 7.24 1.71 0.32
query25 0.28 0.14 0.13
query26 0.64 0.16 0.15
query27 0.05 0.04 0.04
query28 9.12 0.88 0.42
query29 12.55 4.01 3.36
query30 0.25 0.09 0.07
query31 2.82 0.58 0.38
query32 3.24 0.54 0.48
query33 3.03 3.04 3.01
query34 15.76 5.11 4.50
query35 4.51 4.60 4.48
query36 0.65 0.50 0.48
query37 0.09 0.07 0.06
query38 0.05 0.03 0.04
query39 0.03 0.03 0.02
query40 0.17 0.16 0.13
query41 0.09 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.02
Total cold run time: 103.22 s
Total hot run time: 29.18 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2828809536
# BE Regression P0 && UT Coverage Report
Increment line coverage `4.55% (13/286)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_5650a1d1a11b09aa9f804cf810d60aec61718c1f_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_5650a1d1a11b09aa9f804cf810d60aec61718c1f_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | |
| Line Coverage | |
| Region Coverage | |
| Branch Coverage | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2863763934
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2834027577
# BE Regression P0 && UT Coverage Report
Increment line coverage `4.55% (13/286)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_52a7949fc04539b6896be4dc0a35c46db90b026a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_52a7949fc04539b6896be4dc0a35c46db90b026a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.52% (14782/26626) |
| Line Coverage | 45.14% (133795/296416) |
| Region Coverage | 42.07% (76893/182753) |
| Branch Coverage | 36.08% (37174/103044) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837964032
# BE UT Coverage Report
Increment line coverage `3.92% (13/332)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/de50d882580d5dbe9a4e0d1c2a701e9c9f262b53_de50d882580d5dbe9a4e0d1c2a701e9c9f262b53/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/de50d882580d5dbe9a4e0d1c2a701e9c9f262b53_de50d882580d5dbe9a4e0d1c2a701e9c9f262b53/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.72% (14763/26977) |
| Line Coverage | 43.81% (129394/295359) |
| Region Coverage | 42.52% (66050/155325) |
| Branch Coverage | 37.12% (33318/89752) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837308495
TeamCity cloud ut coverage result:
Function Coverage: 83.08% (1100/1324)
Line Coverage: 65.87% (18396/27928)
Region Coverage: 65.35% (9126/13964)
Branch Coverage: 55.25% (4903/8874)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1fe74eb55e604067de350b2c01a57f79127b711e_1fe74eb55e604067de350b2c01a57f79127b711e_cloud/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837792927
<details>
<summary>TPC-H: <b>Total hot run time: 33987 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit de50d882580d5dbe9a4e0d1c2a701e9c9f262b53, data reload: false
------ Round 1 ----------------------------------
q1 26471 5083 5060 5060
q2 2073 276 183 183
q3 10412 1262 721 721
q4 10220 1011 525 525
q5 7555 2286 2392 2286
q6 176 161 133 133
q7 927 750 611 611
q8 9329 1313 1088 1088
q9 6761 5144 5174 5144
q10 6807 2314 1885 1885
q11 470 281 260 260
q12 340 358 210 210
q13 17780 3670 3060 3060
q14 227 219 211 211
q15 524 483 490 483
q16 418 428 369 369
q17 598 847 350 350
q18 7647 7242 7168 7168
q19 1205 956 593 593
q20 333 347 223 223
q21 3816 3381 2474 2474
q22 1043 1018 950 950
Total cold run time: 115132 ms
Total hot run time: 33987 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5081 5063 5104 5063
q2 236 337 228 228
q3 2166 2651 2285 2285
q4 1328 1770 1345 1345
q5 4524 4437 4412 4412
q6 221 167 130 130
q7 1962 1915 1738 1738
q8 2539 2600 2516 2516
q9 7163 7114 7111 7111
q10 3008 3184 2750 2750
q11 569 490 477 477
q12 651 755 638 638
q13 3393 3916 3213 3213
q14 273 298 274 274
q15 527 476 475 475
q16 441 487 442 442
q17 1119 1535 1356 1356
q18 7617 7505 7393 7393
q19 785 817 921 817
q20 2050 2002 1895 1895
q21 5038 4576 4630 4576
q22 1046 1017 990 990
Total cold run time: 51737 ms
Total hot run time: 50124 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2837820843
<details>
<summary>TPC-DS: <b>Total hot run time: 185819 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit de50d882580d5dbe9a4e0d1c2a701e9c9f262b53, data reload: false
query1 1023 465 498 465
query2 6558 1774 1779 1774
query3 6763 223 211 211
query4 26160 23362 23353 23353
query5 4306 609 441 441
query6 305 201 197 197
query7 4616 485 276 276
query8 318 247 236 236
query9 8626 2542 2540 2540
query10 461 312 248 248
query11 15651 15016 14748 14748
query12 171 108 107 107
query13 1655 539 414 414
query14 9410 5990 6046 5990
query15 210 192 161 161
query16 7253 632 476 476
query17 1211 776 599 599
query18 1992 407 299 299
query19 196 186 159 159
query20 123 123 117 117
query21 219 126 114 114
query22 4222 4404 4153 4153
query23 33939 32968 33021 32968
query24 8531 2411 2394 2394
query25 574 480 421 421
query26 1280 274 152 152
query27 2746 494 323 323
query28 4314 2038 2035 2035
query29 760 540 421 421
query30 279 216 182 182
query31 970 859 756 756
query32 72 63 62 62
query33 559 360 305 305
query34 790 860 512 512
query35 791 789 810 789
query36 946 965 860 860
query37 111 102 79 79
query38 4142 4176 4053 4053
query39 1453 1392 1392 1392
query40 223 121 109 109
query41 57 57 52 52
query42 122 108 106 106
query43 503 494 481 481
query44 1274 788 788 788
query45 177 172 164 164
query46 818 1021 627 627
query47 1790 1798 1767 1767
query48 373 417 289 289
query49 769 523 440 440
query50 634 685 394 394
query51 4081 4137 4043 4043
query52 116 100 95 95
query53 217 256 183 183
query54 580 563 496 496
query55 88 76 77 76
query56 297 300 286 286
query57 1105 1150 1097 1097
query58 264 272 252 252
query59 2583 2724 2535 2535
query60 316 322 340 322
query61 134 131 125 125
query62 786 724 671 671
query63 219 183 183 183
query64 4352 1011 725 725
query65 4341 4273 4245 4245
query66 1128 415 330 330
query67 15649 15426 15575 15426
query68 8531 881 546 546
query69 469 305 281 281
query70 1191 1102 1086 1086
query71 477 317 285 285
query72 5759 4840 4855 4840
query73 734 666 348 348
query74 8837 8859 8957 8859
query75 3981 3200 2712 2712
query76 3711 1193 754 754
query77 796 386 282 282
query78 10101 10270 9297 9297
query79 2112 807 575 575
query80 651 533 443 443
query81 505 265 215 215
query82 458 133 99 99
query83 289 251 238 238
query84 272 100 84 84
query85 813 361 386 361
query86 403 308 257 257
query87 4402 4387 4312 4312
query88 3538 2184 2222 2184
query89 389 307 278 278
query90 1928 210 201 201
query91 146 146 112 112
query92 80 65 57 57
query93 1584 947 569 569
query94 660 403 302 302
query95 370 290 280 280
query96 498 565 269 269
query97 3148 3249 3134 3134
query98 237 207 210 207
query99 1427 1406 1263 1263
Total cold run time: 275199 ms
Total hot run time: 185819 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2834529958
<details>
<summary>TPC-DS: <b>Total hot run time: 192605 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7a772c870025b13d35a08d10543510c94f52d3bf, data reload: false
query1 1459 1089 1087 1087
query2 6210 1820 1741 1741
query3 11022 4499 4537 4499
query4 55751 25806 22985 22985
query5 5179 501 475 475
query6 369 191 188 188
query7 5112 496 285 285
query8 335 260 245 245
query9 6628 2549 2575 2549
query10 416 318 269 269
query11 15187 14980 15126 14980
query12 160 112 101 101
query13 1172 503 396 396
query14 10148 6391 6511 6391
query15 215 206 177 177
query16 7018 655 511 511
query17 1105 721 561 561
query18 1551 387 311 311
query19 206 191 161 161
query20 127 117 126 117
query21 203 127 109 109
query22 4433 4398 4405 4398
query23 34228 33537 33624 33537
query24 6586 2476 2437 2437
query25 505 501 445 445
query26 679 293 158 158
query27 2226 506 341 341
query28 3213 2119 2124 2119
query29 557 558 419 419
query30 268 213 191 191
query31 851 857 761 761
query32 79 140 64 64
query33 436 376 312 312
query34 765 848 530 530
query35 810 837 746 746
query36 962 1008 931 931
query37 118 103 77 77
query38 4265 4217 4163 4163
query39 1493 1440 1424 1424
query40 215 122 110 110
query41 55 53 54 53
query42 125 112 113 112
query43 499 506 469 469
query44 1317 807 805 805
query45 190 179 171 171
query46 849 1016 682 682
query47 1850 1896 1833 1833
query48 388 410 313 313
query49 693 494 429 429
query50 652 688 402 402
query51 4193 4338 4225 4225
query52 120 101 99 99
query53 228 263 185 185
query54 590 604 523 523
query55 89 82 86 82
query56 304 326 281 281
query57 1165 1208 1122 1122
query58 271 274 256 256
query59 2629 2732 2588 2588
query60 333 324 326 324
query61 130 135 126 126
query62 737 741 692 692
query63 232 183 191 183
query64 1466 1062 765 765
query65 4447 4340 4235 4235
query66 715 452 305 305
query67 16011 15571 15561 15561
query68 7264 875 522 522
query69 554 296 260 260
query70 1157 1070 1055 1055
query71 526 310 281 281
query72 5764 4779 4889 4779
query73 1166 680 343 343
query74 8973 9025 8645 8645
query75 3797 3238 2713 2713
query76 4228 1199 744 744
query77 625 376 276 276
query78 10195 10029 9283 9283
query79 2579 813 567 567
query80 678 511 446 446
query81 489 258 213 213
query82 582 128 100 100
query83 251 250 250 250
query84 302 108 86 86
query85 890 356 317 317
query86 401 307 258 258
query87 4409 4340 4371 4340
query88 3367 2204 2182 2182
query89 409 328 284 284
query90 1791 212 215 212
query91 140 140 109 109
query92 75 63 60 60
query93 2545 951 577 577
query94 680 407 290 290
query95 368 299 291 291
query96 488 567 272 272
query97 3177 3219 3229 3219
query98 221 214 198 198
query99 1422 1404 1311 1311
Total cold run time: 302053 ms
Total hot run time: 192605 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2839316188
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2854274643
<details>
<summary>TPC-DS: <b>Total hot run time: 185841 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 07236b6a14c6d794c68952ce96264e4193e00838, data reload: false
query1 1008 478 486 478
query2 6552 1768 1773 1768
query3 6763 222 216 216
query4 26726 24022 23466 23466
query5 4498 630 459 459
query6 315 188 188 188
query7 4618 488 281 281
query8 277 249 242 242
query9 8654 2568 2576 2568
query10 488 334 284 284
query11 15379 15041 15230 15041
query12 172 112 105 105
query13 1662 529 411 411
query14 9663 6226 6138 6138
query15 199 195 171 171
query16 7378 595 450 450
query17 1172 709 564 564
query18 1964 402 315 315
query19 187 184 156 156
query20 126 114 115 114
query21 207 146 103 103
query22 4060 4113 4081 4081
query23 34006 32956 32955 32955
query24 8440 2364 2367 2364
query25 533 443 404 404
query26 1240 265 152 152
query27 2751 518 330 330
query28 4288 2105 2082 2082
query29 739 551 427 427
query30 278 220 189 189
query31 938 845 748 748
query32 72 64 65 64
query33 576 376 323 323
query34 798 838 506 506
query35 818 807 744 744
query36 961 1012 886 886
query37 125 109 87 87
query38 4202 4135 4207 4135
query39 1479 1377 1380 1377
query40 216 128 113 113
query41 65 60 57 57
query42 117 112 113 112
query43 495 476 484 476
query44 1338 792 793 792
query45 177 175 176 175
query46 840 1025 654 654
query47 1746 1795 1710 1710
query48 380 426 311 311
query49 803 545 402 402
query50 670 677 388 388
query51 4065 4129 4015 4015
query52 110 102 104 102
query53 240 254 186 186
query54 584 562 496 496
query55 86 85 80 80
query56 298 299 283 283
query57 1135 1117 1133 1117
query58 264 246 249 246
query59 2610 2650 2553 2553
query60 320 331 312 312
query61 126 120 123 120
query62 816 722 657 657
query63 221 192 185 185
query64 4296 998 678 678
query65 4385 4241 4289 4241
query66 1120 428 340 340
query67 15780 15525 15202 15202
query68 9193 889 499 499
query69 466 309 263 263
query70 1222 1087 1089 1087
query71 475 308 338 308
query72 5158 4678 4717 4678
query73 723 585 415 415
query74 8915 9204 8701 8701
query75 4289 3175 2721 2721
query76 3703 1257 758 758
query77 895 395 285 285
query78 9977 10135 9301 9301
query79 1966 910 572 572
query80 622 509 423 423
query81 470 259 209 209
query82 423 130 96 96
query83 290 252 227 227
query84 296 103 86 86
query85 776 345 302 302
query86 345 313 280 280
query87 4390 4446 4373 4373
query88 2888 2207 2172 2172
query89 388 310 282 282
query90 1923 216 214 214
query91 134 132 107 107
query92 77 61 62 61
query93 1113 944 579 579
query94 674 422 299 299
query95 372 282 276 276
query96 497 583 281 281
query97 3173 3203 3100 3100
query98 232 209 206 206
query99 1442 1411 1305 1305
Total cold run time: 275122 ms
Total hot run time: 185841 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2854287662
<details>
<summary>ClickBench: <b>Total hot run time: 28.67 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 07236b6a14c6d794c68952ce96264e4193e00838, data reload: false
query1 0.04 0.04 0.03
query2 0.11 0.10 0.10
query3 0.26 0.20 0.20
query4 1.60 0.19 0.19
query5 0.58 0.56 0.55
query6 1.19 0.72 0.72
query7 0.02 0.02 0.02
query8 0.04 0.04 0.03
query9 0.56 0.52 0.51
query10 0.56 0.56 0.56
query11 0.15 0.10 0.10
query12 0.15 0.11 0.11
query13 0.62 0.60 0.60
query14 0.77 0.82 0.79
query15 0.87 0.86 0.85
query16 0.37 0.38 0.40
query17 1.01 1.02 1.01
query18 0.21 0.20 0.19
query19 1.84 1.87 1.78
query20 0.02 0.01 0.01
query21 15.40 0.88 0.55
query22 0.75 1.22 0.65
query23 14.91 1.40 0.64
query24 7.26 2.15 0.45
query25 0.50 0.07 0.19
query26 0.64 0.17 0.14
query27 0.06 0.04 0.05
query28 9.24 0.83 0.41
query29 12.55 3.94 3.29
query30 0.24 0.08 0.06
query31 2.83 0.58 0.39
query32 3.22 0.54 0.47
query33 3.01 3.05 3.05
query34 15.82 5.13 4.48
query35 4.54 4.50 4.47
query36 0.68 0.48 0.48
query37 0.08 0.07 0.06
query38 0.05 0.04 0.03
query39 0.03 0.02 0.03
query40 0.16 0.12 0.12
query41 0.08 0.02 0.02
query42 0.02 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.08 s
Total hot run time: 28.67 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2853045547
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2859360774
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on code in PR #50379:
URL: https://github.com/apache/doris/pull/50379#discussion_r2086029446
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/LoadScanProvider.java:
##########
@@ -97,7 +96,8 @@ public FileLoadScanNode.ParamCreateContext createContext(Analyzer analyzer) thro
}
if (fileGroupInfo.getFileGroup().getFileFormat() != null
&& fileGroupInfo.getFileGroup().getFileFormat().equals("hive_text")) {
- params.setTextSerdeType(TTextSerdeType.HIVE_TEXT_SERDE);
+ // TODO: set correct format type for load job
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2875631217
<details>
<summary>TPC-DS: <b>Total hot run time: 194789 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ce8b7c5f5c3badd342ea0b9eed0829071994960c, data reload: false
query1 1408 1078 1081 1078
query2 6294 1847 1814 1814
query3 11053 4558 4529 4529
query4 54969 24247 23460 23460
query5 4957 552 489 489
query6 360 215 211 211
query7 4910 523 306 306
query8 327 251 250 250
query9 5702 2678 2674 2674
query10 455 341 272 272
query11 15050 15109 14918 14918
query12 164 114 100 100
query13 1043 529 396 396
query14 10199 6403 6511 6403
query15 200 208 174 174
query16 7108 663 490 490
query17 1097 732 565 565
query18 1617 414 317 317
query19 202 200 160 160
query20 122 126 123 123
query21 210 124 111 111
query22 4466 4523 4330 4330
query23 34273 33581 33630 33581
query24 6568 2452 2439 2439
query25 525 528 443 443
query26 679 287 159 159
query27 2382 533 349 349
query28 2918 2221 2191 2191
query29 622 609 522 522
query30 280 223 191 191
query31 867 863 797 797
query32 72 66 59 59
query33 455 395 319 319
query34 801 866 561 561
query35 787 851 741 741
query36 940 1006 917 917
query37 113 100 77 77
query38 4243 4323 4193 4193
query39 1547 1437 1460 1437
query40 221 124 108 108
query41 54 52 52 52
query42 122 119 110 110
query43 488 509 488 488
query44 1369 863 859 859
query45 176 176 179 176
query46 871 1050 717 717
query47 1915 1905 1764 1764
query48 394 419 332 332
query49 692 525 459 459
query50 664 697 423 423
query51 4291 4447 4301 4301
query52 103 108 104 104
query53 243 265 192 192
query54 606 592 538 538
query55 90 84 86 84
query56 331 309 288 288
query57 1177 1213 1131 1131
query58 264 257 253 253
query59 2742 2738 2656 2656
query60 335 330 336 330
query61 136 128 129 128
query62 759 730 701 701
query63 225 232 194 194
query64 1732 1056 697 697
query65 4331 4246 4212 4212
query66 733 400 305 305
query67 15887 15692 15643 15643
query68 6857 835 525 525
query69 540 316 285 285
query70 1241 1072 1134 1072
query71 486 332 304 304
query72 5789 4981 4973 4973
query73 1435 684 370 370
query74 9331 8926 8920 8920
query75 3940 3230 2734 2734
query76 4316 1279 779 779
query77 663 366 302 302
query78 10214 10318 9313 9313
query79 2147 817 584 584
query80 598 506 442 442
query81 500 253 222 222
query82 468 130 104 104
query83 259 271 239 239
query84 297 100 85 85
query85 774 360 316 316
query86 374 301 251 251
query87 4413 4598 4411 4411
query88 3739 2357 2333 2333
query89 417 319 293 293
query90 1843 206 214 206
query91 142 142 118 118
query92 82 60 58 58
query93 1737 932 580 580
query94 670 420 314 314
query95 365 297 286 286
query96 509 562 291 291
query97 3164 3246 3171 3171
query98 227 207 201 201
query99 1416 1397 1316 1316
Total cold run time: 299889 ms
Total hot run time: 194789 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2875647259
<details>
<summary>ClickBench: <b>Total hot run time: 29.85 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ce8b7c5f5c3badd342ea0b9eed0829071994960c, data reload: false
query1 0.04 0.04 0.02
query2 0.15 0.11 0.11
query3 0.34 0.20 0.20
query4 1.60 0.21 0.09
query5 0.55 0.55 0.55
query6 1.20 0.73 0.72
query7 0.02 0.01 0.02
query8 0.05 0.05 0.07
query9 0.62 0.52 0.52
query10 0.57 0.57 0.56
query11 0.26 0.14 0.13
query12 0.26 0.13 0.13
query13 0.62 0.62 0.62
query14 0.80 0.82 0.83
query15 0.96 0.89 0.87
query16 0.37 0.37 0.37
query17 1.06 1.02 1.06
query18 0.18 0.18 0.17
query19 2.04 1.85 1.84
query20 0.01 0.02 0.01
query21 15.43 0.97 0.68
query22 0.94 1.02 0.83
query23 14.69 1.53 0.78
query24 5.15 0.60 0.30
query25 0.16 0.10 0.08
query26 0.56 0.22 0.19
query27 0.08 0.08 0.09
query28 10.99 1.21 0.59
query29 12.56 4.12 3.41
query30 0.28 0.09 0.07
query31 2.82 0.63 0.42
query32 3.24 0.60 0.50
query33 3.11 3.07 3.18
query34 16.38 5.16 4.43
query35 4.50 4.45 4.47
query36 0.63 0.51 0.49
query37 0.19 0.17 0.17
query38 0.17 0.17 0.15
query39 0.05 0.05 0.05
query40 0.18 0.17 0.16
query41 0.10 0.05 0.05
query42 0.06 0.04 0.05
query43 0.05 0.05 0.05
Total cold run time: 104.02 s
Total hot run time: 29.85 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2903734587
<details>
<summary>TPC-H: <b>Total hot run time: 33836 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2253603deb065239177f2befdc0eac6184adfc0a, data reload: false
------ Round 1 ----------------------------------
q1 26313 5016 4954 4954
q2 2070 286 193 193
q3 10394 1292 697 697
q4 10225 1000 515 515
q5 7541 2369 2332 2332
q6 188 164 132 132
q7 915 766 597 597
q8 9306 1282 1036 1036
q9 6910 5190 5106 5106
q10 6807 2320 1911 1911
q11 479 289 280 280
q12 335 347 212 212
q13 17805 3710 3090 3090
q14 223 223 226 223
q15 528 492 480 480
q16 412 440 375 375
q17 577 860 356 356
q18 7631 7322 7205 7205
q19 885 953 557 557
q20 356 336 239 239
q21 3791 2568 2365 2365
q22 1071 1018 981 981
Total cold run time: 114762 ms
Total hot run time: 33836 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5048 5040 5061 5040
q2 247 322 232 232
q3 2201 2639 2282 2282
q4 1329 1790 1331 1331
q5 4382 4399 4398 4398
q6 219 179 129 129
q7 2048 1965 1787 1787
q8 2615 2565 2527 2527
q9 7294 7265 7105 7105
q10 3049 3211 2767 2767
q11 576 521 509 509
q12 660 757 608 608
q13 3562 3859 3325 3325
q14 313 317 296 296
q15 520 476 467 467
q16 438 466 445 445
q17 1172 1533 1400 1400
q18 7908 7635 7533 7533
q19 783 822 858 822
q20 2031 1972 1858 1858
q21 4848 4430 4443 4430
q22 1153 1073 1019 1019
Total cold run time: 52396 ms
Total hot run time: 50310 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2904063239
# BE Regression && UT Coverage Report
Increment line coverage `56.35% (173/307)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50379_2253603deb065239177f2befdc0eac6184adfc0a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50379_2253603deb065239177f2befdc0eac6184adfc0a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 60.43% (15853/26235) |
| Line Coverage | 49.96% (148002/296213) |
| Region Coverage | 47.21% (84305/178573) |
| Branch Coverage | 40.80% (41409/101496) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2947797410
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2944482421
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2943506447
<details>
<summary>TPC-DS: <b>Total hot run time: 193278 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fc3e4adc9036c348a83a0cad346689ccb7096b46, data reload: false
query1 1440 1100 1068 1068
query2 6269 1862 1883 1862
query3 11065 4596 4397 4397
query4 52903 25922 22963 22963
query5 5148 642 479 479
query6 351 223 209 209
query7 4928 517 295 295
query8 299 232 221 221
query9 5736 2773 2778 2773
query10 464 337 271 271
query11 15056 15040 14900 14900
query12 160 110 117 110
query13 1078 549 429 429
query14 10188 6532 6436 6436
query15 209 185 184 184
query16 7087 631 501 501
query17 1095 719 584 584
query18 1597 410 326 326
query19 212 191 176 176
query20 133 138 123 123
query21 207 124 113 113
query22 4479 4462 4317 4317
query23 34205 33512 33809 33512
query24 6650 2405 2442 2405
query25 462 484 408 408
query26 701 277 163 163
query27 2379 556 361 361
query28 3060 2291 2259 2259
query29 598 552 459 459
query30 271 229 197 197
query31 884 867 775 775
query32 70 67 65 65
query33 501 378 337 337
query34 808 867 550 550
query35 790 875 755 755
query36 973 1012 930 930
query37 118 107 79 79
query38 4382 4348 4167 4167
query39 1533 1531 1466 1466
query40 216 126 109 109
query41 61 59 67 59
query42 126 112 109 109
query43 515 514 505 505
query44 1346 860 884 860
query45 186 182 178 178
query46 867 1050 662 662
query47 1854 1904 1787 1787
query48 460 453 349 349
query49 650 500 419 419
query50 703 709 420 420
query51 4373 4280 4221 4221
query52 111 113 105 105
query53 235 266 187 187
query54 601 604 522 522
query55 89 88 91 88
query56 316 315 322 315
query57 1178 1186 1150 1150
query58 272 264 271 264
query59 2702 2812 2818 2812
query60 342 335 315 315
query61 134 130 136 130
query62 751 753 687 687
query63 237 198 197 197
query64 2045 1043 704 704
query65 4206 4175 4141 4141
query66 723 400 309 309
query67 16022 15555 15444 15444
query68 6055 908 555 555
query69 543 317 289 289
query70 1267 1151 1129 1129
query71 451 323 301 301
query72 5960 4731 4775 4731
query73 1412 629 368 368
query74 9247 8824 9101 8824
query75 3189 3252 2704 2704
query76 3908 1203 773 773
query77 536 372 296 296
query78 10035 10227 9309 9309
query79 2712 842 592 592
query80 663 532 448 448
query81 499 256 217 217
query82 446 134 101 101
query83 311 267 236 236
query84 302 113 94 94
query85 785 365 334 334
query86 354 328 295 295
query87 4403 4593 4446 4446
query88 3597 2320 2307 2307
query89 395 329 286 286
query90 1656 207 203 203
query91 152 151 114 114
query92 76 66 58 58
query93 2060 966 608 608
query94 730 408 291 291
query95 375 306 297 297
query96 525 583 291 291
query97 2722 2784 2616 2616
query98 235 216 215 215
query99 1445 1389 1277 1277
Total cold run time: 296856 ms
Total hot run time: 193278 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2942884327
<details>
<summary>TPC-DS: <b>Total hot run time: 185827 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0587de7ce408c6cdb9b6a233bb918066405641ad, data reload: false
query1 1011 478 502 478
query2 6582 1826 1823 1823
query3 6749 234 230 230
query4 26227 23950 22865 22865
query5 4368 634 473 473
query6 324 220 202 202
query7 4633 498 298 298
query8 272 227 208 208
query9 8648 2669 2658 2658
query10 490 325 280 280
query11 15267 15035 14810 14810
query12 157 113 113 113
query13 1662 540 419 419
query14 9387 6263 6290 6263
query15 215 204 173 173
query16 7389 686 468 468
query17 1182 698 552 552
query18 1964 404 315 315
query19 182 184 162 162
query20 119 117 119 117
query21 215 123 110 110
query22 4048 4125 3987 3987
query23 33860 32994 33266 32994
query24 8415 2375 2416 2375
query25 520 451 395 395
query26 778 267 156 156
query27 2732 509 350 350
query28 4288 2152 2128 2128
query29 683 569 425 425
query30 287 220 187 187
query31 963 832 758 758
query32 69 73 63 63
query33 543 358 328 328
query34 807 892 521 521
query35 781 815 736 736
query36 932 993 926 926
query37 119 107 76 76
query38 4160 4184 4115 4115
query39 1449 1390 1442 1390
query40 208 121 105 105
query41 63 59 59 59
query42 130 109 111 109
query43 491 508 481 481
query44 1372 834 828 828
query45 175 179 175 175
query46 858 1022 630 630
query47 1742 1784 1723 1723
query48 406 425 310 310
query49 715 509 400 400
query50 650 680 422 422
query51 4112 4203 4063 4063
query52 110 107 98 98
query53 228 257 184 184
query54 586 567 504 504
query55 90 87 88 87
query56 307 301 293 293
query57 1131 1168 1105 1105
query58 271 260 266 260
query59 2689 2728 2491 2491
query60 327 307 317 307
query61 128 127 163 127
query62 818 737 672 672
query63 224 188 186 186
query64 3355 1065 777 777
query65 4262 4157 4131 4131
query66 1010 416 305 305
query67 15682 15441 15435 15435
query68 8880 893 525 525
query69 486 297 262 262
query70 1258 1094 1075 1075
query71 466 330 299 299
query72 5264 4649 4645 4645
query73 706 585 358 358
query74 8933 9156 9167 9156
query75 4271 3216 2684 2684
query76 3615 1188 759 759
query77 812 382 346 346
query78 10026 10210 9306 9306
query79 2001 818 604 604
query80 656 522 460 460
query81 476 257 225 225
query82 467 130 100 100
query83 281 256 230 230
query84 344 112 95 95
query85 783 354 315 315
query86 330 328 284 284
query87 4439 4398 4339 4339
query88 2942 2291 2285 2285
query89 388 315 277 277
query90 1962 215 215 215
query91 148 147 111 111
query92 69 61 56 56
query93 1832 946 587 587
query94 684 435 311 311
query95 382 293 293 293
query96 504 635 287 287
query97 2693 2709 2655 2655
query98 227 205 203 203
query99 1420 1434 1286 1286
Total cold run time: 272362 ms
Total hot run time: 185827 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2942895448
<details>
<summary>ClickBench: <b>Total hot run time: 29.55 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0587de7ce408c6cdb9b6a233bb918066405641ad, data reload: false
query1 0.03 0.04 0.03
query2 0.12 0.11 0.10
query3 0.25 0.19 0.19
query4 1.60 0.20 0.20
query5 0.46 0.45 0.46
query6 1.51 0.66 0.66
query7 0.03 0.02 0.02
query8 0.04 0.04 0.04
query9 0.57 0.52 0.52
query10 0.58 0.58 0.56
query11 0.16 0.12 0.12
query12 0.14 0.12 0.12
query13 0.62 0.59 0.60
query14 0.81 0.81 0.81
query15 0.88 0.86 0.86
query16 0.39 0.38 0.38
query17 1.05 1.04 1.04
query18 0.22 0.21 0.21
query19 1.92 1.89 1.86
query20 0.02 0.01 0.02
query21 15.40 0.88 0.55
query22 0.74 1.12 0.66
query23 15.08 1.41 0.64
query24 6.90 1.14 1.18
query25 0.49 0.16 0.08
query26 0.67 0.18 0.13
query27 0.06 0.05 0.05
query28 9.58 0.93 0.47
query29 12.59 4.02 3.32
query30 0.25 0.09 0.06
query31 2.83 0.61 0.40
query32 3.24 0.56 0.47
query33 3.00 3.05 3.14
query34 15.94 5.12 4.48
query35 4.59 4.48 4.55
query36 0.66 0.50 0.48
query37 0.09 0.06 0.07
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.15 0.13
query41 0.08 0.03 0.02
query42 0.04 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.92 s
Total hot run time: 29.55 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2899802997
<details>
<summary>TPC-H: <b>Total hot run time: 34081 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 52fa5c5962bbc72ffa38580cf8a1050eb0367689, data reload: false
------ Round 1 ----------------------------------
q1 26388 5134 5080 5080
q2 2090 287 194 194
q3 10568 1312 702 702
q4 10231 1014 530 530
q5 7812 2365 2349 2349
q6 183 163 133 133
q7 919 769 619 619
q8 9319 1358 1091 1091
q9 6784 5092 5126 5092
q10 6834 2323 1892 1892
q11 500 279 273 273
q12 352 354 221 221
q13 17807 3666 3071 3071
q14 230 226 217 217
q15 520 476 500 476
q16 441 432 381 381
q17 590 859 379 379
q18 7875 7245 7225 7225
q19 1502 976 591 591
q20 325 338 231 231
q21 3821 3188 2369 2369
q22 1062 1003 965 965
Total cold run time: 116153 ms
Total hot run time: 34081 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5230 5185 5135 5135
q2 239 335 234 234
q3 2161 2674 2266 2266
q4 1356 1788 1480 1480
q5 4446 4396 4406 4396
q6 220 168 133 133
q7 1999 1946 1807 1807
q8 2589 2601 2519 2519
q9 7233 7179 6971 6971
q10 3054 3154 2791 2791
q11 573 528 500 500
q12 674 744 623 623
q13 3536 3918 3278 3278
q14 285 300 272 272
q15 563 515 491 491
q16 445 490 442 442
q17 1138 1590 1367 1367
q18 7898 7657 7635 7635
q19 865 852 1117 852
q20 2020 1955 1842 1842
q21 4774 4548 4471 4471
q22 1112 1084 1069 1069
Total cold run time: 52410 ms
Total hot run time: 50574 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2903047649
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/43e7251cf041c9b92b6e83e38b7fbc7f18294c78_43e7251cf041c9b92b6e83e38b7fbc7f18294c78_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/43e7251cf041c9b92b6e83e38b7fbc7f18294c78_43e7251cf041c9b92b6e83e38b7fbc7f18294c78_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.15% (18669/28223) |
| Region Coverage | 65.81% (9264/14077) |
| Branch Coverage | 55.60% (4984/8964) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](hive) Refactor csv reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50379:
URL: https://github.com/apache/doris/pull/50379#issuecomment-2910176343
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/cfefcb593357db219db76f3389ca8974c0b938a0_cfefcb593357db219db76f3389ca8974c0b938a0_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/cfefcb593357db219db76f3389ca8974c0b938a0_cfefcb593357db219db76f3389ca8974c0b938a0_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 83.25% (1113/1337) |
| Line Coverage | 66.18% (18680/28224) |
| Region Coverage | 65.85% (9271/14079) |
| Branch Coverage | 55.64% (4989/8966) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org