You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by omefire <gi...@git.apache.org> on 2016/01/14 00:03:00 UTC
[GitHub] cordova-docs pull request: Cleaning up the 'plugin spec' documenta...
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-docs/pull/456
Cleaning up the 'plugin spec' documentation
This is still in-flight. more commits to come before this PR can be pulled in.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-docs PluginSpecScrub
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #456
----
commit 96e5ef7e5be0b1d47a2ee4381704895d1114e467
Author: Omar Mefire <om...@gmail.com>
Date: 2016-01-13T22:59:07Z
clean up the plugin.xml engines
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/456#issuecomment-182569279
@omefire: Can you close this PR? I took care of most of these changes in my commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...
Posted by omefire <gi...@git.apache.org>.
Github user omefire closed the pull request at:
https://github.com/apache/cordova-docs/pull/456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/456#discussion_r50777672
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -98,12 +98,14 @@ Here's a list of the default engines that the `<engine>` tag supports:
* `cordova`
* `cordova-plugman`
-* `cordova-amazon-fireos`
* `cordova-android`
* `cordova-ios`
* `cordova-blackberry10`
* `cordova-wp8`
* `cordova-windows8`
--- End diff --
We can remove windows8 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/456#discussion_r50777731
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -345,17 +347,20 @@ associating the element's children with that platform.
Platform names should be lowercase. Platform names, as arbitrarily
chosen, are listed:
-* amazon-fireos
* android
* blackberry10
* ios
* wp8
* windows8
--- End diff --
Here too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/456#issuecomment-171804282
@rakatyal can you please review these changes ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/456#issuecomment-174737596
There is already a Jira (CB-10363) for this under Docs 6.x tag. Can you please refer to that one instead and close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org