You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/24 23:16:29 UTC

[kudu-CR] [util] address TODO to remove dummy encryption key

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18904


Change subject: [util] address TODO to remove dummy encryption key
......................................................................

[util] address TODO to remove dummy encryption key

I noticed compiler's warning on unused variable and realized it's time
to address corresponding TODO in util/env_posix.cc.

This patch doesn't contain any functional modifications.

Change-Id: I09be400428b83fb3f5c8494df54f271bb4b0b33c
---
M src/kudu/util/env_posix.cc
1 file changed, 0 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/18904/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09be400428b83fb3f5c8494df54f271bb4b0b33c
Gerrit-Change-Number: 18904
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [util] address TODO to remove dummy encryption key

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18904 )

Change subject: [util] address TODO to remove dummy encryption key
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09be400428b83fb3f5c8494df54f271bb4b0b33c
Gerrit-Change-Number: 18904
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Aug 2022 15:53:14 +0000
Gerrit-HasComments: No

[kudu-CR] [util] address TODO to remove dummy encryption key

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18904 )

Change subject: [util] address TODO to remove dummy encryption key
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09be400428b83fb3f5c8494df54f271bb4b0b33c
Gerrit-Change-Number: 18904
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Aug 2022 16:03:50 +0000
Gerrit-HasComments: No

[kudu-CR] [util] address TODO to remove dummy encryption key

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18904 )

Change subject: [util] address TODO to remove dummy encryption key
......................................................................

[util] address TODO to remove dummy encryption key

I noticed compiler's warning on unused variable and realized it's time
to address corresponding TODO in util/env_posix.cc.

This patch doesn't contain any functional modifications.

Change-Id: I09be400428b83fb3f5c8494df54f271bb4b0b33c
Reviewed-on: http://gerrit.cloudera.org:8080/18904
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/util/env_posix.cc
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, approved
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09be400428b83fb3f5c8494df54f271bb4b0b33c
Gerrit-Change-Number: 18904
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>