[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull request #1561: [SCB-1748] support colon in path value

[GitBox <gi...@apache.org>]

GuoYL123 commented on a change in pull request #1561: [SCB-1748] support colon in path value
URL: https://github.com/apache/servicecomb-java-chassis/pull/1561#discussion_r376275152
 
 

 ##########
 File path: common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/PathProcessorCreator.java
 ##########
 @@ -52,6 +54,9 @@ public Object getValue(HttpServletRequest request) {
       if (value == null) {
         return null;
       }
+      if (value.contains(":")) {
+        return convertValue(URLDecoder.decode(value, "UTF-8"), targetType);
 
 Review comment:
   I notic there is a case org.apache.servicecomb.foundation.common.http.TestHttpUtils#uriDecode_failed
   to show a error when the param of HttpUtils.uriDecodePath contain ":".
   
   I think modify  the HttpUtils.uriDecodePat will change the previous  logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services