[GitHub] [accumulo] keith-turner commented on a change in pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
URL: https://github.com/apache/accumulo/pull/1560#discussion_r391310987
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -549,7 +549,9 @@
   TSERV_SLOW_FILEPERMIT_MILLIS("tserver.slow.filepermit.time", "100ms", PropertyType.TIMEDURATION,
       "If a thread blocks more than this period of time waiting to get file permits,"
           + " debugging information will be written."),
-
+  TSERV_BULK_MAX_TABLET_OVERLAP("tserver.bulk.max.overlap", "0", PropertyType.COUNT,
 
 Review comment:
   Thinking ahead, for the new bulk import code in the 2.x branch I think this check would actually execute in the master.  Therefore the prefix `tserver` is not a good prefix.  This is not a problem with this PR, more of a problem with the current property name conventions.  I searched for bulk in this file and found `master.bulk.` and `tserver.bulk.` prefixes.   The user does not care where the check is done.  Could possibly use the prefix `general` instead of `tserver`, but this creates a third prefix for bulk properties which could make this property harder to find.
   
   Not sure there is a good solution to this problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services