[jira] [Reopened] (CB-4889) Rename all plugins org.apache.cordova.core.* to org.apache.cordova.*

["Andrew Grieve (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CB-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Grieve reopened CB-4889:
-------------------------------


Looks like you forgot to update the JS require() statements to remove ".core":

{quote}
agrieve@agrieve-macbookpro ~/git/cordova$ ./cordova-coho/coho foreach -r plugins "grep -r '\.core\.' ." |grep -v '\.git' | grep -v "Executing comm"
==== Changed directory to: cordova-plugin-battery-status
==== Changed directory to: cordova-plugin-camera
./plugin.xml:        <dependency id="org.apache.cordova.core.file"
./src/windows8/CameraProxy.js:    FileEntry = require('org.apache.cordova.core.file.FileEntry'),
./src/windows8/CameraProxy.js:    FileError = require('org.apache.cordova.core.file.FileError'),
./src/windows8/CameraProxy.js:    FileReader = require('org.apache.cordova.core.file.FileReader');
./test/camera/index.html:            CameraPopoverOptions = cordova.require('org.apache.cordova.core.camera.CameraPopoverOptions');
==== Changed directory to: cordova-plugin-console
==== Changed directory to: cordova-plugin-contacts
./src/blackberry10/plugin.xml:    id="org.apache.cordova.core.Contacts"
==== Changed directory to: cordova-plugin-device-motion
./src/windows8/AccelerometerProxy.js:    Acceleration = require('org.apache.cordova.core.device-motion.Acceleration');
==== Changed directory to: cordova-plugin-device-orientation
./src/windows8/CompassProxy.js:cordova.define("org.apache.cordova.core.device-orientation.CompassProxy", function(require, exports, module) {/*
./src/windows8/CompassProxy.js:    CompassHeading = require('org.apache.cordova.core.device-orientation.CompassHeading'),
./src/windows8/CompassProxy.js:    CompassError = require('org.apache.cordova.core.device-orientation.CompassError')
==== Changed directory to: cordova-plugin-device
==== Changed directory to: cordova-plugin-dialogs
./src/wp/Notification.cs:            string resourcePath = BaseCommand.GetBaseURL() + "Plugins/org.apache.cordova.core.dialogs/notification-beep.wav";
==== Changed directory to: cordova-plugin-file-transfer
./www/FileTransfer.js:    ProgressEvent = require('org.apache.cordova.core.file.ProgressEvent');
./www/FileTransfer.js:                entry = new (require('org.apache.cordova.core.file.DirectoryEntry'))();
./www/FileTransfer.js:                entry = new (require('org.apache.cordova.core.file.FileEntry'))();
./www/windows8/FileTransferProxy.js:    FileUploadResult = require('org.apache.cordova.core.file.FileUploadResult'),
./www/windows8/FileTransferProxy.js:    FileEntry = require('org.apache.cordova.core.file.FileEntry');
==== Changed directory to: cordova-plugin-file
./src/windows8/FileProxy.js:                            var coreCopy = function (storageFolderTop, complete) {
./src/windows8/FileProxy.js:                                        coreCopy(storageFolderTop, complete);
./src/windows8/FileProxy.js:                            var coreMove = function (storageFolderTop, complete) {
./src/windows8/FileProxy.js:                                            coreMove(storageFolderTop, complete);
./www/blackberry10/DirectoryEntry.js:        cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [sandboxState]);
./www/blackberry10/DirectoryEntry.js:    }, "org.apache.cordova.core.file", "isSandboxed");
./www/blackberry10/DirectoryEntry.js:        cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [false]);
./www/blackberry10/DirectoryEntry.js:            cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [sandboxState]);
./www/blackberry10/DirectoryEntry.js:        cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [true]);
./www/blackberry10/DirectoryEntry.js:            cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [sandboxState]);
./www/blackberry10/DirectoryEntry.js:    }, "org.apache.cordova.core.file", "isSandboxed");
./www/blackberry10/DirectoryEntry.js:        cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [false]);
./www/blackberry10/DirectoryEntry.js:            cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [sandboxState]);
./www/blackberry10/DirectoryEntry.js:        cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [true]);
./www/blackberry10/DirectoryEntry.js:            cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [sandboxState]);
./www/blackberry10/resolveLocalFileSystemURI.js:    }, "org.apache.cordova.core.file", "isSandboxed");
./www/blackberry10/resolveLocalFileSystemURI.js:        cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [false]);
./www/blackberry10/resolveLocalFileSystemURI.js:        cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [true]);
./www/blackberry10/resolveLocalFileSystemURI.js:    cordova.exec(null, null, "org.apache.cordova.core.file", "setSandbox", [sandboxState]);
./www/Entry.js:                    var result = (entry.isDirectory) ? new (require('./DirectoryEntry'))(entry.name, entry.fullPath) : new (require('org.apache.cordova.core.file.FileEntry'))(entry.name, entry.fullPath);
./www/Entry.js:                    var result = (entry.isDirectory) ? new (require('./DirectoryEntry'))(entry.name, entry.fullPath) : new (require('org.apache.cordova.core.file.FileEntry'))(entry.name, entry.fullPath);
==== Changed directory to: cordova-plugin-geolocation
==== Changed directory to: cordova-plugin-globalization
==== Changed directory to: cordova-plugin-inappbrowser
./www/windows8/InAppBrowserProxy.js:cordova.define("org.apache.cordova.core.inappbrowser.InAppBrowserProxy", function(require, exports, module) {  /*
==== Changed directory to: cordova-plugin-media
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', "+MEDIA_ERROR+", { \"code\":"+MEDIA_ERR_ABORTED+"});");
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', "+MEDIA_ERROR+", { \"code\":"+MEDIA_ERR_ABORTED+"});");
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', "+MEDIA_ERROR+", { \"code\":"+MEDIA_ERR_ABORTED+"});");
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_POSITION + ", " + milliseconds / 1000.0f + ");");
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_ERROR + ", { \"code\":" + MEDIA_ERR_NONE_ACTIVE + "});");
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_ERROR + ", { \"code\":" + MEDIA_ERR_NONE_ACTIVE + "});");
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_POSITION + ", " + curPos / 1000.0f + ");");
./src/android/AudioPlayer.java:        this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_DURATION + "," + this.duration + ");");
./src/android/AudioPlayer.java:        this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', { \"code\":" + arg1 + "});");
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_STATE + ", " + state.ordinal() + ");");
./src/android/AudioPlayer.java:            //this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_STATE + ", " + mode + ");");
./src/android/AudioPlayer.java:            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_ERROR + ", { \"code\":" + MEDIA_ERR_ABORTED + "});");
./src/android/AudioPlayer.java:                        this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', "+MEDIA_ERROR+", { \"code\":"+MEDIA_ERR_ABORTED+"});");
./src/android/AudioPlayer.java:                            this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_ERROR + ", { \"code\":" + MEDIA_ERR_ABORTED + "});");
./src/android/AudioPlayer.java:                    this.handler.webView.sendJavascript("cordova.require('org.apache.cordova.core.media.Media').onStatus('" + this.id + "', " + MEDIA_ERROR + ", { \"code\":" + MEDIA_ERR_ABORTED + "});");
./src/ios/CDVSound.m:        jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:errcode message:errMsg]];
./src/ios/CDVSound.m:        NSString* jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:MEDIA_ERR_ABORTED message:errorMessage]];
./src/ios/CDVSound.m:                jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%.3f);\n%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_DURATION, position, @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_STATE, MEDIA_RUNNING];
./src/ios/CDVSound.m:            // jsString = [NSString stringWithFormat: @"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR,  MEDIA_ERR_NONE_SUPPORTED];
./src/ios/CDVSound.m:            jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:MEDIA_ERR_NONE_SUPPORTED message:nil]];
./src/ios/CDVSound.m:        jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_STATE, MEDIA_STOPPED];
./src/ios/CDVSound.m:        jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_STATE, MEDIA_PAUSED];
./src/ios/CDVSound.m:            jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%.3f);\n%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_POSITION, 0.0, @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_STATE, MEDIA_STOPPED];
./src/ios/CDVSound.m:            jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%f);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_POSITION, posInSeconds];
./src/ios/CDVSound.m:    NSString* jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%.3f);\n%@", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_POSITION, position, [result toSuccessCallbackString:callbackId]];
./src/ios/CDVSound.m:                    // jsString = [NSString stringWithFormat: @"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, MEDIA_ERR_ABORTED];
./src/ios/CDVSound.m:                    jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:MEDIA_ERR_ABORTED message:errorMsg]];
./src/ios/CDVSound.m:                    jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_STATE, MEDIA_RUNNING];
./src/ios/CDVSound.m:                jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:MEDIA_ERR_ABORTED message:errorMsg]];
./src/ios/CDVSound.m:                    jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:MEDIA_ERR_ABORTED message:msg]];
./src/ios/CDVSound.m:        jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:MEDIA_ERR_ABORTED message:errorMsg]];
./src/ios/CDVSound.m:        jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_STATE, MEDIA_STOPPED];
./src/ios/CDVSound.m:        // jsString = [NSString stringWithFormat: @"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, MEDIA_ERR_DECODE];
./src/ios/CDVSound.m:        jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:MEDIA_ERR_DECODE message:nil]];
./src/ios/CDVSound.m:        jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_STATE, MEDIA_STOPPED];
./src/ios/CDVSound.m:        // jsString = [NSString stringWithFormat: @"%@(\"%@\",%d,%d);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, MEDIA_ERR_DECODE];
./src/ios/CDVSound.m:        jsString = [NSString stringWithFormat:@"%@(\"%@\",%d,%@);", @"cordova.require('org.apache.cordova.core.media.Media').onStatus", mediaId, MEDIA_ERROR, [self createMediaErrorWithCode:MEDIA_ERR_DECODE message:nil]];
./src/windows8/MediaProxy.js:    Media = require('org.apache.cordova.core.AudioHandler.Media');
./src/windows8/MediaProxy.js:var MediaError = require('org.apache.cordova.core.AudioHandler.MediaError');
==== Changed directory to: cordova-plugin-media-capture
./src/windows8/CaptureProxy.js:var MediaFile = require('org.apache.cordova.core.media-capture.MediaFile');
./src/windows8/CaptureProxy.js:var CaptureError = require('org.apache.cordova.core.media-capture.CaptureError');
./src/windows8/CaptureProxy.js:var CaptureAudioOptions = require('org.apache.cordova.core.media-capture.CaptureAudioOptions');
./src/windows8/CaptureProxy.js:var CaptureImageOptions = require('org.apache.cordova.core.media-capture.CaptureImageOptions');
./src/windows8/CaptureProxy.js:var CaptureVideoOptions = require('org.apache.cordova.core.media-capture.CaptureVideoOptions');
./src/windows8/CaptureProxy.js:var MediaFileData = require('org.apache.cordova.core.media-capture.MediaFileData');
./src/windows8/MediaFile.js:var MediaFileData = require('org.apache.cordova.core.media-capture.MediaFileData');
./src/windows8/MediaFile.js:var CaptureError = require('org.apache.cordova.core.media-capture.CaptureError');
./www/MediaFile.js:    File = require('org.apache.cordova.core.file.File'),
==== Changed directory to: cordova-plugin-network-information
==== Changed directory to: cordova-plugin-splashscreen
==== Changed directory to: cordova-plugin-vibration
{quote}
                
> Rename all plugins org.apache.cordova.core.* to org.apache.cordova.*
> --------------------------------------------------------------------
>
>                 Key: CB-4889
>                 URL: https://issues.apache.org/jira/browse/CB-4889
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Battery Status, Plugin Camera, Plugin Console, Plugin Contacts, Plugin Device, Plugin Device Motion, Plugin Device Orientation, Plugin Dialogs, Plugin File, Plugin File Transfer, Plugin Geolocation, Plugin Globalization, Plugin InAppBrowser, Plugin Media, Plugin Media Capture, Plugin Network Information, Plugin SplashScreen, Plugin Vibration
>    Affects Versions: 3.0.0
>            Reporter: Anis Kadri
>            Assignee: Anis Kadri
>             Fix For: 3.1.0
>
>
> Get rid of the 'core' part in the plugin names.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira