You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/20 21:53:05 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request, #17754: [fix][build] Override inherrited build time to now
michaeljmarshall opened a new pull request, #17754:
URL: https://github.com/apache/pulsar/pull/17754
### Motivation
While working on https://github.com/apache/pulsar/pull/17752, I noticed our build time was incorrect. It was set to `2020-01-22T09:10:15-0600`. This timestamp was inherited from the org.apache:apache:23 dependency, as you can see here: https://repo1.maven.org/maven2/org/apache/apache/23/apache-23.pom. Maven uses `project.build.outputTimestamp` for reproducible builds, as documented here: https://maven.apache.org/guides/mini/guide-reproducible-builds.html.
The `git.build.time` we use to the the `PulsarVersion` comes from the `project.build.outputTimestamp` (when set), as documented here: https://github.com/git-commit-id/git-commit-id-maven-plugin/releases/tag/v4.0.2. When the property is null, the plugin uses `new Date()` to get the build time.
https://github.com/git-commit-id/git-commit-id-maven-plugin/blob/80c6740ee268e1a524b2d0b1233801f2ac83881b/core/src/main/java/pl/project13/core/cibuild/BuildServerDataProvider.java#L138
If or when we decide to do reproducible builds, we will need to set this property anyway, so this solution does not prevent us from reproducible builds.
### Modifications
* Set maven property `project.build.outputTimestamp` to an empty value to get more accurate build timestamp.
### Verifying this change
I manually verified that this change enables `PulsarVersion.java` to generate correctly.
### Documentation
- [x] `doc-not-needed`
### Matching PR in forked repository
PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#discussion_r1041542158
##########
pom.xml:
##########
@@ -109,6 +109,9 @@ flexible messaging model and an intuitive client API.</description>
<testRetryCount>1</testRetryCount>
<testJacocoAgentArgument/>
<testHeapDumpPath>/tmp</testHeapDumpPath>
+ <!-- This property is used to generate reproducible builds. We do not use it, but we do not want to inherit
+ this time property from dependencies. By setting it to null, we get "now" as the build time. -->
+ <project.build.outputTimestamp></project.build.outputTimestamp>
Review Comment:
It seems force the timestamp to a past time is less than awesome, although the property can be updated on release.
Another possible cause is that we don't update the property in `buildtools` also, as well as we have some plugins that conflict with reproducible build (detected by `mvn artifact:check-buildplan `.
I'll debug on https://github.com/tisonkun/pulsar/pull/21 to find a good way while SQL tests keep failing on this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1343903316
Superseded by https://github.com/apache/pulsar/pull/18820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1339633923
It seems we're now always fail to star the container:
<details>
<summary>Logs:</summary>
<pre>
2022-12-06T14:41:44.7029477Z 2022-12-06T14:41:44,702 - INFO - [docker-java-stream--1991487674:DockerUtils$4@383] - DOCKER.exec(pulsar-sql-test-pulsar-broker-0:tail -f /var/log/pulsar/broker.log): STDOUT: 2022-12-06T14:41:43,954+0000 [pulsar-load-manager-1-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Writing local data to metadata store because maximum change 14.196531474590302% exceeded threshold 10%; time since last report written is 55.088 seconds
2022-12-06T14:41:44.7031040Z 2022-12-06T14:41:43,984+0000 [main-EventThread] INFO org.apache.pulsar.metadata.coordination.impl.ResourceLockImpl - Acquired resource lock on /loadbalance/brokers/pulsar-broker-0:8080
2022-12-06T14:41:49.7035404Z 2022-12-06T14:41:49,702 - INFO - [docker-java-stream--1991487674:DockerUtils$4@383] - DOCKER.exec(pulsar-sql-test-pulsar-broker-0:tail -f /var/log/pulsar/broker.log): STDOUT: 2022-12-06T14:41:48,736+0000 [pulsar-load-manager-1-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Only 1 broker available: no load shedding will be performed
2022-12-06T14:42:44.7095422Z 2022-12-06T14:42:44,708 - INFO - [docker-java-stream--1991487674:DockerUtils$4@383] - DOCKER.exec(pulsar-sql-test-pulsar-broker-0:tail -f /var/log/pulsar/broker.log): STDOUT: 2022-12-06T14:42:43,954+0000 [pulsar-load-manager-1-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Writing local data to metadata store because maximum change 11.071531474590302% exceeded threshold 10%; time since last report written is 59.999 seconds
2022-12-06T14:42:44.7097363Z 2022-12-06T14:42:43,964+0000 [main-EventThread] INFO org.apache.pulsar.metadata.coordination.impl.ResourceLockImpl - Acquired resource lock on /loadbalance/brokers/pulsar-broker-0:8080
2022-12-06T14:42:49.7099579Z 2022-12-06T14:42:49,709 - INFO - [docker-java-stream--1991487674:DockerUtils$4@383] - DOCKER.exec(pulsar-sql-test-pulsar-broker-0:tail -f /var/log/pulsar/broker.log): STDOUT: 2022-12-06T14:42:48,736+0000 [pulsar-load-manager-1-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Only 1 broker available: no load shedding will be performed
2022-12-06T14:43:49.7173597Z 2022-12-06T14:43:49,716 - INFO - [docker-java-stream--1991487674:DockerUtils$4@383] - DOCKER.exec(pulsar-sql-test-pulsar-broker-0:tail -f /var/log/pulsar/broker.log): STDOUT: 2022-12-06T14:43:48,737+0000 [pulsar-load-manager-1-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Only 1 broker available: no load shedding will be performed
2022-12-06T14:44:49.7234512Z 2022-12-06T14:44:49,722 - INFO - [docker-java-stream--1991487674:DockerUtils$4@383] - DOCKER.exec(pulsar-sql-test-pulsar-broker-0:tail -f /var/log/pulsar/broker.log): STDOUT: 2022-12-06T14:44:48,737+0000 [pulsar-load-manager-1-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Only 1 broker available: no load shedding will be performed
2022-12-06T14:45:49.7295766Z 2022-12-06T14:45:49,728 - INFO - [docker-java-stream--1991487674:DockerUtils$4@383] - DOCKER.exec(pulsar-sql-test-pulsar-broker-0:tail -f /var/log/pulsar/broker.log): STDOUT: 2022-12-06T14:45:48,738+0000 [pulsar-load-manager-1-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Only 1 broker available: no load shedding will be performed
2022-12-06T14:45:55.2496634Z 2022-12-06T14:45:55,248 - ERROR - [main:GenericContainer@529] - Could not start container
2022-12-06T14:45:55.2497644Z org.testcontainers.containers.ContainerLaunchException: Timed out waiting for URL to be accessible (http://localhost:49179/v1/info/state should return HTTP [200])
2022-12-06T14:45:55.2593061Z at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.waitUntilReady(HttpWaitStrategy.java:318) ~[testcontainers-1.17.6.jar:1.17.6]
2022-12-06T14:45:55.2596482Z at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52) ~[testcontainers-1.17.6.jar:1.17.6]
2022-12-06T14:45:55.2597468Z at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:953) ~[testcontainers-1.17.6.jar:1.17.6]
2022-12-06T14:45:55.2598324Z at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485) ~[testcontainers-1.17.6.jar:1.17.6]
2022-12-06T14:45:55.2599115Z at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344) ~[testcontainers-1.17.6.jar:1.17.6]
2022-12-06T14:45:55.2599886Z at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) ~[duct-tape-1.0.8.jar:?]
2022-12-06T14:45:55.2600660Z at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334) ~[testcontainers-1.17.6.jar:1.17.6]
2022-12-06T14:45:55.2601421Z at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322) ~[testcontainers-1.17.6.jar:1.17.6]
2022-12-06T14:45:55.2602196Z at org.apache.pulsar.tests.integration.containers.PulsarContainer.start(PulsarContainer.java:209) ~[test-classes/:?]
2022-12-06T14:45:55.2603059Z at org.apache.pulsar.tests.integration.topologies.PulsarCluster.startPrestoWorker(PulsarCluster.java:420) ~[test-classes/:?]
2022-12-06T14:45:55.2603949Z at org.apache.pulsar.tests.integration.topologies.PulsarCluster.startPrestoWorker(PulsarCluster.java:411) ~[test-classes/:?]
2022-12-06T14:45:55.2604813Z at org.apache.pulsar.tests.integration.presto.TestBasicPresto.setupPresto(TestBasicPresto.java:58) ~[test-classes/:?]
2022-12-06T14:45:55.2605645Z at org.apache.pulsar.tests.integration.presto.TestBasicPresto.setupCluster(TestBasicPresto.java:70) ~[test-classes/:?]
2022-12-06T14:45:55.2606530Z at org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase.setup(PulsarClusterTestBase.java:42) ~[test-classes/:?]
2022-12-06T14:45:55.2607633Z at org.apache.pulsar.tests.TestRetrySupport.stateCheck(TestRetrySupport.java:60) ~[buildtools-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
2022-12-06T14:45:55.2608225Z at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
2022-12-06T14:45:55.2608796Z at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
2022-12-06T14:45:55.2609398Z at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
2022-12-06T14:45:55.2609897Z at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
2022-12-06T14:45:55.2610582Z at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2611514Z at org.testng.internal.invokers.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:69) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2612540Z at org.testng.internal.invokers.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:361) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2613464Z at org.testng.internal.invokers.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:296) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2614202Z at org.testng.internal.invokers.TestInvoker.runConfigMethods(TestInvoker.java:816) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2614874Z at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:590) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2615566Z at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:221) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2616265Z at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2616970Z at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:962) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2617679Z at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:194) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2618434Z at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:148) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2619147Z at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2619608Z at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?]
2022-12-06T14:45:55.2620090Z at org.testng.TestRunner.privateRun(TestRunner.java:806) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2620596Z at org.testng.TestRunner.run(TestRunner.java:601) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2621100Z at org.testng.SuiteRunner.runTest(SuiteRunner.java:433) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2621655Z at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:427) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2622209Z at org.testng.SuiteRunner.privateRun(SuiteRunner.java:387) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2622719Z at org.testng.SuiteRunner.run(SuiteRunner.java:330) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2623255Z at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2623831Z at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2624394Z at org.testng.TestNG.runSuitesSequentially(TestNG.java:1256) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2624930Z at org.testng.TestNG.runSuitesLocally(TestNG.java:1176) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2625427Z at org.testng.TestNG.runSuites(TestNG.java:1099) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2625999Z at org.testng.TestNG.run(TestNG.java:1067) ~[testng-7.6.1.jar:7.6.1]
2022-12-06T14:45:55.2626634Z at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:283) ~[surefire-testng-3.0.0-M3.jar:3.0.0-M3]
2022-12-06T14:45:55.2627586Z at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:75) ~[surefire-testng-3.0.0-M3.jar:3.0.0-M3]
2022-12-06T14:45:55.2628404Z at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:120) ~[surefire-testng-3.0.0-M3.jar:3.0.0-M3]
2022-12-06T14:45:55.2629289Z at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) ~[surefire-booter-3.0.0-M3.jar:3.0.0-M3]
2022-12-06T14:45:55.2630190Z at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) ~[surefire-booter-3.0.0-M3.jar:3.0.0-M3]
2022-12-06T14:45:55.2630980Z at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) ~[surefire-booter-3.0.0-M3.jar:3.0.0-M3]
2022-12-06T14:45:55.2631718Z at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) ~[surefire-booter-3.0.0-M3.jar:3.0.0-M3]
2022-12-06T14:45:55.2813355Z 2022-12-06T14:45:55,280 - ERROR - [main:GenericContainer@536] - Log output from the failed container:
</pre>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#discussion_r1044132155
##########
pom.xml:
##########
@@ -109,6 +109,9 @@ flexible messaging model and an intuitive client API.</description>
<testRetryCount>1</testRetryCount>
<testJacocoAgentArgument/>
<testHeapDumpPath>/tmp</testHeapDumpPath>
+ <!-- This property is used to generate reproducible builds. We do not use it, but we do not want to inherit
+ this time property from dependencies. By setting it to null, we get "now" as the build time. -->
+ <project.build.outputTimestamp></project.build.outputTimestamp>
Review Comment:
Thank you for debugging this! I should have looked closer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1339625140
It seems that SQL system tests should be completed normally in 15 minutes. But...how can this patch make those tests so costly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1279349041
CI is really flaky right now. This change is trivial, and I still haven't gotten tests to pass once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #17754: [fix][build] Override inherrited build time to now
URL: https://github.com/apache/pulsar/pull/17754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1253142298
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1261754163
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #17754: [fix][build] Override inherrited build time to now
URL: https://github.com/apache/pulsar/pull/17754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1276989174
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1275234468
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/17754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@c8b7962`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17754 +/- ##
=========================================
Coverage ? 34.83%
Complexity ? 4464
=========================================
Files ? 393
Lines ? 43419
Branches ? 4462
=========================================
Hits ? 15127
Misses ? 26106
Partials ? 2186
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `34.83% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1253983570
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#discussion_r1041521017
##########
pom.xml:
##########
@@ -109,6 +109,9 @@ flexible messaging model and an intuitive client API.</description>
<testRetryCount>1</testRetryCount>
<testJacocoAgentArgument/>
<testHeapDumpPath>/tmp</testHeapDumpPath>
+ <!-- This property is used to generate reproducible builds. We do not use it, but we do not want to inherit
+ this time property from dependencies. By setting it to null, we get "now" as the build time. -->
+ <project.build.outputTimestamp></project.build.outputTimestamp>
Review Comment:
```suggestion
<project.build.outputTimestamp>10</project.build.outputTimestamp>
```
https://github.com/tisonkun/pulsar/pull/21 It seems this change can make the SQL tests passed now.
The config is copied from https://maven.apache.org/guides/mini/guide-reproducible-builds.html.
I'm trying locally to see if the timestamp is correctly resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1340320022
@michaeljmarshall I think this patch is a fix to the current failure and works well https://github.com/tisonkun/pulsar/pull/21.
You can make use of it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #17754: [fix][build] Override inherrited build time to now
URL: https://github.com/apache/pulsar/pull/17754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1275593385
Rebased to see if that helps with flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #17754: [fix][build] Override inherrited build time to now
URL: https://github.com/apache/pulsar/pull/17754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#issuecomment-1281766534
The sql step is failing with the following error:
```
2022-10-17T22:09:52,280 - INFO - [docker-java-stream-913315710:DockerUtils$4@383] - DOCKER.exec(pulsar-sql-test-pulsar-broker-0:tail -f /var/log/pulsar/broker.log): STDOUT: 2022-10-17T22:09:51,968+0000 [pulsar-load-manager-1-1] INFO org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Only 1 broker available: no load shedding will be performed
2022-10-17T22:10:01,090 - ERROR - [main:GenericContainer@524] - Could not start container
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for URL to be accessible (http://localhost:49162/v1/info/state should return HTTP [200])
at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.waitUntilReady(HttpWaitStrategy.java:286) ~[testcontainers-1.17.2.jar:?]
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:51) ~[testcontainers-1.17.2.jar:?]
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:926) ~[testcontainers-1.17.2.jar:?]
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:480) ~[testcontainers-1.17.2.jar:?]
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:340) ~[testcontainers-1.17.2.jar:?]
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) ~[duct-tape-1.0.8.jar:?]
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:338) ~[testcontainers-1.17.2.jar:?]
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:326) ~[testcontainers-1.17.2.jar:?]
at org.apache.pulsar.tests.integration.containers.PulsarContainer.start(PulsarContainer.java:182) ~[test-classes/:?]
at org.apache.pulsar.tests.integration.topologies.PulsarCluster.startPrestoWorker(PulsarCluster.java:393) ~[test-classes/:?]
at org.apache.pulsar.tests.integration.topologies.PulsarCluster.startPrestoWorker(PulsarCluster.java:384) ~[test-classes/:?]
at org.apache.pulsar.tests.integration.presto.TestBasicPresto.setupPresto(TestBasicPresto.java:58) ~[test-classes/:?]
at org.apache.pulsar.tests.integration.presto.TestBasicPresto.setupCluster(TestBasicPresto.java:70) ~[test-classes/:?]
at org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase.setup(PulsarClusterTestBase.java:42) ~[test-classes/:?]
at org.apache.pulsar.tests.integration.suites.PulsarTestSuite.setupBeforeClass(PulsarTestSuite.java:30) ~[test-classes/:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) ~[testng-7.3.0.jar:?]
at org.testng.internal.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:61) ~[testng-7.3.0.jar:?]
at org.testng.internal.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:366) ~[testng-7.3.0.jar:?]
at org.testng.internal.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:320) ~[testng-7.3.0.jar:?]
at org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:176) ~[testng-7.3.0.jar:?]
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:122) ~[testng-7.3.0.jar:?]
at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?]
at org.testng.TestRunner.privateRun(TestRunner.java:764) ~[testng-7.3.0.jar:?]
at org.testng.TestRunner.run(TestRunner.java:585) ~[testng-7.3.0.jar:?]
at org.testng.SuiteRunner.runTest(SuiteRunner.java:384) ~[testng-7.3.0.jar:?]
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378) ~[testng-7.3.0.jar:?]
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337) ~[testng-7.3.0.jar:?]
at org.testng.SuiteRunner.run(SuiteRunner.java:286) ~[testng-7.3.0.jar:?]
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) ~[testng-7.3.0.jar:?]
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96) ~[testng-7.3.0.jar:?]
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218) ~[testng-7.3.0.jar:?]
at org.testng.TestNG.runSuitesLocally(TestNG.java:1140) ~[testng-7.3.0.jar:?]
at org.testng.TestNG.runSuites(TestNG.java:1069) ~[testng-7.3.0.jar:?]
at org.testng.TestNG.run(TestNG.java:1037) ~[testng-7.3.0.jar:?]
at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:283) ~[surefire-testng-3.0.0-M3.jar:3.0.0-M3]
at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:75) ~[surefire-testng-3.0.0-M3.jar:3.0.0-M3]
at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:120) ~[surefire-testng-3.0.0-M3.jar:3.0.0-M3]
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) ~[surefire-booter-3.0.0-M3.jar:3.0.0-M3]
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) ~[surefire-booter-3.0.0-M3.jar:3.0.0-M3]
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) ~[surefire-booter-3.0.0-M3.jar:3.0.0-M3]
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) ~[surefire-booter-3.0.0-M3.jar:3.0.0-M3]
2022-10-17T22:10:01,124 - ERROR - [main:GenericContainer@531] - Log output from the failed container:
[trino/conf/catalog/pulsar.properties] Applying config pulsar.bookkeeper-explicit-interval = 10
[trino/conf/catalog/pulsar.properties] Applying config pulsar.bookkeeper-use-v2-protocol = false
[trino/conf/catalog/pulsar.properties] Applying config pulsar.web-service-url = http://pulsar-broker-0:8080
[trino/conf/catalog/pulsar.properties] Applying config pulsar.zookeeper-uri = zookeeper:2181
[trino/conf/catalog/pulsar.properties] Adding config pulsar.max-message-size = 10485760
2022-10-17 22:05:01,446 CRIT Supervisor is running as root. Privileges were not dropped because no user is specified in the config file. If you intend to run as root, you can set user=root in the config file to avoid this message.
2022-10-17 22:05:01,448 INFO Included extra file "/etc/supervisord/conf.d/bookie.conf" during parsing
2022-10-17 22:05:01,448 INFO Included extra file "/etc/supervisord/conf.d/broker.conf" during parsing
2022-10-17 22:05:01,448 INFO Included extra file "/etc/supervisord/conf.d/functions_worker.conf" during parsing
2022-10-17 22:05:01,448 INFO Included extra file "/etc/supervisord/conf.d/global-zk.conf" during parsing
2022-10-17 22:05:01,448 INFO Included extra file "/etc/supervisord/conf.d/local-zk.conf" during parsing
2022-10-17 22:05:01,448 INFO Included extra file "/etc/supervisord/conf.d/presto_worker.conf" during parsing
2022-10-17 22:05:01,448 INFO Included extra file "/etc/supervisord/conf.d/proxy.conf" during parsing
2022-10-17 22:05:01,448 INFO Included extra file "/etc/supervisord/conf.d/websocket.conf" during parsing
2022-10-17 22:05:01,455 INFO RPC interface 'supervisor' initialized
2022-10-17 22:05:01,455 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2022-10-17 22:05:01,456 INFO supervisord started with pid 1
2022-10-17 22:05:02,459 INFO spawned: 'presto-worker' with pid 17
2022-10-17 22:05:02,673 INFO exited: presto-worker (exit status 4; not expected)
2022-10-17 22:05:03,676 INFO spawned: 'presto-worker' with pid 93
2022-10-17 22:05:03,886 INFO exited: presto-worker (exit status 4; not expected)
2022-10-17 22:05:05,890 INFO spawned: 'presto-worker' with pid 169
2022-10-17 22:05:06,098 INFO exited: presto-worker (exit status 4; not expected)
2022-10-17 22:05:09,105 INFO spawned: 'presto-worker' with pid 245
2022-10-17 22:05:09,308 INFO exited: presto-worker (exit status 4; not expected)
2022-10-17 22:05:10,310 INFO gave up: presto-worker entered FATAL state, too many start retries too quickly
```
@lhotari - have you seen this exit status 4 before? It seems like it would be a flaky issue, but I seem to be consistently failing at the sql job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #17754: [fix][build] Override inherrited build time to now
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #17754: [fix][build] Override inherrited build time to now
URL: https://github.com/apache/pulsar/pull/17754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org