You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/30 16:31:00 UTC
[jira] [Commented] (SAMZA-1693) Samza-sql: Adding Serde for rel
record
[ https://issues.apache.org/jira/browse/SAMZA-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458727#comment-16458727 ]
ASF GitHub Bot commented on SAMZA-1693:
---------------------------------------
GitHub user atoomula opened a pull request:
https://github.com/apache/samza/pull/495
SAMZA-1693: Samza-sql - Adding Serde for rel record and few other minor fixes for Avro and Rel conversion.
Adding Serde for rel record, as calcite expects the keys to be in string format. Rel converters are always expected to provide keys as strings. If key is an avro record, it is expected that the rel converter changes the avro record to rel record and serializes it and deserializes it when conerting rel message to samza message.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/atoomula/samza rel1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #495
----
commit deb5cad77e6a4e7d8634825e56f69d3b9a4bb5a4
Author: Aditya Toomula <at...@...>
Date: 2018-04-30T16:25:48Z
Adding Serde for rel record as well as keys could be avro records but calcite expects the keys to be in string format. Rel converters are always expected to provide keys as strings. If key is an avro record, it is expected that the rel converter changes the avro record to rel record and serializes it and deserializes it when conerting rel message to samza message.
----
> Samza-sql: Adding Serde for rel record
> --------------------------------------
>
> Key: SAMZA-1693
> URL: https://issues.apache.org/jira/browse/SAMZA-1693
> Project: Samza
> Issue Type: Bug
> Reporter: Aditya
> Assignee: Aditya
> Priority: Major
>
> Adding Serde for rel record, as calcite expects the keys to be in string format. Rel converters are always expected to provide keys as strings. If key is an avro record, it is expected that the rel converter changes the avro record to rel record and serializes it and deserializes it when conerting rel message to samza message.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)