You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/06 00:34:39 UTC

[GitHub] [superset] graceguo-supercat opened a new issue #16099: [pivot table] conditional formatting: color value

graceguo-supercat opened a new issue #16099:
URL: https://github.com/apache/superset/issues/16099


   Thank you @villebro implements pivot_table_v2 chart, help our users migrate from old params to the new params and UI controls.
   
   But there is a little difference between the old and new charts:
   
   Before:
   ![pivot_heatmat_before-2](https://user-images.githubusercontent.com/27990562/128437926-b8a59932-24ee-43de-8c87-feaafd5b9aa9.jpg)
   
   After:
   ![pivot_heatmap_after](https://user-images.githubusercontent.com/27990562/128437998-71bcc875-a62f-4d55-931a-911dc999b474.jpg)
   
   You will see that in the old chart, color's value seems ranges from in value to max value. So that cell with min value is white, cell with max value is the darkest.
   But in the new chart, red color seems range from 0? this cause not much visual difference between min value and max value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje closed issue #16099: [pivot table] conditional formatting: color value

Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #16099:
URL: https://github.com/apache/superset/issues/16099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje commented on issue #16099: [pivot table] conditional formatting: color value

Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16099:
URL: https://github.com/apache/superset/issues/16099#issuecomment-895335576


   @graceguo-supercat Done in https://github.com/apache-superset/superset-ui/pull/1284. Would you like to test it?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on issue #16099: [pivot table] conditional formatting: color value

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #16099:
URL: https://github.com/apache/superset/issues/16099#issuecomment-894080445


   Good point @graceguo-supercat - I agree we should increase the contrast to make it more in line with the previous behavior. Will follow-up with a PR shortly.
   
   Ping @kgabryje


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org