[GitHub] [solr] risdenk commented on pull request #604: SOLR-15984: Ensure all used dependencies are declared

[GitBox <gi...@apache.org>]

risdenk commented on pull request #604:
URL: https://github.com/apache/solr/pull/604#issuecomment-1031728692


   I spot checked all these changes and for each case I was able to find classes that imported from these jars so the dependencies were missing. This runs during `./gradlew check` so it will ensure we don't run into issues in the future. I checked that this didn't add any new dependencies in versions.lock and the only changes were adding a few more "constraints" for versions.
   
   I did not address any "unused but declared" warnings that popped up. Those are much harder to address and might be needed during runtime. 
   
   I did address one weird dependency that was easy - jetty-servlet in LTR module - wasn't needed. I have a few other ideas to clean up some of these dependencies, but will do that follow on.
   
   @dsmiley - appreciate you looking at this since you last did some cleanup of dependencies.
   @madrob - appreciate if you looked at this since you suggested this gradle plugin after we briefly discussed it on Slack
   
   I'd also like a review of how this plugs into the gradle build. I think I did it just like the other plugins like Forbiddenapis, but not sure its the "right" way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org