You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "ailintom (via GitHub)" <gi...@apache.org> on 2023/05/13 10:40:28 UTC
[GitHub] [jena] ailintom opened a new pull request, #1866: Rephrase error message in SPARQL_Update.java
ailintom opened a new pull request, #1866:
URL: https://github.com/apache/jena/pull/1866
The original error message is not quite comprehensible and suggests HTTP PATCH method which is not really used
GitHub issue resolved #
Pull request Description:
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [ ] Commits have been squashed to remove intermediate development commit messages.
- [ ] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #1866:
URL: https://github.com/apache/jena/pull/1866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] ailintom commented on a diff in pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "ailintom (via GitHub)" <gi...@apache.org>.
ailintom commented on code in PR #1866:
URL: https://github.com/apache/jena/pull/1866#discussion_r1193117608
##########
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java:
##########
@@ -83,7 +83,7 @@ public void execOptions(HttpAction action) {
@Override
public void execGet(HttpAction action) {
- ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "GET not support for SPARQL Update. Use POST or PATCH");
+ ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "SPARQL Update is not supported with GET. Use POST instead");
Review Comment:
When I am trying to update my instance of Fuseki 4.8.0 with PATCH, I am getting the following error: "HTTP method not allowed: SPARQL Update : use POST" triggered by https://github.com/apache/jena/blob/f540f6df8b5492e5f052a1679d6e46b95fce744f/jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java#L128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1866:
URL: https://github.com/apache/jena/pull/1866#discussion_r1193160854
##########
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java:
##########
@@ -83,7 +83,7 @@ public void execOptions(HttpAction action) {
@Override
public void execGet(HttpAction action) {
- ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "GET not support for SPARQL Update. Use POST or PATCH");
+ ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "SPARQL Update is not supported with GET. Use POST instead");
Review Comment:
Oh. Then that's a bug because further up it does allow PATCH!
https://github.com/apache/jena/blob/ba2cdb6211f60d7725d779a8556266a8c0b2d0c5/jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java#L80
https://github.com/apache/jena/blob/ba2cdb6211f60d7725d779a8556266a8c0b2d0c5/jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java#L95
Could you add the fix to the PR please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] ailintom commented on pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "ailintom (via GitHub)" <gi...@apache.org>.
ailintom commented on PR #1866:
URL: https://github.com/apache/jena/pull/1866#issuecomment-1546948880
I hope I did what you excepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #1866:
URL: https://github.com/apache/jena/pull/1866#issuecomment-1546853252
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] ailintom commented on a diff in pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "ailintom (via GitHub)" <gi...@apache.org>.
ailintom commented on code in PR #1866:
URL: https://github.com/apache/jena/pull/1866#discussion_r1193117608
##########
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java:
##########
@@ -83,7 +83,7 @@ public void execOptions(HttpAction action) {
@Override
public void execGet(HttpAction action) {
- ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "GET not support for SPARQL Update. Use POST or PATCH");
+ ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "SPARQL Update is not supported with GET. Use POST instead");
Review Comment:
@afs
When I am trying to update my instance of Fuseki 4.8.0 with PATCH, I am getting the following error: "HTTP method not allowed: SPARQL Update : use POST" triggered by https://github.com/apache/jena/blob/f540f6df8b5492e5f052a1679d6e46b95fce744f/jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java#L128
Thus, as I understand PATCH is currently explicitly not supported, unless the following condition is altered
https://github.com/apache/jena/blob/f540f6df8b5492e5f052a1679d6e46b95fce744f/jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java#L127
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #1866:
URL: https://github.com/apache/jena/pull/1866#issuecomment-1555861965
Tooks good! Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1866:
URL: https://github.com/apache/jena/pull/1866#discussion_r1193109527
##########
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java:
##########
@@ -83,7 +83,7 @@ public void execOptions(HttpAction action) {
@Override
public void execGet(HttpAction action) {
- ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "GET not support for SPARQL Update. Use POST or PATCH");
+ ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "SPARQL Update is not supported with GET. Use POST instead");
Review Comment:
```suggestion
ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "SPARQL Update is not supported with GET. Use POST or PATCH instead");
```
I think it's better to leave mention of PATCH in. It is supported.
Yes, the general uptake of PATCH on the web does not seem huge, which is a pity; it was "only" standardised [March 2010](https://datatracker.ietf.org/doc/html/rfc5789).
PATCH is a good match for SPARQL Update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] ailintom commented on a diff in pull request #1866: Rephrase error message in SPARQL_Update.java
Posted by "ailintom (via GitHub)" <gi...@apache.org>.
ailintom commented on code in PR #1866:
URL: https://github.com/apache/jena/pull/1866#discussion_r1193117608
##########
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java:
##########
@@ -83,7 +83,7 @@ public void execOptions(HttpAction action) {
@Override
public void execGet(HttpAction action) {
- ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "GET not support for SPARQL Update. Use POST or PATCH");
+ ServletOps.errorMethodNotAllowed(HttpNames.METHOD_GET, "SPARQL Update is not supported with GET. Use POST instead");
Review Comment:
@afs
When I am trying to update my instance of Fuseki 4.8.0 with PATCH, I am getting the following error: "HTTP method not allowed: SPARQL Update : use POST" triggered by https://github.com/apache/jena/blob/f540f6df8b5492e5f052a1679d6e46b95fce744f/jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java#L128
Thus, as I understand PATCH is currently explicitly not supported, unless the following condition is altered
https://github.com/apache/jena/blob/f540f6df8b5492e5f052a1679d6e46b95fce744f/jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java#LL127C14-L127C82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org