You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/26 06:32:22 UTC
[GitHub] [airflow] mik-laj opened a new pull request #9530: Auto detect static-checks for breeze autocomplete
mik-laj opened a new pull request #9530:
URL: https://github.com/apache/airflow/pull/9530
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed pull request #9530: Auto detect static-checks for breeze autocomplete
Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #9530:
URL: https://github.com/apache/airflow/pull/9530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9530: Auto detect static-checks for breeze autocomplete
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9530:
URL: https://github.com/apache/airflow/pull/9530#discussion_r446064265
##########
File path: breeze-complete
##########
@@ -44,49 +44,7 @@ EOF
_BREEZE_ALLOWED_STATIC_CHECKS=$(cat <<-EOF
all
all-but-pylint
-airflow-config-yaml
-base-operator
-bat-tests
-build
-build-providers-dependencies
-check-apache-license
-check-executables-have-shebangs
-check-hooks-apply
-check-integrations
-check-merge-conflict
-check-xml
-consistent-pylint
-daysago-import-check
-debug-statements
-detect-private-key
-doctoc
-end-of-file-fixer
-fix-encoding-pragma
-flake8
-forbid-tabs
-incorrect-use-of-LoggingMixin
-insert-license
-isort
-language-matters
-lint-dockerfile
-mixed-line-ending
-mypy
-provide-create-sessions
-pydevd
-pydocstyle
-pylint
-pylint-tests
-python-no-log-warn
-rst-backticks
-setup-order
-shellcheck
-stylelint
-trailing-whitespace
-update-breeze-file
-update-extras
-update-local-yml-file
-update-setup-cfg-file
-yamllint
+$(grep -E "id *:" .pre-commit-config.yaml | cut -d ":" -f 2 | sed "s/^ //" | sort | uniq)
Review comment:
You never know which directory you are in when you source .breeze-complete so this one will not always work. ./breeze-complete should be fully standalone and should not include nor parse any other data.
I think this should be a pre-commit to update those values rather than grep run every time you source it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9530: Auto detect static-checks for breeze autocomplete
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9530:
URL: https://github.com/apache/airflow/pull/9530#discussion_r446064265
##########
File path: breeze-complete
##########
@@ -44,49 +44,7 @@ EOF
_BREEZE_ALLOWED_STATIC_CHECKS=$(cat <<-EOF
all
all-but-pylint
-airflow-config-yaml
-base-operator
-bat-tests
-build
-build-providers-dependencies
-check-apache-license
-check-executables-have-shebangs
-check-hooks-apply
-check-integrations
-check-merge-conflict
-check-xml
-consistent-pylint
-daysago-import-check
-debug-statements
-detect-private-key
-doctoc
-end-of-file-fixer
-fix-encoding-pragma
-flake8
-forbid-tabs
-incorrect-use-of-LoggingMixin
-insert-license
-isort
-language-matters
-lint-dockerfile
-mixed-line-ending
-mypy
-provide-create-sessions
-pydevd
-pydocstyle
-pylint
-pylint-tests
-python-no-log-warn
-rst-backticks
-setup-order
-shellcheck
-stylelint
-trailing-whitespace
-update-breeze-file
-update-extras
-update-local-yml-file
-update-setup-cfg-file
-yamllint
+$(grep -E "id *:" .pre-commit-config.yaml | cut -d ":" -f 2 | sed "s/^ //" | sort | uniq)
Review comment:
You never know which directory you are in when you source breeze-complete (if you do it in .bash_rc it might be from ${HOME_DIR} for example so this one will not always work. ./breeze-complete should be fully standalone and should not include nor parse any other data.
I think this should be a pre-commit to update those values rather than grep run every time you source it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9530: Auto detect static-checks for breeze autocomplete
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9530:
URL: https://github.com/apache/airflow/pull/9530#issuecomment-674444166
@potiuk would you like to take it over?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9530: Auto detect static-checks for breeze autocomplete
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9530:
URL: https://github.com/apache/airflow/pull/9530#issuecomment-674443855
Shall we fix it @mik-laj ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9530: Auto detect static-checks for breeze autocomplete
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9530:
URL: https://github.com/apache/airflow/pull/9530#issuecomment-674444103
I personally do not have time to complete this PR. This change turned out to be bigger than I originally thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9530: Auto detect static-checks for breeze autocomplete
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9530:
URL: https://github.com/apache/airflow/pull/9530#issuecomment-674445331
I have an issue in it.opene for like 4 months :) in the pre-commit :). I think maybe one day when bored I come back to it :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #9530: Auto detect static-checks for breeze autocomplete
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9530:
URL: https://github.com/apache/airflow/pull/9530#issuecomment-674344277
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org