[GitHub] [incubator-mxnet] KellenSunderland edited a comment on issue #12328: [MXNET-857] Add initial NVTX profiler implementation

[GitBox <gi...@apache.org>]

KellenSunderland edited a comment on issue #12328: [MXNET-857] Add initial NVTX profiler implementation
URL: https://github.com/apache/incubator-mxnet/pull/12328#issuecomment-484688554
 
 
   Still making progress on this.  I believe the last TODO is either use static linking or to make sure the nvExt library is copied to the lib path for testing on windows.  It's probably best for the customer to use static linking, so I'll try to implement that.
   
   Edit: I think windows support is going to be problematic.  If we reference NVTX in Windows by default NVIDIA recommends shipping a the dll with the application:
   
   ```
   5.4	Deploying NVTX
   The NVTX .dll is not installed into c:\Windows\System32 or another global location. Instead, make sure to deploy the .dll with your application. 
   
   Ref: https://docs.nvidia.com/gameworks/content/developertools/desktop/nsight/nvtx_library.htm
   ```
   
   I think this would be more effort than it's worth for 99% of our Windows users.  On Linux the library is installed and on the path for everyone with Cuda installed, so I don't have concerns turning NVTX on by default for profiling on that platform.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services