You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "kz930 (via GitHub)" <gi...@apache.org> on 2026/08/01 03:23:23 UTC
[I] ContourPlot's Grid Size is optional but crashes the operator unless it holds an integer literal [texera]
kz930 opened a new issue, #7212:
URL: https://github.com/apache/texera/issues/7212
### What happened?
- `gridSize` is an `EncodableString` consumed as `grid_size = int(<value>)`, with no guard around it.
- Its generated schema is `{"propertyOrder":4,"nullable":true,"type":"string","default":"10","description":"Grid resolution of the final image","title":"Grid Size"}`, and the property is absent from the schema's `required` list. So the form presents optional free text, and because the declared type is `string` the form cannot constrain it to an integer.
Executing the generated module against a six-row frame:
| Grid Size | result |
| --- | --- |
| `10` | chart renders |
| empty — the field is optional, so clearing it is legal | **`ValueError: invalid literal for int() with base 10: ''`** |
| `abc` | **`ValueError: ... 'abc'`** |
| `2.5` | **`ValueError: ... '2.5'`** — `int()` rejects a decimal string |
The only input the operator accepts is an integer literal, while its metadata promises an optional string. The empty case is the sharpest: the form says the field may be left blank, and leaving it blank aborts the run.
Worth noting for contrast: `GaugeChartOpDesc` and `BulletChartOpDesc` model the same kind of numeric knob as a string but do guard emptiness — `float(x) if x.strip() else None` — so they survive a cleared field. ContourPlot has no such guard, which suggests an omission rather than a decision.
Expected: either the value is constrained before the run (a numeric property, or a schema constraint the form can enforce), or empty and non-numeric values fall back to the documented default of `10` rather than aborting.
### How to reproduce?
1. Chain a source carrying three numeric columns into Contour Plot and set X, Y and Z.
2. Clear Grid Size — or type `2.5` — and run.
3. The operator fails with the error below. `10` in the same field succeeds.
### Version/Branch
1.3.0-incubating-SNAPSHOT (main)
### Relevant log output
```shell
ValueError: invalid literal for int() with base 10: ''
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ContourPlot's Grid Size is optional but crashes the operator unless it holds an integer literal [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #7212: ContourPlot's Grid Size is optional but crashes the operator unless it holds an integer literal
URL: https://github.com/apache/texera/issues/7212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ContourPlot's Grid Size is optional but crashes the operator unless it holds an integer literal [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on issue #7212:
URL: https://github.com/apache/texera/issues/7212#issuecomment-5156434682
/take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ContourPlot's Grid Size is optional but crashes the operator unless it holds an integer literal [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on issue #7212:
URL: https://github.com/apache/texera/issues/7212#issuecomment-5160558213
The Grid Size case here is fixed by #7233, which makes the field an `Option[Int]` and falls back to the documented default of `10` — so both a cleared field and `2.5` behave rather than abort. Leaving this open until that merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ContourPlot's Grid Size is optional but crashes the operator unless it holds an integer literal [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on issue #7212:
URL: https://github.com/apache/texera/issues/7212#issuecomment-5212809644
@kz930 Screenshots?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ContourPlot's Grid Size is optional but crashes the operator unless it holds an integer literal [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7212:
URL: https://github.com/apache/texera/issues/7212#issuecomment-5149569350
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @kz930!
It looks like the issue description doesn't quite follow our template yet:
- This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org