You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/07/19 18:56:44 UTC
Review Request 71128: Fixed an UI issue in Roles tab where `Reserved`
is incorrect.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71128/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Vinod Kone.
Repository: mesos
Description
-------
Fixed an UI issue in Roles tab where `Reserved` is incorrect.
Diffs
-----
src/webui/app/roles/roles.html b0c57cf9c9f9a6cf8c595e3efcfcd990b2b8d6ac
Diff: https://reviews.apache.org/r/71128/diff/1/
Testing
-------
See screenshot.
File Attachments
----------------
after fix
https://reviews.apache.org/media/uploaded/files/2019/07/19/f825a9ea-a452-4b40-ac61-d5772ff203ad__Screen_Shot_2019-07-19_at_11.53.12_AM.png
Thanks,
Meng Zhu
Re: Review Request 71128: Fixed an UI issue in Roles tab where
`Reserved` is incorrect.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71128/#review216771
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 19, 2019, 6:56 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71128/
> -----------------------------------------------------------
>
> (Updated July 19, 2019, 6:56 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an UI issue in Roles tab where `Reserved` is incorrect.
>
>
> Diffs
> -----
>
> src/webui/app/roles/roles.html b0c57cf9c9f9a6cf8c595e3efcfcd990b2b8d6ac
>
>
> Diff: https://reviews.apache.org/r/71128/diff/1/
>
>
> Testing
> -------
>
> See screenshot.
>
>
> File Attachments
> ----------------
>
> after fix
> https://reviews.apache.org/media/uploaded/files/2019/07/19/f825a9ea-a452-4b40-ac61-d5772ff203ad__Screen_Shot_2019-07-19_at_11.53.12_AM.png
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71128: Fixed an UI issue in Roles tab where
`Reserved` is incorrect.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71128/#review216777
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On July 19, 2019, 11:56 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71128/
> -----------------------------------------------------------
>
> (Updated July 19, 2019, 11:56 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an UI issue in Roles tab where `Reserved` is incorrect.
>
>
> Diffs
> -----
>
> src/webui/app/roles/roles.html b0c57cf9c9f9a6cf8c595e3efcfcd990b2b8d6ac
>
>
> Diff: https://reviews.apache.org/r/71128/diff/1/
>
>
> Testing
> -------
>
> See screenshot.
>
>
> File Attachments
> ----------------
>
> after fix
> https://reviews.apache.org/media/uploaded/files/2019/07/19/f825a9ea-a452-4b40-ac61-d5772ff203ad__Screen_Shot_2019-07-19_at_11.53.12_AM.png
>
>
> Thanks,
>
> Meng Zhu
>
>