[GitHub] [helix] lei-xia commented on a change in pull request #1487: Add a configuration option to allow enable/disable writing error log to ZK

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #1487:
URL: https://github.com/apache/helix/pull/1487#discussion_r514321686



##########
File path: helix-core/src/main/java/org/apache/helix/util/StatusUpdateUtil.java
##########
@@ -560,6 +565,10 @@ void publishStatusUpdateRecord(ZNRecord record, Message message, Level level,
    */
   void publishErrorRecord(ZNRecord record, String instanceName, String updateSubPath,
       String updateKey, String sessionId, HelixDataAccessor accessor, boolean isController) {
+    _logger.error("StatusUpdate Error record: {}", record.toString());
+    if (!ERROR_LOG_TO_ZK_ENABLED) {

Review comment:
       Not actually, even we disable writting to ZK, we still need to log into local log file, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org