You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/08/16 21:25:13 UTC
[GitHub] [maven] michael-o opened a new pull request #525: Add ModelSource test for MNG-5669
michael-o opened a new pull request #525:
URL: https://github.com/apache/maven/pull/525
@mickaelistria Please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mickaelistria commented on pull request #525: Add ModelSource test for MNG-5669
Posted by GitBox <gi...@apache.org>.
mickaelistria commented on pull request #525:
URL: https://github.com/apache/maven/pull/525#issuecomment-900100217
> My wish is to deprecate and finally remove model.getPomFile():
IIRC, the issue is (or was) that the pomFile wasn't set on project if it's not set on the model. But I agree with your analysis that model shouldn't even have to reference the pom file, and this is more the duty of ProjectBuilder.
Basically, the lines that are setting pomFile in the Model when `source instanceof FileModelSource` would have to be placed in ProjectBuilder. I remember I tried that but ProjectBuilder was harder to tweak back then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mickaelistria commented on pull request #525: Add ModelSource test for MNG-5669
Posted by GitBox <gi...@apache.org>.
mickaelistria commented on pull request #525:
URL: https://github.com/apache/maven/pull/525#issuecomment-900033288
That seems good, and I'd really like to see this case covered in next Maven major; so +1 for merging it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #525: Add ModelSource test for MNG-5669
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #525:
URL: https://github.com/apache/maven/pull/525#issuecomment-900091907
My wish is to deprecate and finally remove `model.getPomFile()`: one should use MavenProject to ask for the pom file. In Maven 3 it was used as the key for the model, but with the Maven 4 code that's not required anymore. The mdo-file also demonstrates it is a weird field: it is not part of the ModelReader.
Having this test as long as this field is there is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #525: Add ModelSource test for MNG-5669
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #525:
URL: https://github.com/apache/maven/pull/525#issuecomment-900066412
Will merge soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #525: Add ModelSource test for MNG-5669
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #525:
URL: https://github.com/apache/maven/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org