You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "breskeby (via GitHub)" <gi...@apache.org> on 2025/06/21 10:55:43 UTC

[PR] [Build] Fix deprecation warning about automatic loading of test framework [lucene]

breskeby opened a new pull request, #14828:
URL: https://github.com/apache/lucene/pull/14828

   ### Description
   
   This fixes deprecation warning "The automatic loading of test framework implementation dependencies has been deprecated." Gradle test tasks relies on having the test framework on its classpath as the TestWorker has dependencies on this.
   
   In the existing setup we had only module classpaths declared in a jvm arg provider which is not taken into account by Gradle when setting up the test worker jvm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] [Build] Fix deprecation warning about automatic loading of test framework [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss merged PR #14828:
URL: https://github.com/apache/lucene/pull/14828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] [Build] Fix deprecation warning about automatic loading of test framework [lucene]

Posted by "breskeby (via GitHub)" <gi...@apache.org>.
breskeby commented on PR #14828:
URL: https://github.com/apache/lucene/pull/14828#issuecomment-2993580446

   it will be actually interesting how this will behave in gradle 9.0. Ideally it would just work as junit would be found on the module path in this case here. But I'm afraid they keep the check and just fail. 🤞 . I'll will do some testing against the 9.0-rc-1 at one point. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] [Build] Fix deprecation warning about automatic loading of test framework [lucene]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14828:
URL: https://github.com/apache/lucene/pull/14828#issuecomment-2993519544

   This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] [Build] Fix deprecation warning about automatic loading of test framework [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #14828:
URL: https://github.com/apache/lucene/pull/14828#issuecomment-2993693465

   > But I'm afraid they keep the check and just fail. 
   
   I think they shouldn't mess with extra arguments - maybe you can convince them so. It's similar to this issue -
   https://github.com/gradle/gradle/issues/11898 Messing with arguments behind the dev's back is crazy and not intuitive at all. Maybe the intentions are good but it's an evil feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org