Re: [PR] Make kinit renewable lifetime configurable for Heimdal Kerberos support [airflow]

["KenanAdel (via GitHub)" <gi...@apache.org>]

KenanAdel commented on code in PR #67804:
URL: https://github.com/apache/airflow/pull/67804#discussion_r3520071473


##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2983,6 +2983,15 @@ kerberos:
       type: boolean
       example: ~
       default: "True"
+    include_renewal_lifetime:
+      description: |
+        Whether to include the renewable lifetime option (`-r`) in the `kinit` command.
+        This is enabled by default for MIT Kerberos, but can be disabled (set to False)
+        if using a Kerberos implementation that doesn't support this flag, such as `Heimdal`.
+      version_added: 3.3.0

Review Comment:
   > Correction to my earlier note — this needs to be `3.4.0`, not `3.3.0`. 3.3.0 has already branched, so a new feature added now ships in 3.4.0.
   
   Thanks @potiuk  for the review
   
   I have updated the version_added to 3.4.0 as requested, and removed the feat: prefix from the PR title to match the project's standards.
   
   Ready for another look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org