You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2020/09/23 18:45:07 UTC
[incubator-superset] branch master updated: style(explore): use
tertiary button against gray background (#11011)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new dc76a26 style(explore): use tertiary button against gray background (#11011)
dc76a26 is described below
commit dc76a2688e7421ea6a872adef45eeabfca198465
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Wed Sep 23 11:44:39 2020 -0700
style(explore): use tertiary button against gray background (#11011)
"primary" style buttons seem to expect a white background and really
look muted against the gray background. Using "tertiary" style button makes
things much better.
Eventually we may reconsider the layout and gray background and go back
to secondary, but for now this makes these important pop much more
---
superset-frontend/src/explore/components/QueryAndSaveBtns.jsx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx b/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
index 9eaec3c..d04cf9d 100644
--- a/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
+++ b/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
@@ -73,7 +73,7 @@ export default function QueryAndSaveBtns({
chartIsStale,
errorMessage,
}) {
- let qryButtonStyle = 'secondary';
+ let qryButtonStyle = 'tertiary';
if (errorMessage) {
qryButtonStyle = 'danger';
} else if (chartIsStale) {
@@ -108,7 +108,7 @@ export default function QueryAndSaveBtns({
<ButtonGroup className="query-and-save">
{qryOrStopButton}
<Button
- buttonStyle="secondary"
+ buttonStyle="tertiary"
buttonSize="small"
data-target="#save_modal"
data-toggle="modal"