DO NOT REPLY [Bug 21972] New: - Flush is being ignored in tiles insert

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21972>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21972

Flush is being ignored in tiles insert

           Summary: Flush is being ignored in tiles insert
           Product: Struts
           Version: 1.1 Final
          Platform: All
        OS/Version: Other
            Status: NEW
          Severity: Critical
          Priority: Other
         Component: Tiles framework
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: fvoznika@hotmail.com


Let's suppose I do a
<titles:insert page="/template_main.jsp" flush="false">
...

When the code is executed, the method InsertHandler.doEndTag() (inner of
InsertTag) is called. In the end, before all catches (line 881), after correctly
testing for flush, doInclude() is called. It then calls TilesUtil.doInclude(),
that calls TilesUtilImpl.doInclude(), that calls PageContext.include(String).
According to the documentation (see bellow), this last method flushes the JspWriter.

"The current JspWriter "out" for this JSP is flushed as a side-effect of this
call, prior to processing the include."

The flush variable should be propagated to TilesUtilImpl.doInclude(), and
PageContext.include(String, boolean) called.

Always flushing, makes setting response headers, forwarding and error handling
(forwarding) impossible to use together with tile.

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org