You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/11/22 15:51:08 UTC

[GitHub] [royale-asjs] estanglerbm opened a new pull request #945: XMLList: added localName()

estanglerbm opened a new pull request #945:
URL: https://github.com/apache/royale-asjs/pull/945


   Existing Flex code can call localName() on an XMLList object.
   
   Not sure if there is some automatic conversion that needs to be implemented, or if you prefer that people call toXML().localName(), but adding localName() to XMLList seems like the easiest way to get existing code to compile unchanged.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] Harbs commented on pull request #945: XMLList: added localName()

Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #945:
URL: https://github.com/apache/royale-asjs/pull/945#issuecomment-734269638


   Merging this to get this change in the upcoming release. We can deal with error handling in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] Harbs commented on pull request #945: XMLList: added localName()

Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #945:
URL: https://github.com/apache/royale-asjs/pull/945#issuecomment-731995716


   Thanks for this. I must have missed that method. Does this throw an error in Flash if the XMLList is empty?
   
   The rest of these methods do not throw errors so I'm trying to figure out the best behavior.
   
   Also, a unit test for this would be good.
   
   @greg-dove Do we already have unit tests for single item XMLList access of XML methods?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] Harbs merged pull request #945: XMLList: added localName()

Posted by GitBox <gi...@apache.org>.
Harbs merged pull request #945:
URL: https://github.com/apache/royale-asjs/pull/945


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] greg-dove commented on pull request #945: XMLList: added localName()

Posted by GitBox <gi...@apache.org>.
greg-dove commented on pull request #945:
URL: https://github.com/apache/royale-asjs/pull/945#issuecomment-732000645


   @Harbs I can't recall, I can check first thing tomorrow local time.
   
   To answer your other question:
   
   TypeError: Error #1086: The localName method only works on lists containing one item.
   	at XMLList/http://adobe.com/AS3/2006/builtin::localName()
   	at Untitled_2_fla::MainTimeline/frame1()


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] Harbs commented on pull request #945: XMLList: added localName()

Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #945:
URL: https://github.com/apache/royale-asjs/pull/945#issuecomment-732051804


   I'm guessing the rest of the methods throw as well (and we should add that). It's probably better to use `org.apache.royale.debugging.assert` so the code to throw the error is stripped out in release.
   
   Thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org