You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/28 02:09:22 UTC
[GitHub] [spark] sunchao commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write
sunchao commented on a change in pull request #31355:
URL: https://github.com/apache/spark/pull/31355#discussion_r565769723
##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/distributions/OrderedDistribution.java
##########
@@ -32,4 +32,13 @@
* Returns ordering expressions.
*/
SortOrder[] ordering();
+
+ /**
+ * Returns the number of partitions required by this write.
Review comment:
I'm not sure if `required by this write` is accurate since we could potentially reuse this interface for read as well in future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org