[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #18823: [fix][broker] Fix delete system topic clean topic policy

[GitBox <gi...@apache.org>]

liangyepianzhou commented on code in PR #18823:
URL: https://github.com/apache/pulsar/pull/18823#discussion_r1044000930


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1221,8 +1221,7 @@ private CompletableFuture<Void> delete(boolean failIfHasSubscriptions,
 
                         deleteTopicAuthenticationFuture.thenCompose(ignore -> deleteSchema())
                                 .thenCompose(ignore -> {
-                                    if (!this.getBrokerService().getPulsar().getBrokerService()
-                                            .isSystemTopic(TopicName.get(topic))) {
+                                    if (!SystemTopicNames.isTopicPoliciesSystemTopic(topic)) {

Review Comment:
   The topic policy topic will send a message to itself and then report `topic is fenced`.
   And delete topic policy topic does not need to delete its policy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org