You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by janl <gi...@git.apache.org> on 2016/04/15 18:30:30 UTC
[GitHub] couchdb pull request: scrap make install, build full couch into re...
GitHub user janl opened a pull request:
https://github.com/apache/couchdb/pull/402
scrap make install, build full couch into rel/couchdb
As per dev@ discussion, this PR removes the more familiar behaviour of `make install` and creates a location independent directory `./rel/couchdb` that can be moved to anywhere on the system.
This is a first draft, exact naming of make targets and messages TBD. cc @rnewson @kxepal @davisp
I noticed this issue when building Fauxton:
`grunt couchdb` installs `index.html` into `share/www/index.html`, and it tries to load js files from `./dashboard.assets/js/` but these are installed into `share/www/js/`
Either `index.html` needs to not include the `dashboard.assets` path, or we need to install into that.
I tried to fix it, but fauxton master doesn’t have the subsequent copy lines, just the one for `index.html`, so I’m not sure what to do. cc @garrensmith @robertkowalski
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb no-make-install
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #402
----
commit d642df3b5ee58b3f2414218eb4deb1068d07aee0
Author: Jan Lehnardt <ja...@apache.org>
Date: 2016-04-15T07:41:56Z
scrap make install, build full couch into rel/couchdb
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-211296364
`make install` doesn’t exist :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-210558613
mmm...doesn't this introduces broken assumption issue? `make install` is about to move build artefact from local dirs to place on system from where users will use the software (rephrased [citation](https://www.gnu.org/software/make/manual/make.html#Standard-Targets) of GNU Make docs).
Now `make install` doesn't do install, but actually does sort of `pre-install`. Anyway, that's what users nor package maintainers would expect from `make install` and definitely the behaviour must follow the common guidelines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-211247246
Renamed to `make build` and made `make install` print a notice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-210565097
@garrensmith @robertkowalski ignore me, I missed an update on `master`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-211293023
@janl After morning cup of tea and rereading update, I've come to quite interesting question: how `make build` is different from `make install DESTDIR="./rel"`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-210619148
I like build. Nothing else i can think of isnt already used between make and Erlang.
> On Apr 15, 2016, at 1:33 PM, Jan Lehnardt <no...@github.com> wrote:
>
> I like build
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-210566436
Ah, I didn't read the message carefully. Hm. `make build`? Assuming that `make install` will copy build result to DESTDIR and `make dist` will put it into tarball, the name sounds more or less consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-214683096
merged, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-211242739
confirmed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-210565019
@kxepal yeah, like I said, naming is TBD, what should we make this? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-211809973
@janl ok, let see how it goes. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-211229739
PR #404 will fix the fauxton issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-211297423
@janl well, I'm not a true package maintainer, but I feel it have to, doesn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl closed the pull request at:
https://github.com/apache/couchdb/pull/402
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-210581103
I like build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/402#issuecomment-211303842
@kxepal https://pony-poc.apache.org/list.html?dev@couchdb.apache.org
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---