You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/05 00:48:12 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #146: [WIP]
Feature/vm wizard
utchoang opened a new pull request #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146
* [x] Add selection for disk offering
* [ ] Format Info card for vm config summary
* [x] Add iso selection
* [x] Add tags to the templates (featured, public, etc.)
* [x] Sort templates/isos
* [x] Pin featured templates/isos at the top of each list
* [x] Add search filter input for isos/templates
* [x] Handle form change on switching from template to iso (and vice versa)
* [ ] Add translations for all input placeholders
* [ ] Implement submit method
* [x] Add affinity group selection
* [x ] Add network selection
* [x] Add ssh key pairs selection
* [ ] Handle Navigation (e.g. reset the form on navigating away)
* [x ] Add filter possibility to selections (compute offering, disk offering, network offering, ...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] svenvogel commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586981262
@rhtyd CC @utchoang should we add groups, keyboard layout and userdata?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582299819
@rhtyd thank you. I will add a Help button for creating new network while avoiding content switch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584589801
@utchoang that's fine for the first iteration, I think as we had initially discussed I would rather prefer that all the views/sections are visible by default instead of steps/pages like the old UI's wizard. Perhaps once a user inputs say all the params of one step, the subsequent step may automatically show up?
In summary, let's just see if we can finish the first iteration and then seek feedback/reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586149008
@utchoang cc @svenvogel some review comments from testing the current branch:
- Maybe template and ISO could be show in tabs instead of collapse?
- Minor: show search bar like other steps for template/iso; the search bar could be above near to the place that may render on the right side of tabbed template/iso options
- Once I accidently select disk offering, no way to de-select it. Give a radio button to say no disk offering etc.
- Initially on the network step, if I select two networks, both are selected as default by the radio button
- Given option (radio button) to not select any ssh key (if we select one, there is no way to de-select)
- Minor nit: the launch button icon uses poweroff icon, instead maybe use a play or rocket icon?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586838027
@rhtyd Yes, I did merge the last master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586985939
@utchoang please pull --rebase your branch as I've made some changes and merged origin/master on it. As Sven describes, the following can be added:
- Support to specify keyboard
- Support to supply userdata (this would be sent as base64 encoded string as part of the api request)
- The add to instance group (existing groups may be listed using the listInstanceGroups API)
Rest is largely done, but I'm still reviewing/testing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #146: Feature/vm
wizard
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #146: Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586797368
@rhtyd cc @svenvogel
I have finished fixing the issues. Please review and give me your comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: Feature/vm
wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-604093694
Added bug https://github.com/apache/cloudstack-primate/issues/254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] svenvogel commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584890527
@utchoang i agree with @rhtyd ... please combine the nice 1..2..3 blue step line but WITH one pager (scrollable in each section) ... "no next button". it is easier for user to change. maybe we had an misunderstood.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang removed a comment on issue #146:
[WIP] Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-587321963
@rhtyd cc @svenvogel
As from https://github.com/apache/cloudstack-primate/pull/7, the template/iso is filtered by osType, which causes incorrect pagination. To solve it, I intend to change the filter from osType to filter/show by featured/community/shared etc. Please let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: Feature/vm
wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-604092773
There are still some issue but largely the feature works for some combination, I'll merge and hopefully the bugs can be fixed over time cc @shwstppr @utchoang @vladimirpetrov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] svenvogel edited a comment on issue #146:
[WIP] Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584890527
@utchoang i agree with @rhtyd ... please combine the nice 1..2..3 blue step line but WITH one pager (scrollable in each section) ... "no next button". it is easier for user to change. maybe we had an misunderstood.
additional
i mean the next is okay... but it would be cool to switch per click to each section not with an preview or next button. i dont know what possible but it would be cool to have the 1..2..3... style but all on one page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584551049
@rhtyd cc @svenvogel
Add pod, cluster and host in step Basic Setup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-587321963
@rhtyd cc @svenvogel
As from https://github.com/apache/cloudstack-primate/pull/7, the template/iso is filtered by osType, which causes incorrect pagination. To solve it, I intend to change the filter from osType to filter/show by featured/community/shared etc. Please let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582765698
@rhtyd I think I will add a Help button for creating new network while avoiding content switch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-587383708
@utchoang is this ready for review/testing now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-587321963
@rhtyd cc @svenvogel
As from https://github.com/apache/cloudstack-primate/pull/7, the template/iso is filtered by osType, which causes incorrect pagination. To solve it, I intend to change the filter from osType to filter/show by featured/community/shared etc. Please let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586838128
Great @utchoang, I'll start review/testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-583735861
@svenvogel I don't like the collapse mode, I would prefer all sections are visible. I'm okay either way to provide an option for users to create network. Maybe the network list/table can also say things like the type of the network, cidr etc. Help button is also fine. We may even reuse the create network component here to allow users to create a network, if they don't want to use an existing one.
There are some organisations that prefer network to be created, others don't. In most cases, say when deploying a VM (whether on cloud, or on desktop/server like VirtualBox or virt-manager) users usually are not allowed to create a network. For many providers the existing list of networks is like a network offering available to VMs, and users are generally only allowed to pick one of the existing ones (than create a new one). We can use router-link to allow users create networks for example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-587321963
@rhtyd cc @svenvogel
As from https://github.com/apache/cloudstack-primate/pull/7, the template/iso is filtered by osType, which causes incorrect pagination. To solve it, I intend to change the filter from osType to filter/show by featured/community/shared etc. Please let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582260474
Thanks for submitting @utchoang
@svenvogel @PaulAngus @borisstoyanov @andrijapanicsb @DaanHoogland - from internal discussions one feedback I (got from Alex) is that the VM deployment wizard should not allow creation of new networks which may be confusing for users (multiple ways to do the same thing), instead we can add a help button or text that allows users to go to the network page and create the network they want themselves. This would however remove the previous UX that allowed users to add network while they deploy a VM. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] svenvogel commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582868956
@rhtyd i my experience most of my infra user find a way for creating a network in the wizard in the process of creating a virtual machine a good way. do complete creation in one step. my most users here was confused in the old UI because they dont know "whats that for network type and where is it connected"... if this is better in new UI i think it will not confuse.
i see 2 ways.
1. like @utchoang suggest i would use a help button if we dont want creation of network or "we have an ugly content switch". this means we avoid switch the site to another and back. this is from design perpective and usability not nice for handling. at the moment we have a speedy nice one pager vm wizard. each content switch will destroy it. help button like create network there... but not switch them...
2. for me +1 for the possibility to create directly the network because we use collapse mode. users they dont want it will not use it and if you plan network before you will go directly to network tab.
@rhtyd what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586836867
@rhtyd cc @svenvogel Yes. Please review it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582315571
+1 @rhtyd for network stuff during vm deployment wizard, but as suggested, please add some button so that user can still create a network.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-585026483
@rhtyd cc @svenvogel I have changed the following. Please let me know your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586797368
@rhtyd cc @svenvogel
I have finished fixing the issues. Please review and give me your comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-585575380
@rhtyd cc @svenvogel
Regarding to "Format Info card for vm config summary" with the image below, I still have no idea of what should be done. Could you please explain?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586797368
@rhtyd cc @svenvogel
I have finished fixing the issues. Please review and give me your comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-603822631
@utchoang we don't have the functionality to add a new network on the fly like in old UI?
And can we make changes to pre-select(first entry from the list) things like zone, compute offering, etc.
Deployment works with minimal changes to variables. Will try more variations and will try to provide some fixes tomorrow. cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-587321963
@rhtyd cc @svenvogel
As from https://github.com/apache/cloudstack-primate/pull/7, the template/iso is filtered by osType, which causes incorrect pagination. To solve it, I intend to change the filter from osType to filter/show by featured/community/shared etc. Please let me know what you think.
=>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] svenvogel edited a comment on issue #146:
[WIP] Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584890527
@utchoang i agree with @rhtyd ... please combine the nice 1..2..3 blue step line but WITH one pager (scrollable in each section) ... "no next button". it is easier for user to change. maybe we had an misunderstood.
additional
i mean the next is okay... but it would be cool to switch per click to each section not with an preview or next button. i dont know what possible because this style with number and hook will be always with acknowledge button. it would be cool to have the 1..2..3... style but all on one page. maybe we get the hook button if we select the "required" settings e.g. VM Name, ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586837332
@utchoang can you merge latest master on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-603822631
@utchoang we don't have the functionality to add a new network on the fly like in old UI?
And can we make changes to pre-select(first entry from the list) things like zone, compute offering, etc.
Deployment works with minimal changes to variables. Will try more variations and will try to provide some fixes tomorrow. cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-585026483
@rhtyd cc @svenvogel I have changed the following. Please let me know your comments.
1. Default:
2. Select zone:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang removed a comment on issue #146:
[WIP] Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582299819
@rhtyd thank you. I will add a Help button for creating new network while avoiding content switch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584467673
@rhtyd cc @svenvogel
This is my new design of the layout collapse mode to steps mode. Please review and let me know your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582260474
Thanks for submitting @utchoang
@svenvogel cc @PaulAngus @borisstoyanov - from internal discussions one feedback I (got from Alex) is that the VM deployment wizard should not allow creation of new networks which may be confusing for users (multiple ways to do the same thing), instead we can add a help button or text that allows users to go to the network page and create the network they want themselves. This would however remove the previous UX that allowed users to add network while they deploy a VM. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586836718
@utchoang cc @svenvogel - is it ready for testing/review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-584551049
@rhtyd cc @svenvogel
Add pod, cluster and host
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-585575380
Regarding to "Format Info card for vm config summary" with the image below, I still have no idea of what should be done. Could you please explain?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586985939
@utchoang please pull --rebase your branch as I've made some changes and merged origin/master on it. As Sven describes, the following can be added:
- Support to specify keyboard
- Support to supply userdata (this would be sent as base64 encoded string as part of the api request)
- The add to instance group (existing groups may be listed using the listInstanceGroups API)
- Add pagination support for templates/isos (actually all possible views)
- For templates/iso show another filter criteria (filter/show by featured/community/shared etc.) - this is not clear how to show - may be skipped if you don't understand it.
Rest is largely done, but I'm still reviewing/testing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-588020152
The requirements for this task are:
* Keep the wizard in a pop-over
* Add support for both basic and advanced, ideally we would prefer the similar kind of layout/steps like in the old UI's wizard
I think the new UI already meets these demands:
1. The wizard is a popup
2. There's support info for both Basic and Advanced when it is selected. The layout is in form of steps.
Could you please explain what I should change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang removed a comment on issue #146:
[WIP] Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-585575380
@rhtyd cc @svenvogel
Regarding to "Format Info card for vm config summary" with the image below, I still have no idea of what should be done. Could you please explain?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-588012307
@rhtyd I completed fixes. Please review again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-583989693
@rhtyd cc @svenvogel There is error 503 found in http://acs.shapeblue.com:8080/client/. Please check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang removed a comment on issue #146:
[WIP] Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-588020152
The requirements for this task are:
* Keep the wizard in a pop-over
* Add support for both basic and advanced, ideally we would prefer the similar kind of layout/steps like in the old UI's wizard
I think the new UI already meets these demands:
1. The wizard is a popup
2. There's support info for both Basic and Advanced when it is selected. The layout is in form of steps.
Could you please explain what I should change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP]
Feature/vm wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #146: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586146044
Nice @utchoang - is this complete, ready for review/testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services