LocatorUDPSecurityDUnitTest started failing

[Kirk Lund <kl...@apache.org>]

I suspect there may be a recent membership/distribution/locator or even
security change that has caused LocatorUDPSecurityDUnitTest to start
failing with a suspect string.

Any ideas what might have broken this? I'm busy working on other dunit
tests so it'll be a while before I can look into this.

org.apache.geode.distributed.LocatorUDPSecurityDUnitTest >
testStartTwoLocators FAILED
    java.lang.AssertionError: Suspicious strings were written to the log
during this run.
    Fix the strings or use IgnoredException.addIgnoredException to ignore.
    -----------------------------------------------------------------------
    Found suspect string in log4j at line 2539

    [error 2020/01/16 09:59:33.406 GMT <unicast
receiver,2c5d023e5048-11767> tid=766] Exception deserializing message
payload: [dst: 2c5d023e5048<v1>:41002, src: 2c5d023e5048<v0>:41001 (2
headers), size=1324 bytes, flags=OOB|DONT_BUNDLE|NO_FC|SKIP_BARRIER]
    java.lang.Exception: Message id is -150
    at
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.readEncryptedMessage(JGroupsMessenger.java:1143)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.readJGMessage(JGroupsMessenger.java:1044)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1297)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1266)
    at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
    at org.jgroups.JChannel.up(JChannel.java:741)
    at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
    at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
    at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
    at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1077)
    at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:792)
    at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:433)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:72)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:70)
    at org.jgroups.protocols.TP.passMessageUp(TP.java:1658)
    at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1876)
    at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
    at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1789)
    at org.jgroups.protocols.TP.receive(TP.java:1714)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:159)
    at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
    at java.lang.Thread.run(Thread.java:748)
    Caused by: javax.crypto.BadPaddingException: Given final block not
properly padded. Such issues can arise if a bad key is used during
decryption.
    at com.sun.crypto.provider.CipherCore.unpad(CipherCore.java:975)
    at
com.sun.crypto.provider.CipherCore.fillOutputBuffer(CipherCore.java:1056)
    at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:853)
    at com.sun.crypto.provider.AESCipher.engineDoFinal(AESCipher.java:446)
    at javax.crypto.Cipher.doFinal(Cipher.java:2164)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.GMSEncryptionCipherPool.decryptBytes(GMSEncryptionCipherPool.java:69)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.GMSEncrypt.decryptData(GMSEncrypt.java:147)
    at
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.readEncryptedMessage(JGroupsMessenger.java:1121)
    ... 21 more