[GitHub] [shiro] bdemers commented on a change in pull request #251: [SHIRO-789] Add SameSite option to AbstractShiroWebConfiguration.buildCookie

[GitBox <gi...@apache.org>]

bdemers commented on a change in pull request #251:
URL: https://github.com/apache/shiro/pull/251#discussion_r474113444



##########
File path: support/spring/src/main/java/org/apache/shiro/spring/web/config/AbstractShiroWebConfiguration.java
##########
@@ -116,16 +120,18 @@ protected Cookie rememberMeCookieTemplate() {
                 rememberMeCookieMaxAge,
                 rememberMeCookiePath,
                 rememberMeCookieDomain,
-                rememberMeCookieSecure);
+                rememberMeCookieSecure,
+                rememberMeSameSite);
     }
 
-    protected Cookie buildCookie(String name, int maxAge, String path, String domain, boolean secure) {
+    protected Cookie buildCookie(String name, int maxAge, String path, String domain, boolean secure, Cookie.SameSiteOptions sameSizeOption) {

Review comment:
       This is technically a breaking change (if we want to merge back to 1.x)
   
   We could add something like this, to retain backward compatibility:
   ```java
   protected Cookie buildCookie(String name, int maxAge, String path, String domain, boolean secure) {
       return buildCookie(name, maxAge, path, domain, secure, sessionIdCookieSameSite);
   }
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org