[GitHub] [doris] yixiutt commented on a diff in pull request #15190: [enhancement](compaction) add delete_sign_index check before filter delete

[GitBox <gi...@apache.org>]

yixiutt commented on code in PR #15190:
URL: https://github.com/apache/doris/pull/15190#discussion_r1052852883


##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -280,6 +280,11 @@ Status BlockReader::_unique_key_next_block(Block* block, MemPool* mem_pool, Obje
     if (_filter_delete) {
         int delete_sign_idx = _reader_context.tablet_schema->field_index(DELETE_SIGN);
         DCHECK(delete_sign_idx > 0);
+        if (delete_sign_idx <= 0 || delete_sign_idx >= target_columns.size()) {

Review Comment:
   maybe we can find some bug with asan use DCEHCK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org