You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/02/18 10:05:39 UTC
[GitHub] [cordova-android] jblejder opened a new pull request #1166: (android) Add PluginEntry constructor that allows to specify onload
jblejder opened a new pull request #1166:
URL: https://github.com/apache/cordova-android/pull/1166
### Platforms affected
Android
### Motivation and Context
resolves #1164
https://github.com/apache/cordova-android/issues/1164
This will allow to specify already instantiated PluginEntries with `onload = false`.
Which will stop Cordova from initialising them multiple time and fix issue on AGP 4.1.2 that enables all asserts in debug
### Testing
have a look at test exposing issue:
https://github.com/jblejder/cordova-android/pull/1
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1166: feat: overload PluginEntry constructor to set onload property
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1166:
URL: https://github.com/apache/cordova-android/pull/1166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on a change in pull request #1166: feat: overload PluginEntry constructor to set onload property
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1166:
URL: https://github.com/apache/cordova-android/pull/1166#discussion_r613650851
##########
File path: framework/src/org/apache/cordova/PluginEntry.java
##########
@@ -52,6 +52,10 @@ public PluginEntry(String service, CordovaPlugin plugin) {
this(service, plugin.getClass().getName(), true, plugin);
}
+ public PluginEntry(String service, CordovaPlugin plugin, boolean onload) {
Review comment:
@jblejder would you be able to add in the JavaDoc comment?
You can use the below `public PluginEntry` overloaded method's comment block as an example for your overloaded method.
After this PR is updated, I can merge it in for next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1166: feat: overload PluginEntry constructor to set onload property
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1166:
URL: https://github.com/apache/cordova-android/pull/1166#issuecomment-822074797
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@3081e5e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1166 +/- ##
=========================================
Coverage ? 71.97%
=========================================
Files ? 21
Lines ? 1695
Branches ? 0
=========================================
Hits ? 1220
Misses ? 475
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3081e5e...0a2a590](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 commented on a change in pull request #1166: feat: overload PluginEntry constructor to set onload property
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #1166:
URL: https://github.com/apache/cordova-android/pull/1166#discussion_r608718128
##########
File path: framework/src/org/apache/cordova/PluginEntry.java
##########
@@ -52,6 +52,10 @@ public PluginEntry(String service, CordovaPlugin plugin) {
this(service, plugin.getClass().getName(), true, plugin);
}
+ public PluginEntry(String service, CordovaPlugin plugin, boolean onload) {
Review comment:
Could you add a JavaDoc comment for this overload? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1166: feat: overload PluginEntry constructor to set onload property
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1166:
URL: https://github.com/apache/cordova-android/pull/1166#issuecomment-822074797
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@3081e5e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1166 +/- ##
=========================================
Coverage ? 71.97%
=========================================
Files ? 21
Lines ? 1695
Branches ? 0
=========================================
Hits ? 1220
Misses ? 475
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3081e5e...0a2a590](https://codecov.io/gh/apache/cordova-android/pull/1166?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org