You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@juneau.apache.org by "James Bognar (JIRA)" <ji...@apache.org> on 2018/10/11 12:29:00 UTC

[jira] [Commented] (JUNEAU-85) Don't break compatibility with 7.1.0

    [ https://issues.apache.org/jira/browse/JUNEAU-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646372#comment-16646372 ] 

James Bognar commented on JUNEAU-85:
------------------------------------

In hindsight, this should have been done as a major release.  

There was significant refactoring involved in the code to combine the server and client side annotations.  I will be more careful in the future.

My apologies for the problems caused.

> Don't break compatibility with 7.1.0
> ------------------------------------
>
>                 Key: JUNEAU-85
>                 URL: https://issues.apache.org/jira/browse/JUNEAU-85
>             Project: Juneau
>          Issue Type: Bug
>          Components: Code
>    Affects Versions: 7.2.0
>            Reporter: Gary Gregory
>            Priority: Blocker
>
> PLEASE do not break compatibility with 7.1.0.
> Updating from 7.1.0 to 7.2.0 causes the following compiler errors in my app:
> {noformat}
> Description	Resource	Path	Location	Type
> Body cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 515	Java Problem
> Body cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 555	Java Problem
> Body cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 563	Java Problem
> Body cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 657	Java Problem
> Class<StyleMenuItem> cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 158	Java Problem
> JsonSerializer.Simple cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 119	Java Problem
> Path cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 366	Java Problem
> Path cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 627	Java Problem
> Path cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 657	Java Problem
> Query cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 403	Java Problem
> Query cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 404	Java Problem
> Query cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 515	Java Problem
> Query cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 555	Java Problem
> Query cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 563	Java Problem
> StyleMenuItem cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 158	Java Problem
> The import org.apache.juneau.rest.annotation.Body cannot be resolved	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 63	Java Problem
> The import org.apache.juneau.rest.annotation.Path cannot be resolved	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 65	Java Problem
> The import org.apache.juneau.rest.annotation.Query cannot be resolved	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 66	Java Problem
> The import org.apache.juneau.rest.widget.StyleMenuItem cannot be resolved	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 70	Java Problem
> The import org.apache.juneau.xml.XmlSchemaDocSerializer cannot be resolved	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 75	Java Problem
> XmlSchemaDocSerializer cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 122	Java Problem
> {noformat}
> Please never break binary compatibility in a minor release. Use @Deprecated in signatures and @deprecated in Javadoc.
> When I change the imports to {{org.apache.juneau.http.annotation...}} that fixes some compiler errors and leaved me with:
> {noformat}
> Description	Resource	Path	Location	Type
> Class<StyleMenuItem> cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 158	Java Problem
> JsonSerializer.Simple cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 119	Java Problem
> StyleMenuItem cannot be resolved to a type	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 158	Java Problem
> The attribute def is undefined for the annotation type Query	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 403	Java Problem
> The attribute def is undefined for the annotation type Query	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 404	Java Problem
> The import org.apache.juneau.rest.widget.StyleMenuItem cannot be resolved	AdminRootResources.java	/redacted-names/src/main/java/com/.../	line 70	Java Problem
> {noformat}
> At which point I quit, write this ticket, and go back to 7.1.0.
> You should probably use 'mvn clirr:check' or [https://github.com/siom79/japicmp] as part of your release process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)