You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/12 07:43:34 UTC
[GitHub] [camel-website] jyotiattri opened a new pull request #197: fixed
blog page categories width
jyotiattri opened a new pull request #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197
Hi,
I have found an issue on the https://camel.apache.org/blog/ for mobile screens. The main menu is going outside the page and there is a blank space in the bottom. Please check the following screenshot.
This PR fixes this problem. Here is an updated screenshot after the fix.
@zregvart please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd commented on issue #197: fixed blog page
categories width
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#issuecomment-598089139
cc @zregvart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] jyotiattri commented on issue #197: fixed blog page
categories width
Posted by GitBox <gi...@apache.org>.
jyotiattri commented on issue #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#issuecomment-598304794
For mobile screens, this media query is not working because it works only more than 769px or equal to 769px width.
For hiding the categories menu on smaller screens we should need a media query for a small screen like header.css used for mobile menus.
@zregvart Please help me on this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #197: fixed blog page
categories width
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#issuecomment-598150983
When we introduce new media selectors we take on the work to make sure that different parts of the website adhere to those selectors, this makes it difficult for us to maintain. That's why I'm hesitant to introduce new media selectors.
Perhaps this can be done within the existing media selector here:
https://github.com/apache/camel-website/blob/ce074b7f117927e3bfcedd785f10e6053bab058f/antora-ui-camel/src/css/doc.css#L39-L43
And perhaps on widths less than 769px we hide the categories menu altogether. The way we have it right now is that it's pushed to the bottom of the page which is not as nice and makes folk scroll to the bottom to see it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #197: fixed blog page
categories width
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#issuecomment-598726641
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] jyotiattri edited a comment on issue #197: fixed
blog page categories width
Posted by GitBox <gi...@apache.org>.
jyotiattri edited a comment on issue #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#issuecomment-598304794
For mobile screens, this media query is not working because it works only more than 769px or equal to 769px width.
For hiding the categories menu on smaller screens we need a media query for a small screen like header.css used for mobile menus.
@zregvart Please help me on this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #197: fixed blog page
categories width
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #197: fixed blog page
categories width
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#issuecomment-598727992
I had to revert these changes, the `doc.css` is reserved for styling the documentation, these changes need to go to either `blog.css` or to `category.css` and they need to be scoped via css rule i.e. prefixed with `.blog`. Not 100% sure on the file, on first thought `blog.css` is more appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] jyotiattri commented on issue #197: fixed blog page
categories width
Posted by GitBox <gi...@apache.org>.
jyotiattri commented on issue #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#issuecomment-598056153
Hi @oscerd
Is there anything that I can do fix the above error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] oscerd commented on issue #197: fixed blog page
categories width
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#issuecomment-598056694
I started the build again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#197: fixed blog page categories width
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #197: fixed blog page categories width
URL: https://github.com/apache/camel-website/pull/197#discussion_r392141548
##########
File path: antora-ui-camel/src/css/doc.css
##########
@@ -634,3 +634,9 @@ kbd,
.stretch {
width: 100%;
}
+/* for mobile screens */
+@media screen and (max-width: 600px) {
+ .doc aside {
+ width: auto;
+ }
+}
Review comment:
Perhaps we could remove the categories on any screen smaller than 1024px, like this:
```suggestion
@media screen and (max-width:1023px) {
.doc aside {
display: none;
}
}
```
That way we don't introduce any new media breakpoints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services