You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/02/15 02:05:46 UTC
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12496
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
---
M docs/topics/impala_disable_codegen.xml
1 file changed, 19 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/12496/1
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12496 )
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/219/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 02:05:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12496
to look at the new patch set (#2).
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
---
M docs/topics/impala_disable_codegen.xml
1 file changed, 38 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/12496/2
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12496 )
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/220/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 19:10:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12496 )
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 21:31:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12496 )
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12496/1/docs/topics/impala_disable_codegen.xml
File docs/topics/impala_disable_codegen.xml:
http://gerrit.cloudera.org:8080/#/c/12496/1/docs/topics/impala_disable_codegen.xml@48
PS1, Line 48: disabled
I think the word "disabled" can be removed here.
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 17:24:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12496 )
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/220/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 19:05:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12496 )
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/219/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 02:26:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12496 )
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12496/1/docs/topics/impala_disable_codegen.xml
File docs/topics/impala_disable_codegen.xml:
http://gerrit.cloudera.org:8080/#/c/12496/1/docs/topics/impala_disable_codegen.xml@48
PS1, Line 48: disabled
> I think the word "disabled" can be removed here.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 19:05:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8203: [DOCS] Clarified a few points in DISABLE CODEGEN
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12496 )
Change subject: IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
......................................................................
IMPALA-8203: [DOCS] Clarified a few points in DISABLE_CODEGEN
Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Reviewed-on: http://gerrit.cloudera.org:8080/12496
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
---
M docs/topics/impala_disable_codegen.xml
1 file changed, 38 insertions(+), 12 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Rodoni: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic10fd66d8a83d10c0900e93a00241d532902a759
Gerrit-Change-Number: 12496
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>