[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #219: GUACAMOLE-422: Add timezone to client handshake

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #219: GUACAMOLE-422: Add timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r272804545
 
 

 ##########
 File path: src/libguac/guacamole/user.h
 ##########
 @@ -537,32 +544,6 @@ void guac_user_free(guac_user* user);
  */
 int guac_user_handle_connection(guac_user* user, int usec_timeout);
 
-/**
- * Call the appropriate handler defined by the given user for the given
- * instruction. A comparison is made between the instruction opcode and the
- * initial handler lookup table defined in user-handlers.c. The intial handlers
- * will in turn call the user's handler (if defined).
- *
- * @param user
- *     The user whose handlers should be called.
- *
- * @param opcode
- *     The opcode of the instruction to pass to the user via the appropriate
- *     handler.
- *
- * @param argc
- *     The number of arguments which are part of the instruction.
- *
- * @param argv
- *     An array of all arguments which are part of the instruction.
- *
- * @return
- *     Non-negative if the instruction was handled successfully, or negative
- *     if an error occurred.
- */
-int guac_user_handle_instruction(guac_user* user, const char* opcode,
 
 Review comment:
   This function is part of the public API of libguac. I doubt it's in wide use, but we shouldn't delete a public function without a deprecation period.
   
   Why is this function being removed from `user.h`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services