[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1222: MINIFICPP-1695 Fix execution of native python processors

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1222:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1222#discussion_r761955487



##########
File path: extensions/script/python/ExecutePythonProcessor.cpp
##########
@@ -54,35 +54,62 @@ core::Relationship ExecutePythonProcessor::Success("success", "Script successes"
 core::Relationship ExecutePythonProcessor::Failure("failure", "Script failures");
 
 void ExecutePythonProcessor::initialize() {
-  setSupportedProperties({
-    ScriptFile,
-    ScriptBody,
-    ModuleDirectory
-  });
-  setAcceptAllProperties();
-  setSupportedRelationships({
-    Success,
-    Failure
-  });
-}
+  if (getProperties().empty()) {

Review comment:
       Why is this needed? Shouldn't `initialize` be called only once? And even if it's not, the operations inside this if block are idempotent as far as I see.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org