You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 09:10:21 UTC

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1122: WIP: fetch category from manager-api

LiteSun opened a new pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [X] Improve performance
   
   - Related issues
   resolves #532 
   ___
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1122: feat(FE): fetch category from manager-api

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122#discussion_r549579756



##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -49,13 +49,25 @@ const PluginPage: React.FC<Props> = ({
   readonly = false,
   initialData = {},
   schemaType = '',
-  onChange = () => {},
+  onChange = () => { },
 }) => {
-  const [pluginList, setPlugin] = useState<PluginComponent.Meta[][]>([]);
+  const [pluginList, setPlugin] = useState<PluginComponent.Meta[]>([]);
   const [name, setName] = useState<string>(NEVER_EXIST_PLUGIN_FLAG);
+  const [typeList, setTypeList] = useState<string[]>([]);
 
+  const firstUpperCase = ([first, ...rest]: string) => first.toUpperCase() + rest.join("")
   useEffect(() => {
-    getList().then(setPlugin);
+    fetchList().then((data) => {
+      setPlugin(data);

Review comment:
       ,




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1122: feat(FE): fetch category from manager-api

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report
   > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=desc) (bcd785d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f009244f06f4936be1c94d0c2745343577a245b8?el=desc) (f009244) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1122   +/-   ##
   =======================================
     Coverage   42.30%   42.30%           
   =======================================
     Files          31       31           
     Lines        1924     1924           
   =======================================
     Hits          814      814           
     Misses       1000     1000           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=footer). Last update [f009244...bcd785d](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1122: WIP: fetch category from manager-api

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report
   > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=desc) (f894304) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e0af89e7df02de137aeac3d4bad53cf2efde41c6?el=desc) (e0af89e) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1122   +/-   ##
   =======================================
     Coverage   41.67%   41.67%           
   =======================================
     Files          29       29           
     Lines        1819     1819           
   =======================================
     Hits          758      758           
     Misses        952      952           
     Partials      109      109           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=footer). Last update [e0af89e...f894304](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1122: WIP: fetch category from manager-api

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report
   > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=desc) (34a786b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e0af89e7df02de137aeac3d4bad53cf2efde41c6?el=desc) (e0af89e) will **increase** coverage by `0.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1122      +/-   ##
   ==========================================
   + Coverage   41.67%   41.86%   +0.19%     
   ==========================================
     Files          29       29              
     Lines        1819     1825       +6     
   ==========================================
   + Hits          758      764       +6     
   - Misses        952      953       +1     
   + Partials      109      108       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `41.81% <0.00%> (ø)` | |
   | [api/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9sb2dnaW5nLmdv) | | |
   | [api/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9yZWNvdmVyLmdv) | | |
   | [api/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9jb3JzLmdv) | | |
   | [api/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9zY2hlbWEuZ28=) | | |
   | [api/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | |
   | [api/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
   | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=footer). Last update [e0af89e...34a786b](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1122: feat(FE): fetch category from manager-api

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1122: feat(FE): fetch category from manager-api

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report
   > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=desc) (6abd809) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f009244f06f4936be1c94d0c2745343577a245b8?el=desc) (f009244) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1122   +/-   ##
   =======================================
     Coverage   42.30%   42.30%           
   =======================================
     Files          31       31           
     Lines        1924     1924           
   =======================================
     Hits          814      814           
     Misses       1000     1000           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=footer). Last update [f009244...6abd809](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1122: WIP: fetch category from manager-api

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report
   > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=desc) (3fc67a5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e0af89e7df02de137aeac3d4bad53cf2efde41c6?el=desc) (e0af89e) will **increase** coverage by `0.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1122      +/-   ##
   ==========================================
   + Coverage   41.67%   41.86%   +0.19%     
   ==========================================
     Files          29       29              
     Lines        1819     1825       +6     
   ==========================================
   + Hits          758      764       +6     
   - Misses        952      953       +1     
   + Partials      109      108       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.12% <0.00%> (+1.55%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=footer). Last update [e0af89e...3fc67a5](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1122: WIP: fetch category from manager-api

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1122:
URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report
   > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=desc) (dc50bca) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e0af89e7df02de137aeac3d4bad53cf2efde41c6?el=desc) (e0af89e) will **increase** coverage by `0.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1122      +/-   ##
   ==========================================
   + Coverage   41.67%   41.86%   +0.19%     
   ==========================================
     Files          29       29              
     Lines        1819     1825       +6     
   ==========================================
   + Hits          758      764       +6     
   - Misses        952      953       +1     
   + Partials      109      108       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `41.81% <0.00%> (ø)` | |
   | [api/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
   | [api/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | |
   | [api/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9yZWNvdmVyLmdv) | | |
   | [api/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9zY2hlbWEuZ28=) | | |
   | [api/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9sb2dnaW5nLmdv) | | |
   | [api/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9jb3JzLmdv) | | |
   | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1122/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=footer). Last update [e0af89e...dc50bca](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org