You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2017/11/07 17:37:28 UTC

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1410#discussion_r149446200
  
    --- Diff: lib/cl/ensure-externals.sh ---
    @@ -0,0 +1,12 @@
    +#!/bin/sh
    +
    +set -e
    +
    +if [ ! -d "externals/" ] ; then
    --- End diff --
    
    What happens if externals are partially populated due to a crash?  Can one run the same quicklisp command idempotently?  If so, I would remove this if statement and just always run quicklisp to make sure externals are correct.  You could perhaps make the curl command smarter to only update the file if it has changed - I suspect curl has an option for that, but I don't know...


---