You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/12/10 12:19:03 UTC
Review Request 41198: FALCON-1656 Improve
FeedHelper:getRetentionFrequency method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41198/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1656
https://issues.apache.org/jira/browse/FALCON-1656
Repository: falcon-git
Description
-------
Improve FeedHelper:getRetentionFrequency method
Diffs
-----
common/src/main/java/org/apache/falcon/entity/FeedHelper.java d601c5d
common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java c70f18d
common/src/main/java/org/apache/falcon/lifecycle/retention/AgeBasedDelete.java ccb0290
common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 3e422fc
lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java e3e7fec
Diff: https://reviews.apache.org/r/41198/diff/
Testing
-------
Unit tests already exist, just a refactoring.
Thanks,
Ajay Yadava
Re: Review Request 41198: FALCON-1656 Improve
FeedHelper:getRetentionFrequency method
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41198/#review109739
-----------------------------------------------------------
Ship it!
Ship It!
- sandeep samudrala
On Dec. 10, 2015, 11:19 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41198/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 11:19 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1656
> https://issues.apache.org/jira/browse/FALCON-1656
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Improve FeedHelper:getRetentionFrequency method
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java d601c5d
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java c70f18d
> common/src/main/java/org/apache/falcon/lifecycle/retention/AgeBasedDelete.java ccb0290
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 3e422fc
> lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java e3e7fec
>
> Diff: https://reviews.apache.org/r/41198/diff/
>
>
> Testing
> -------
>
> Unit tests already exist, just a refactoring.
>
>
> Thanks,
>
> Ajay Yadava
>
>