You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/23 15:51:11 UTC

[GitHub] [airflow] nuclearpinguin edited a comment on issue #6750: [AIRFLOW-6329] Add AirflowExecutor and native worker

nuclearpinguin edited a comment on issue #6750: [AIRFLOW-6329] Add AirflowExecutor and native worker
URL: https://github.com/apache/airflow/pull/6750#issuecomment-568508798
 
 
   From what I tested this executor works really nice. 
   
   When running the backfill I can stop the worker, then I can start it again and tasks will be executed. Sending SIGTERM to worker stops it gracefully meaning that no new tasks will be consumed but those running will be finished. 
   
   Adding `airflow consumer stop` will be helpful for `PreStop` hook when deployed on k8s.
   
   What I would really love is to change the "type" of task message. Instead of sending `["airflow", "tasks", "run", ...]` it would be nice to send `{'dag_id': dag_id, 'task_id': task_id, ... }`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services