[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11763: ARROW-14153: [C++][Dataset] Add support for batch_size in the ORC Scanner

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on a change in pull request #11763:
URL: https://github.com/apache/arrow/pull/11763#discussion_r756700129



##########
File path: cpp/src/arrow/dataset/file_orc.cc
##########
@@ -85,24 +85,20 @@ class OrcScanTask : public ScanTask {
           included_fields.push_back(name);
         }
 
+        std::shared_ptr<RecordBatchReader> recordBatchReader;
+        reader->NextStripeReader(scan_options.batch_size, included_fields, &recordBatchReader);

Review comment:
       I am not sure if using the `NextStripeReader` is correct here, see the discussion about this on the original PR adding ORC dataset support: https://github.com/apache/arrow/pull/10991#discussion_r698447362 (I initially also used `NextStripeReader`, but so the name is a bit confusing, as it doesn't iteratively reads the "next" stripe, it only reads batches from a single stripe)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org