You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/05/03 15:05:24 UTC
[GitHub] [royale-compiler] taorepoara opened a new pull request #148: Manage Defines for Embed attributes
taorepoara opened a new pull request #148:
URL: https://github.com/apache/royale-compiler/pull/148
Resolves #147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-compiler] carlosrovira commented on pull request #148: Manage Defines for Embed attributes
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #148:
URL: https://github.com/apache/royale-compiler/pull/148#issuecomment-623345408
ok. two questions:
1.- did you build all 3 repos with tests to ensure all is ok
2.- also, can you provide some example code so people trying your PR can test your changes?
(for this you can add to the PR)
In that way I can do the check
Thanks in advance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-compiler] carlosrovira commented on pull request #148: Manage Defines for Embed attributes
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #148:
URL: https://github.com/apache/royale-compiler/pull/148#issuecomment-623334530
Hi @taorepoara, maybe @aharui or @joshtynjala could take a look of this PR.
I understand that you'r making it working for SWF target only, and with you changes now we can use "Embed" metadata?
Thanks for working on it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-compiler] taorepoara edited a comment on pull request #148: Manage Defines for Embed attributes
Posted by GitBox <gi...@apache.org>.
taorepoara edited a comment on pull request #148:
URL: https://github.com/apache/royale-compiler/pull/148#issuecomment-623377954
I always have problem building the repos even using the Apache repos. I'll try on the 0.9.7 release branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-compiler] taorepoara commented on pull request #148: Manage Defines for Embed attributes
Posted by GitBox <gi...@apache.org>.
taorepoara commented on pull request #148:
URL: https://github.com/apache/royale-compiler/pull/148#issuecomment-623377954
I always have problem building the repos even using the Apache repos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-compiler] carlosrovira commented on pull request #148: Manage Defines for Embed attributes
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #148:
URL: https://github.com/apache/royale-compiler/pull/148#issuecomment-623554316
He bajado el patch a mi local y he probado a añadir una variable como la de tu ejemplo y todo parece ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-compiler] taorepoara commented on pull request #148: Manage Defines for Embed attributes
Posted by GitBox <gi...@apache.org>.
taorepoara commented on pull request #148:
URL: https://github.com/apache/royale-compiler/pull/148#issuecomment-623338687
I made the change for the ActionScript parser only, but I think it can be use for every target. I'll check that.
The "Embed" metadata was already available, but now compile time constants can be use as attribute value.
I'm using it to manage the path of an Embed element to use it as Worker. If I build in debug mode I use the debug swf, else I use the release one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-compiler] taorepoara commented on pull request #148: Manage Defines for Embed attributes
Posted by GitBox <gi...@apache.org>.
taorepoara commented on pull request #148:
URL: https://github.com/apache/royale-compiler/pull/148#issuecomment-623424287
Here are two projects :
[examples.tar.gz](https://github.com/apache/royale-compiler/files/4574461/examples.tar.gz)
I can't test them because I don't use the royale-asjs project to build my projects (since I can't build it), only the compiler and typedefs. The embed-worker project work with my compilation way and the changes I made in this RP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org