[kudu-CR] KUDU-1457 p1: krpc supports for IPv6

["Todd Lipcon (Code Review)" <ge...@cloudera.org>]

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15996 )

Change subject: KUDU-1457 p1: krpc supports for IPv6
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/rpc/rpc-test.cc
File src/kudu/rpc/rpc-test.cc:

http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/rpc/rpc-test.cc@136
PS2, Line 136:                                          testing::Values(false, true),
instead of a third bool, I think it makes more sense to change the bool to an enum with three options (doesn't make sense to be both use_unix=true and use_ipv6=true)


http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/util/net/dns_resolver-test.cc
File src/kudu/util/net/dns_resolver-test.cc:

http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/util/net/dns_resolver-test.cc@64
PS2, Line 64: ASSERT_TRUE(false)
nit: FAIL()


http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/util/net/net_util.h
File src/kudu/util/net/net_util.h:

http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/util/net/net_util.h@142
PS2, Line 142:   Network(sa_family_t family, uint128_t addr, uint128_t netmask);
does this make sense for ipv6? I dont know a lot about it but from googling it sounds like all IPV6 addresses are /64


http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:

http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/util/net/net_util.cc@206
PS2, Line 206:   hints.ai_family = AF_UNSPEC;
will this be an incompatible change of sorts? do we have to worry that clients will start resolving IPV6 endpoints for clusters which are multihomed on both ipv4 and ipv6, and stop working since now the client will talk to an ipv6 address that isn't actually listening? (old server)


http://gerrit.cloudera.org:8080/#/c/15996/2/src/kudu/util/net/net_util.cc@232
PS2, Line 232:       addr->sin6_scope_id = if_nametoindex(FLAGS_rpc_bind_interface_ipv6.c_str());
what's this doing?



-- 
To view, visit http://gerrit.cloudera.org:8080/15996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie11e8e03152513284b7088dfba6c905a2fcdf46d
Gerrit-Change-Number: 15996
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <he...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: helifu <he...@apache.org>
Gerrit-Comment-Date: Tue, 02 Jun 2020 05:40:11 +0000
Gerrit-HasComments: Yes