You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by mj...@apache.org on 2026/08/12 19:38:14 UTC
(kafka) branch 4.4 updated: KAFKA-20894: Make StreamsGroupDescription.toString null-safe (#23083)
This is an automated email from the ASF dual-hosted git repository.
mjsax pushed a commit to branch 4.4
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/4.4 by this push:
new 9aa8295b7c7 KAFKA-20894: Make StreamsGroupDescription.toString null-safe (#23083)
9aa8295b7c7 is described below
commit 9aa8295b7c71137dfdf4355ce575ece72565c3df
Author: Gimin Kim <13...@users.noreply.github.com>
AuthorDate: Thu Aug 13 04:37:06 2026 +0900
KAFKA-20894: Make StreamsGroupDescription.toString null-safe (#23083)
`DescribeStreamsGroupsOptions` field `authorizedOperations` may be
`null`. This PR adds a guard to `toString()` for this case, to handle
`null` correctly and to avoid a NPE.
Reviewers: Matthias J. Sax <ma...@confluent.io>
---
.../java/org/apache/kafka/clients/admin/StreamsGroupDescription.java | 4 +++-
.../apache/kafka/clients/admin/KafkaAdminClientStreamsGroupTest.java | 3 +++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/clients/src/main/java/org/apache/kafka/clients/admin/StreamsGroupDescription.java b/clients/src/main/java/org/apache/kafka/clients/admin/StreamsGroupDescription.java
index 6674f69b7b5..52a64ae41a5 100644
--- a/clients/src/main/java/org/apache/kafka/clients/admin/StreamsGroupDescription.java
+++ b/clients/src/main/java/org/apache/kafka/clients/admin/StreamsGroupDescription.java
@@ -247,7 +247,9 @@ public class StreamsGroupDescription {
", members=" + members.stream().map(StreamsGroupMemberDescription::toString).collect(Collectors.joining(",")) +
", groupState=" + groupState +
", coordinator=" + coordinator +
- ", authorizedOperations=" + authorizedOperations.stream().map(AclOperation::toString).collect(Collectors.joining(",")) +
+ ", authorizedOperations=" + (authorizedOperations == null ?
+ "null" :
+ authorizedOperations.stream().map(AclOperation::toString).collect(Collectors.joining(","))) +
", topologyDescription=" + topologyDescription.map(Object::toString).orElse("") +
", topologyDescriptionStatus=" + topologyDescriptionStatus +
", assignorName=" + assignorName.orElse("") +
diff --git a/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientStreamsGroupTest.java b/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientStreamsGroupTest.java
index 4853e4fa676..0c1286b4fc6 100644
--- a/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientStreamsGroupTest.java
+++ b/clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientStreamsGroupTest.java
@@ -83,6 +83,7 @@ import java.util.stream.Stream;
import static java.util.Arrays.asList;
import static java.util.Collections.singletonList;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -897,6 +898,8 @@ public class KafkaAdminClientStreamsGroupTest extends KafkaAdminClientTestBase {
final StreamsGroupDescription groupDescription = result.describedGroups().get(GROUP_ID).get();
assertNull(groupDescription.authorizedOperations());
+ String descriptionText = assertDoesNotThrow(groupDescription::toString);
+ assertTrue(descriptionText.contains(", authorizedOperations=null,"));
}
}