You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/06 04:29:15 UTC
[GitHub] [apisix] bin-ya opened a new pull request #6519: README: add new user
bin-ya opened a new pull request #6519:
URL: https://github.com/apache/apisix/pull/6519
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #6519: README: add new user
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #6519:
URL: https://github.com/apache/apisix/pull/6519#discussion_r820231446
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -54,6 +54,9 @@ sudo yum --showduplicates list apisix
# Will install the latest apisix package
sudo yum install apisix
+
+# Will install the specified version 2.10.3 apisix package
+sudo yum install apisix-2.10.3-0.el7
Review comment:
This modification has nothing to do with the title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #6519: README: add new user
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #6519:
URL: https://github.com/apache/apisix/pull/6519#discussion_r820217742
##########
File path: README.md
##########
@@ -248,22 +248,59 @@ Benchmark comparison test [details data](https://gist.github.com/membphis/137db9
A wide variety of companies and organizations use APISIX for research, production and commercial product, below are some of them:
+- Advanced Institute of Information Technology Peking University
Review comment:
Apache APISIX has a lot of users and this list will be very long. I suggest only listing some representative ones and then adding a link to the user page.
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -54,6 +54,9 @@ sudo yum --showduplicates list apisix
# Will install the latest apisix package
sudo yum install apisix
+
+# Will install the specified version 2.10.3 apisix package
+sudo yum install apisix-2.10.3-0.el7
Review comment:
and please remove this,thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #6519: README: add new user
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #6519:
URL: https://github.com/apache/apisix/pull/6519#discussion_r820229439
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -54,6 +54,9 @@ sudo yum --showduplicates list apisix
# Will install the latest apisix package
sudo yum install apisix
+
+# Will install the specified version 2.10.3 apisix package
+sudo yum install apisix-2.10.3-0.el7
Review comment:
We encourage developers to install and use the latest Apache APISIX version, @moonming you'd better leave your reason why remove this :) Because not all contributors/users know this.
##########
File path: README.md
##########
@@ -248,22 +248,59 @@ Benchmark comparison test [details data](https://gist.github.com/membphis/137db9
A wide variety of companies and organizations use APISIX for research, production and commercial product, below are some of them:
+- Advanced Institute of Information Technology Peking University
Review comment:
Hi @bin-ya, before doing such changes, we'd better open an issue or Discussion first, after discussions and we're going to do it, we could submit a PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bin-ya closed pull request #6519: docs: add new user on README.md
Posted by GitBox <gi...@apache.org>.
bin-ya closed pull request #6519:
URL: https://github.com/apache/apisix/pull/6519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #6519: README: add new user
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #6519:
URL: https://github.com/apache/apisix/pull/6519#discussion_r820236125
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -54,6 +54,9 @@ sudo yum --showduplicates list apisix
# Will install the latest apisix package
sudo yum install apisix
+
+# Will install the specified version 2.10.3 apisix package
+sudo yum install apisix-2.10.3-0.el7
Review comment:
Hi @bin-ya, usually one PR only does one thing 😄 This is helpful for reviewers and community project management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org