[GitHub] [spark] lxian commented on a change in pull request #34098: [SPARK-36842][Core] TaskSchedulerImpl - stop TaskResultGetter properly

[GitBox <gi...@apache.org>]

lxian commented on a change in pull request #34098:
URL: https://github.com/apache/spark/pull/34098#discussion_r716570505



##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -928,13 +928,17 @@ private[spark] class TaskSchedulerImpl(
   override def stop(): Unit = {
     speculationScheduler.shutdown()
     if (backend != null) {
-      backend.stop()
+      Utils.tryLogNonFatalError {
+        backend.stop()

Review comment:
       when deployed in yarn, org.apache.spark.scheduler.cluster.YarnSchedulerBackend#stop will call requestTotalExecutors() on stop. If the yarn application is killed already, it will receive an IOException on sending the RPC.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org