You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/02 00:13:00 UTC
[kudu-CR] maintenance manager: simplify test
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4294
to review the following change.
Change subject: maintenance_manager: simplify test
......................................................................
maintenance_manager: simplify test
This simplifies maintenance_manager-test a bit to avoid a condition
variable, and instead just poll from the main thread. This reduces the
complexity to understand the test a bit, and the test still runs quickly
(<100ms).
This also changes the test operation in preparation for a later patch
which will allow an operation to run multiple times in parallel and
auto-disable itself after a prescribed number of runs.
Change-Id: I265318f64771803714f48a6e96fd3260b6eafae4
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 38 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/4294/1
--
To view, visit http://gerrit.cloudera.org:8080/4294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I265318f64771803714f48a6e96fd3260b6eafae4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] maintenance manager: simplify test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: maintenance_manager: simplify test
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3195/
--
To view, visit http://gerrit.cloudera.org:8080/4294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I265318f64771803714f48a6e96fd3260b6eafae4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] maintenance manager: simplify test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: maintenance_manager: simplify test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I265318f64771803714f48a6e96fd3260b6eafae4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] maintenance manager: simplify test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: maintenance_manager: simplify test
......................................................................
maintenance_manager: simplify test
This simplifies maintenance_manager-test a bit to avoid a condition
variable, and instead just poll from the main thread. This reduces the
complexity to understand the test a bit, and the test still runs quickly
(<100ms).
This also changes the test operation in preparation for a later patch
which will allow an operation to run multiple times in parallel and
auto-disable itself after a prescribed number of runs.
Change-Id: I265318f64771803714f48a6e96fd3260b6eafae4
Reviewed-on: http://gerrit.cloudera.org:8080/4294
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 38 insertions(+), 60 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I265318f64771803714f48a6e96fd3260b6eafae4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>