You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mamallan Uthaman (JIRA)" <de...@myfaces.apache.org> on 2009/08/31 21:15:32 UTC
[jira] Created: (TRINIDAD-1562) Nokia's S60 web-browser not
displaying show/hide icon of panelAccordion
Nokia's S60 web-browser not displaying show/hide icon of panelAccordion
-----------------------------------------------------------------------
Key: TRINIDAD-1562
URL: https://issues.apache.org/jira/browse/TRINIDAD-1562
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 1.2.12-core
Environment: Nokia S60
Reporter: Mamallan Uthaman
WebKit based browser installed in Nokia's S60 is not displaying show/hide icon of panelAccordion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1562) Nokia's S60 web-browser not
displaying show/hide icon of panelAccordion
Posted by "Mamallan Uthaman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamallan Uthaman updated TRINIDAD-1562:
---------------------------------------
Status: Patch Available (was: Open)
> Nokia's S60 web-browser not displaying show/hide icon of panelAccordion
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1562
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1562
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Environment: Nokia S60
> Reporter: Mamallan Uthaman
>
> WebKit based browser installed in Nokia's S60 is not displaying show/hide icon of panelAccordion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1562) Nokia's S60 web-browser not
displaying show/hide icon of panelAccordion
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760284#action_12760284 ]
Jeanne Waldman commented on TRINIDAD-1562:
------------------------------------------
ShowDetailRenderer has this code [see below] which I don't like that much because it is putting too much skinning detail into the renderer instead of into the skin, and it doesn't follow the pattern we use in the Trinidad code.
// Requests from Nokia's WebKit-browsers are handled by desktop renderer.
// But unlike desktop browsers, Nokia's WebKit-browsers don't support icons
// that are encoded in unicode. Hence, we need to use text icons for these
// browsers.
if (isNokiaS60(arc))
{
return disclosed
? (Icon) new TextIcon(
"[-]",
null,
SkinSelectors.HIDE_SHOW_DISCLOSED_SYMBOL_STYLE_CLASS,
null)
: (Icon) new TextIcon(
"[+]",
null,
SkinSelectors.HIDE_SHOW_DISCLOSED_SYMBOL_STYLE_CLASS,
null);
}
String iconName = (disclosed
? SkinSelectors.AF_SHOW_DETAIL_DISCLOSED_ICON_NAME
: SkinSelectors.AF_SHOW_DETAIL_UNDISCLOSED_ICON_NAME);
return arc.getIcon(iconName);
Questions:
1. Which skin gets used when the agent is Nokia? (desktop)
2. If pda, can we define the text icon for all pdas? N/A
3. If so, you can define this Text icon for the SkinSelectors.AF_SHOW_DETAIL_DISCLOSED_ICON_NAME skin key in the Pda Skin. N/A
4. If not, then you could add a private skin key, and use that instead if it is Nokia. Then at least the Renderer code is cleaner, and you've moved the creation of the TextIcon to the Skin where it belongs.
5. Maybe there is an even cleaner way, but I'd have to think more about it.:
Example:
if (isNokiaS60)
{
iconName = (disclosed
? SkinSelectors.AF_SHOW_DETAIL_DISCLOSED_ICON_FOR_NOKIA_NAME
: SkinSelectors.AF_SHOW_DETAIL_UNDISCLOSED_ICON_FOR_NOKIA_NAME);}
else
{
iconName = (disclosed
? SkinSelectors.AF_SHOW_DETAIL_DISCLOSED_ICON_NAME
: SkinSelectors.AF_SHOW_DETAIL_UNDISCLOSED_ICON_NAME);
}
return arc.getIcon(iconName);
> Nokia's S60 web-browser not displaying show/hide icon of panelAccordion
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1562
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1562
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Environment: Nokia S60
> Reporter: Mamallan Uthaman
> Attachments: TRINIDAD-1562.patch
>
>
> WebKit based browser installed in Nokia's S60 is not displaying show/hide icon of panelAccordion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1562) Nokia's S60 web-browser not
displaying show/hide icon of panelAccordion
Posted by "Mamallan Uthaman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamallan Uthaman updated TRINIDAD-1562:
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.13-core
Status: Resolved (was: Patch Available)
The patch has already been applied to the branch 1.2.12.1 and 1.2.12.2
> Nokia's S60 web-browser not displaying show/hide icon of panelAccordion
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1562
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1562
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Environment: Nokia S60
> Reporter: Mamallan Uthaman
> Fix For: 1.2.13-core
>
> Attachments: TRINIDAD-1562-branch.patch, TRINIDAD-1562.patch
>
>
> WebKit based browser installed in Nokia's S60 is not displaying show/hide icon of panelAccordion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1562) Nokia's S60 web-browser not
displaying show/hide icon of panelAccordion
Posted by "Mamallan Uthaman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamallan Uthaman updated TRINIDAD-1562:
---------------------------------------
Status: Patch Available (was: Open)
> Nokia's S60 web-browser not displaying show/hide icon of panelAccordion
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1562
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1562
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Environment: Nokia S60
> Reporter: Mamallan Uthaman
> Attachments: TRINIDAD-1562-branch.patch, TRINIDAD-1562.patch
>
>
> WebKit based browser installed in Nokia's S60 is not displaying show/hide icon of panelAccordion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TRINIDAD-1562) Nokia's S60
web-browser not displaying show/hide icon of panelAccordion
Posted by "Mamallan Uthaman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762838#action_12762838 ]
Mamallan Uthaman edited comment on TRINIDAD-1562 at 10/6/09 6:40 PM:
---------------------------------------------------------------------
Skinning logic is removed from the renderer as you suggested. TRINIDAD-1562.patch applies to the trunk only.
was (Author: mamallan.uthaman):
This patch applies to the trunk only
> Nokia's S60 web-browser not displaying show/hide icon of panelAccordion
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1562
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1562
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Environment: Nokia S60
> Reporter: Mamallan Uthaman
> Attachments: TRINIDAD-1562.patch
>
>
> WebKit based browser installed in Nokia's S60 is not displaying show/hide icon of panelAccordion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1562) Nokia's S60 web-browser not
displaying show/hide icon of panelAccordion
Posted by "Mamallan Uthaman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mamallan Uthaman updated TRINIDAD-1562:
---------------------------------------
Status: Open (was: Patch Available)
> Nokia's S60 web-browser not displaying show/hide icon of panelAccordion
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1562
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1562
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.12-core
> Environment: Nokia S60
> Reporter: Mamallan Uthaman
> Attachments: TRINIDAD-1562.patch
>
>
> WebKit based browser installed in Nokia's S60 is not displaying show/hide icon of panelAccordion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.