[jira] [Commented] (THRIFT-2045) C++ compiler warning and build cleanup

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789636#comment-13789636 ] 

Jens Geyer commented on THRIFT-2045:
------------------------------------

I run into a minor and easy to fix Problem with the Go Generator, there's another #ifndef MINGW to be replaced with #ifndef _WIN32  =>  +1 if this one is fixed too.

> C++ compiler warning and build cleanup
> --------------------------------------
>
>                 Key: THRIFT-2045
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2045
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, Go - Compiler, Python - Compiler
>    Affects Versions: 0.9
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: windows_compiler_port.patch
>
>
> Fixing assorted warnings and minor issues in the compiler:
> * Fixing a warning in C++ generated code concerning an unused catch argument in oneway functions.
> * Generally using _WIN32 instead of MINGW as a test for Windows.  Building the compiler should no longer require the build process to define MINGW.
> * Providing THRIFT_PATH_MAX for the portable portions of the code.  This evaluates to either MAX_PATH or PATH_MAX, depending on whichever one is available.
> * Shrank "value" field of t_field_id in order to clean up warnings.  I suspect that thrift doesn't support more than 2 billion fields anyway.
> * Squelching various warnings in code, instead of in the build process.  FOr example, "unreferenced label", "switch statement contains 'default' but no 'case' labels", and "bool conversion performance warnings" are all disabled via pragma now, at appropriate locations.



--
This message was sent by Atlassian JIRA
(v6.1#6144)