You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2016/03/23 21:05:57 UTC
GitHub pull request housekeeping
Hey
So, I don't know about the other repositories, but cordova-android on
GitHub has a lot of pull requests that are obviously never going to be
accepted because they're out of date or are not on the master branch.
Since we have no plans to merge things onto 3.7.x or the 4.1.x branches, it
would be good if we could somehow close them.
AFAIK, the only way we can close them is by editing README.md and putting
in the git message. "This closes #<pull_request_num>", but it would be kind
of annoying to have to do that. That said, may be we should do that for
housekeeping.
What do people think?
Joe
Re: GitHub pull request housekeeping
Posted by Jesse <pu...@gmail.com>.
Yeah, I also have done the allow-empty way:
git commit --allow-empty -m "Closing stale pull requests: close #99, close
#46, close #82" ...
@purplecabbage
risingj.com
On Wed, Mar 23, 2016 at 12:01 PM, Carlos Santana <cs...@gmail.com>
wrote:
> I have done cleaning by using coho instructions on other repos in the past
>
> You can close multiple PRs with one commit
>
> - Carlos
> @csantanapr
>
> > On Mar 23, 2016, at 4:10 PM, julio cesar sanchez <jc...@gmail.com>
> wrote:
> >
> > On cordova coho there is a section "Stale Pull Requests"
> >
> > To close a pull request that is no longer relevant / active:
> >
> > - Create an empty commit in the repo of the pull request via:
> > - `git commit --allow-empty -m "Closing stale pull request: close
> #99"
> >
> > So I think it can be done without editing the README.md (never tried)
> >
> >
> > I sometimes ask the PR owner to close it if it's not going to be merged,
> > but if he doesn't close it in a few days we can do this.
> >
> >
> >
> >
> >
> > 2016-03-23 21:05 GMT+01:00 Joe Bowser <bo...@gmail.com>:
> >
> >> Hey
> >>
> >> So, I don't know about the other repositories, but cordova-android on
> >> GitHub has a lot of pull requests that are obviously never going to be
> >> accepted because they're out of date or are not on the master branch.
> >> Since we have no plans to merge things onto 3.7.x or the 4.1.x
> branches, it
> >> would be good if we could somehow close them.
> >>
> >> AFAIK, the only way we can close them is by editing README.md and
> putting
> >> in the git message. "This closes #<pull_request_num>", but it would be
> kind
> >> of annoying to have to do that. That said, may be we should do that for
> >> housekeeping.
> >>
> >> What do people think?
> >>
> >> Joe
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: GitHub pull request housekeeping
Posted by Carlos Santana <cs...@gmail.com>.
I have done cleaning by using coho instructions on other repos in the past
You can close multiple PRs with one commit
- Carlos
@csantanapr
> On Mar 23, 2016, at 4:10 PM, julio cesar sanchez <jc...@gmail.com> wrote:
>
> On cordova coho there is a section "Stale Pull Requests"
>
> To close a pull request that is no longer relevant / active:
>
> - Create an empty commit in the repo of the pull request via:
> - `git commit --allow-empty -m "Closing stale pull request: close #99"
>
> So I think it can be done without editing the README.md (never tried)
>
>
> I sometimes ask the PR owner to close it if it's not going to be merged,
> but if he doesn't close it in a few days we can do this.
>
>
>
>
>
> 2016-03-23 21:05 GMT+01:00 Joe Bowser <bo...@gmail.com>:
>
>> Hey
>>
>> So, I don't know about the other repositories, but cordova-android on
>> GitHub has a lot of pull requests that are obviously never going to be
>> accepted because they're out of date or are not on the master branch.
>> Since we have no plans to merge things onto 3.7.x or the 4.1.x branches, it
>> would be good if we could somehow close them.
>>
>> AFAIK, the only way we can close them is by editing README.md and putting
>> in the git message. "This closes #<pull_request_num>", but it would be kind
>> of annoying to have to do that. That said, may be we should do that for
>> housekeeping.
>>
>> What do people think?
>>
>> Joe
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: GitHub pull request housekeeping
Posted by julio cesar sanchez <jc...@gmail.com>.
On cordova coho there is a section "Stale Pull Requests"
To close a pull request that is no longer relevant / active:
- Create an empty commit in the repo of the pull request via:
- `git commit --allow-empty -m "Closing stale pull request: close #99"
So I think it can be done without editing the README.md (never tried)
I sometimes ask the PR owner to close it if it's not going to be merged,
but if he doesn't close it in a few days we can do this.
2016-03-23 21:05 GMT+01:00 Joe Bowser <bo...@gmail.com>:
> Hey
>
> So, I don't know about the other repositories, but cordova-android on
> GitHub has a lot of pull requests that are obviously never going to be
> accepted because they're out of date or are not on the master branch.
> Since we have no plans to merge things onto 3.7.x or the 4.1.x branches, it
> would be good if we could somehow close them.
>
> AFAIK, the only way we can close them is by editing README.md and putting
> in the git message. "This closes #<pull_request_num>", but it would be kind
> of annoying to have to do that. That said, may be we should do that for
> housekeeping.
>
> What do people think?
>
> Joe
>