You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by ri...@apache.org on 2010/03/04 21:15:29 UTC
svn commit: r919153 -
/felix/trunk/framework/src/main/java/org/apache/felix/framework/resolver/ResolverImpl.java
Author: rickhall
Date: Thu Mar 4 20:15:28 2010
New Revision: 919153
URL: http://svn.apache.org/viewvc?rev=919153&view=rev
Log:
Add a "to do" comment.
Modified:
felix/trunk/framework/src/main/java/org/apache/felix/framework/resolver/ResolverImpl.java
Modified: felix/trunk/framework/src/main/java/org/apache/felix/framework/resolver/ResolverImpl.java
URL: http://svn.apache.org/viewvc/felix/trunk/framework/src/main/java/org/apache/felix/framework/resolver/ResolverImpl.java?rev=919153&r1=919152&r2=919153&view=diff
==============================================================================
--- felix/trunk/framework/src/main/java/org/apache/felix/framework/resolver/ResolverImpl.java (original)
+++ felix/trunk/framework/src/main/java/org/apache/felix/framework/resolver/ResolverImpl.java Thu Mar 4 20:15:28 2010
@@ -1199,6 +1199,11 @@
Map<Requirement, Set<Capability>> candidateMap)
throws ResolveException
{
+// TODO: FELIX3 - I think permutation is not as efficient as it could be, since
+// we will end up generating permutations that are subsets of previous
+// permutations as we cycle through candidates. We should check if an
+// existing candidate map already has removed the conflicting candidate.
+
// Try to remove the previously selected candidate associated
// with the requirement blamed for adding the constraint. This
// blamed requirement may be null if the bundle itself is